works, somewhat

This commit is contained in:
Green Sky 2022-12-20 02:23:54 +01:00
parent a0c87e5fc5
commit cb0c2642f8
No known key found for this signature in database

View File

@ -484,7 +484,44 @@ void toxThread(SharedContext* ctx) {
std::cout << "tox connected to group\n"; std::cout << "tox connected to group\n";
} }
} else { // do the thing } else { // do the thing
// pump from buffer to staging { // pump from buffer to staging
const size_t max_commands = 1;
size_t number_of_commands_done = 0;
std::lock_guard lg_staging{ctx->staging_mutex};
for (auto& [agent, buffer] : ctx->buffer) {
if (agent == agent_local) {
// skip ? self
continue;
}
if (number_of_commands_done >= max_commands) {
break;
}
// determain the seq we are looking for in buffer
uint64_t seq {0};
if (ctx->staging_frontier.count(agent)) {
seq = ctx->staging_frontier.at(agent) + 1;
}
if (!buffer.count(seq)) { // not in buffer, skip
continue;
}
// this can lead to dead locks, if other code does this wrong
std::lock_guard lg{ctx->command_lists_mutex};
for (; buffer.count(seq); seq++) {
ctx->command_lists[agent][seq] = buffer.at(seq);
number_of_commands_done++;
if (number_of_commands_done >= max_commands) {
break;
}
}
ctx->staging_frontier[agent] = seq;
ctx->should_gossip_remote.emplace(agent);
}
}
// request missing in buffer // request missing in buffer
@ -782,10 +819,20 @@ int main(void) {
for (const auto& [agent, staging_seq] : ctx.staging_frontier) { for (const auto& [agent, staging_seq] : ctx.staging_frontier) {
// check if remote newer // check if remote newer
if (!ctx.command_frontier.count(agent) || ctx.command_frontier.at(agent) < staging_seq) { if (!ctx.command_frontier.count(agent) || ctx.command_frontier.at(agent) < staging_seq) {
for (uint64_t seq = ctx.command_frontier[agent]; seq <= staging_seq; seq++) { uint64_t seq {0};
if (ctx.command_frontier.count(agent)) {
seq = ctx.command_frontier[agent] + 1;
}
for (; seq <= staging_seq; seq++) {
// !! this can get expensive, while we are holding locks :/ // !! this can get expensive, while we are holding locks :/
bool r = doc.apply(ctx.command_lists.at(agent).at(seq).ops); bool r = doc.apply(ctx.command_lists.at(agent).at(seq).ops);
if (!r) {
std::cout << "faild to apply:\n";
for (const auto& op : ctx.command_lists.at(agent).at(seq).ops) {
std::cout << " " << op << "\n";
}
}
assert(r && "this should not happen"); assert(r && "this should not happen");
} }
@ -860,11 +907,12 @@ int main(void) {
} }
assert(doc.getText() == new_text); assert(doc.getText() == new_text);
if (!ops.empty()) {
// TODO: make something less locky // TODO: make something less locky
// TODO: make method // TODO: make method
{ {
std::lock_guard mg{ctx.command_lists_mutex}; std::lock_guard mg{ctx.command_lists_mutex};
assert(ctx.command_lists.size() == ctx.command_frontier.size()); //assert(ctx.command_lists.size() == ctx.command_frontier.size());
auto& local_command_list = ctx.command_lists[ctx.agent]; auto& local_command_list = ctx.command_lists[ctx.agent];
@ -886,6 +934,7 @@ int main(void) {
} }
} }
ctx.should_gossip_local.store(true); ctx.should_gossip_local.store(true);
}
} else { } else {
std::cout << "unknown command '" << command << "'\n"; std::cout << "unknown command '" << command << "'\n";
} }