From 16cb755191f2ef2fee5a3065975744d585de75ec Mon Sep 17 00:00:00 2001
From: Green Sky <green@g-s.xyz>
Date: Mon, 22 Jul 2024 19:49:02 +0200
Subject: [PATCH] fix dangerous unchecked file stream read

---
 solanaceae/ngc_ft1_sha1/file_rw_mapped.hpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/solanaceae/ngc_ft1_sha1/file_rw_mapped.hpp b/solanaceae/ngc_ft1_sha1/file_rw_mapped.hpp
index 69b90a7..b2b4f20 100644
--- a/solanaceae/ngc_ft1_sha1/file_rw_mapped.hpp
+++ b/solanaceae/ngc_ft1_sha1/file_rw_mapped.hpp
@@ -8,6 +8,7 @@
 #include <fstream>
 #include <iostream>
 #include <cstring>
+#include <cassert>
 
 struct File2RWMapped : public File2I {
 	mio::ummap_sink _file_map;
@@ -64,8 +65,14 @@ struct File2RWMapped : public File2I {
 	}
 
 	ByteSpanWithOwnership read(uint64_t size, int64_t pos = -1) override {
+		// TODO: support streaming read
+		if (pos < 0) {
+			assert(false && "streaming not implemented");
+			return ByteSpan{};
+		}
+
 		if (pos+size > _file_size) {
-			//assert(false && "read past end");
+			assert(false && "read past end");
 			return ByteSpan{};
 		}