2023-07-25 11:53:09 +02:00
|
|
|
#include "group_announce.h"
|
|
|
|
|
|
|
|
#include <cassert>
|
2023-10-10 19:37:39 +02:00
|
|
|
#include <functional>
|
2023-07-25 11:53:09 +02:00
|
|
|
#include <memory>
|
|
|
|
#include <vector>
|
|
|
|
|
Squashed 'external/toxcore/c-toxcore/' changes from e2c01e457b..b03b571272
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to.
32e67ab4c2 cleanup: use typedef for private message ID's in callback
7b1db6adc1 feat: add message IDs to private group messages
99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets
b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests
e742deddff feat: Check hashes of Windows dependencies when cross-compiling
dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image
14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes
ed37616249 docs: Update the Windows cross-compilation section
9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies
19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows
1be311e51f feat: Build the fun utils when cross-compiling to Windows
88133f8446 chore: Strip Windows binaries
3cc0ae7535 refactor: Copy over all of the required static dependencies
c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows
74bbac5363 feat: Let CMake create the dll instead of doing so ourselves
246642e9ae feat: Harden Windows cross-compilation
8d431c0d11 chore: Bump Windows build dependency versions
e519f7998b fix: Remove unnecessary wsock32 dependency on Windows
ed2b60c217 chore: Use a specific non-broken slimcc version.
d7f21010a1 chore: Update github actions.
e71a68b7f2 docs: Update the list of CMake options
77e08876ff chore: Remove mod and founder from group API naming scheme
12bc042767 docs: add the experimental api build option to INSTALL.md
e1fa5cae96 refactor: Rename Queries to Query to align with other enums.
be82a3ea30 fix: Correct type for conference offline peer numbers.
0627c36716 test: Add pkgsrc build.
92578afe4b test: Add FreeBSD VM action on GitHub.
52ece0f57b test: Build toxcore on NetBSD (VM).
3fe8ee2c11 chore: Only install tox_private.h on request.
9a8dfa06ab fix: save_compatibility_test failing on big-endian systems
86f5e55578 fix: Don't serve files from websockify.
710eb674a5 fix: Correctly pass extended public keys to group moderation code.
021db7031c refactor: Use `struct`s for extended public/secret keys.
a1e999fd80 chore: Compile libsodium reference implementation with compcert.
fbe3c19cf5 cleanup: correct a few nullable annotations
623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`.
c71567dc18 fix: Pass array, not array pointer, to `memcmp`.
9b46a08144 cleanup: Never pass `void*` directly to `memcpy`.
5d7b7a7bbc refactor: Use tox rng to seed the keypair generation.
961891d568 cleanup: Small improvements found by PVS Studio.
8201019f0d chore: Disable NGC saving by default, enable through Tox_Options.
5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`.
ca4606d49d refactor: Use strong typedef for NGC peer id.
442213b722 cleanup: Simplify custom packet length check in NGC.
08d3393def fix: Correct a few potential null derefs in bootstrap daemon.
b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope.
dab5fe44b9 fix: Zero out stack-allocated secret key before return.
f058103299 refactor: Make prune_gc_sanctions_list more obviously correct.
3ba7a0dec9 docs: Add static analysis tool list to README.
8d0811a0f3 docs: Run prettier-markdown on markdown files.
969e3a2bfc refactor: Fix network test not using the strong typedef
93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`.
9fe18b176f fix: Fix some false positive from PVS Studio.
7c44379ccb cleanup: Check that WINXP macro exists before comparing it.
5c93231bef refactor: Make tox mutex non-recursive.
aacff73939 docs: Fix up doxyfile.
d55fc85ff5 docs: Add more documentation to crypto_core.
5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`.
e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests.
34df938f52 chore: Use C++ mode for clang-tidy.
8b05296a78 chore: Check that both gtest and gmock exist for tests.
42010660e1 test: Add slimcc compiler compatibility test.
b473630321 chore: Add some comments to the astyle config.
b7404f24f6 cleanup: Remove implicit bool conversions.
4e2dba4d9f chore: Reformat sources with astyle.
4359e3a6bc chore: Rename C++ headers to .hh suffixes.
0c05566e58 cleanup: Further `#include` cleanups.
8d29935b7a chore: Only check the bootstrap daemon checksum on release.
f70e588bc6 cleanup: Add more `const` where possible.
511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene.
1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module.
a975943564 chore: Really fix coverage docker image build.
c08409390f chore: Fix post-submit coverage image.
39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s.
d94246a906 fix: partially fix a bug that prevented group part messages from sending.
eeaa039222 chore: Fix rpm build; add a CI check for it.
8328449c1a chore: Speed up docker builds a bit by reducing layer count.
d6d67d56f3 cleanup: Add `const` where possible in auto tests.
6aa9e6850d cleanup: Minor cleanup of event unpack code.
bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`.
203e1af81e fix: a few off by one errors in group autotests
5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`.
662c2140f3 test: Add goblint static analyser.
8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`.
a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`.
6370d0f15d cleanup: Expand the `Tox_Options` accessor macros.
14a1a0b9bd cleanup: Remove plan9 support.
a05dccad13 test: Add a simple new/delete test for Tox.
1cdcf938b9 cleanup: Add comment after every `#endif`.
ba99d4dc4b test: Fix comment I broke in the events test PR.
e07248debb refactor: Migrate auto_tests to new events API.
bdd42b5452 refactor: Add common msgpack array packer with callback.
3c659f5288 cleanup: Rename group to conference in groupav documentation.
89957be230 cleanup: Ensure handler params are named after callback params.
c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks.
e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events.
5e2c8cabc1 cleanup: make some improvements to group moderation test
259de4867e cleanup: Remove `bin_pack_{new,free}`.
21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion
16809dc36e feat: Add dht_get_nodes_response event to the events system.
git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
2024-03-07 23:12:55 +01:00
|
|
|
#include "../testing/fuzzing/fuzz_support.hh"
|
2024-01-14 21:51:01 +01:00
|
|
|
#include "mem_test_util.hh"
|
2023-07-25 11:53:09 +02:00
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
void TestUnpackAnnouncesList(Fuzz_Data &input)
|
|
|
|
{
|
2024-01-12 21:30:48 +01:00
|
|
|
CONSUME1_OR_RETURN(const uint8_t, max_count, input);
|
|
|
|
// Always allocate at least something to avoid passing nullptr to functions below.
|
|
|
|
std::vector<GC_Announce> announces(max_count + 1);
|
2023-07-25 11:53:09 +02:00
|
|
|
|
|
|
|
// TODO(iphydf): How do we know the packed size?
|
2024-01-12 21:30:48 +01:00
|
|
|
CONSUME1_OR_RETURN(const uint16_t, packed_size, input);
|
2023-07-25 11:53:09 +02:00
|
|
|
|
2024-12-19 16:27:40 +01:00
|
|
|
Test_Memory mem;
|
|
|
|
Logger *logger = logger_new(mem);
|
2024-01-14 21:51:01 +01:00
|
|
|
if (gca_unpack_announces_list(logger, input.data(), input.size(), announces.data(), max_count)
|
2023-07-25 11:53:09 +02:00
|
|
|
!= -1) {
|
2024-01-12 21:30:48 +01:00
|
|
|
// Always allocate at least something to avoid passing nullptr to functions below.
|
|
|
|
std::vector<uint8_t> packed(packed_size + 1);
|
2023-07-25 11:53:09 +02:00
|
|
|
size_t processed;
|
|
|
|
gca_pack_announces_list(
|
2024-01-12 21:30:48 +01:00
|
|
|
logger, packed.data(), packed_size, announces.data(), max_count, &processed);
|
2023-07-25 11:53:09 +02:00
|
|
|
}
|
|
|
|
logger_kill(logger);
|
|
|
|
}
|
|
|
|
|
|
|
|
void TestUnpackPublicAnnounce(Fuzz_Data &input)
|
|
|
|
{
|
|
|
|
GC_Public_Announce public_announce;
|
|
|
|
|
|
|
|
// TODO(iphydf): How do we know the packed size?
|
2024-01-12 21:30:48 +01:00
|
|
|
CONSUME1_OR_RETURN(const uint16_t, packed_size, input);
|
2023-07-25 11:53:09 +02:00
|
|
|
|
2024-12-19 16:27:40 +01:00
|
|
|
Test_Memory mem;
|
|
|
|
Logger *logger = logger_new(mem);
|
2024-01-14 21:51:01 +01:00
|
|
|
if (gca_unpack_public_announce(logger, input.data(), input.size(), &public_announce) != -1) {
|
2024-01-12 21:30:48 +01:00
|
|
|
// Always allocate at least something to avoid passing nullptr to functions below.
|
|
|
|
std::vector<uint8_t> packed(packed_size + 1);
|
|
|
|
gca_pack_public_announce(logger, packed.data(), packed_size, &public_announce);
|
2023-07-25 11:53:09 +02:00
|
|
|
}
|
|
|
|
logger_kill(logger);
|
|
|
|
}
|
|
|
|
|
|
|
|
void TestDoGca(Fuzz_Data &input)
|
|
|
|
{
|
2024-01-14 21:51:01 +01:00
|
|
|
Test_Memory mem;
|
2024-12-19 16:27:40 +01:00
|
|
|
std::unique_ptr<Logger, void (*)(Logger *)> logger(logger_new(mem), logger_kill);
|
2024-01-14 21:51:01 +01:00
|
|
|
|
|
|
|
uint64_t clock = 1;
|
2023-10-10 19:37:39 +02:00
|
|
|
std::unique_ptr<Mono_Time, std::function<void(Mono_Time *)>> mono_time(
|
2024-01-14 21:51:01 +01:00
|
|
|
mono_time_new(
|
|
|
|
mem, [](void *user_data) { return *static_cast<uint64_t *>(user_data); }, &clock),
|
|
|
|
[mem](Mono_Time *ptr) { mono_time_free(mem, ptr); });
|
2023-07-25 11:53:09 +02:00
|
|
|
assert(mono_time != nullptr);
|
|
|
|
std::unique_ptr<GC_Announces_List, void (*)(GC_Announces_List *)> gca(new_gca_list(), kill_gca);
|
|
|
|
assert(gca != nullptr);
|
|
|
|
|
2024-01-14 21:51:01 +01:00
|
|
|
while (!input.empty()) {
|
2024-01-12 21:30:48 +01:00
|
|
|
CONSUME1_OR_RETURN(const uint8_t, choice, input);
|
2023-07-25 11:53:09 +02:00
|
|
|
switch (choice) {
|
|
|
|
case 0: {
|
|
|
|
// Add an announce.
|
2024-01-12 21:30:48 +01:00
|
|
|
CONSUME1_OR_RETURN(const uint16_t, length, input);
|
2023-07-25 11:53:09 +02:00
|
|
|
CONSUME_OR_RETURN(const uint8_t *data, input, length);
|
|
|
|
GC_Public_Announce public_announce;
|
|
|
|
if (gca_unpack_public_announce(logger.get(), data, length, &public_announce) != -1) {
|
|
|
|
gca_add_announce(mono_time.get(), gca.get(), &public_announce);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case 1: {
|
|
|
|
// Advance the time by a number of tox_iteration_intervals.
|
2024-01-12 21:30:48 +01:00
|
|
|
CONSUME1_OR_RETURN(const uint8_t, iterations, input);
|
2023-07-25 11:53:09 +02:00
|
|
|
clock += iterations * 20;
|
|
|
|
// Do an iteration.
|
|
|
|
do_gca(mono_time.get(), gca.get());
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case 2: {
|
|
|
|
// Get announces.
|
2024-01-12 21:30:48 +01:00
|
|
|
CONSUME1_OR_RETURN(const uint8_t, max_nodes, input);
|
2024-01-14 21:51:01 +01:00
|
|
|
// Always allocate at least something to avoid passing nullptr to functions below.
|
|
|
|
std::vector<GC_Announce> gc_announces(max_nodes + 1);
|
2023-07-25 11:53:09 +02:00
|
|
|
CONSUME_OR_RETURN(const uint8_t *chat_id, input, CHAT_ID_SIZE);
|
|
|
|
CONSUME_OR_RETURN(const uint8_t *except_public_key, input, ENC_PUBLIC_KEY_SIZE);
|
|
|
|
gca_get_announces(
|
|
|
|
gca.get(), gc_announces.data(), max_nodes, chat_id, except_public_key);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case 3: {
|
|
|
|
// Remove a chat.
|
|
|
|
CONSUME_OR_RETURN(const uint8_t *chat_id, input, CHAT_ID_SIZE);
|
|
|
|
cleanup_gca(gca.get(), chat_id);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size);
|
|
|
|
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
|
|
|
|
{
|
2024-01-14 21:51:01 +01:00
|
|
|
fuzz_select_target<TestUnpackAnnouncesList, TestUnpackPublicAnnounce, TestDoGca>(data, size);
|
2023-07-25 11:53:09 +02:00
|
|
|
return 0;
|
|
|
|
}
|