Merge commit '9ace11a0e2843cbde4af2b6ff7b49bcc6d429f78'

external/toxcore/c-toxcore/other/docker/autotools/Dockerfile

@@ -2,7 +2,8 @@
 # autotools-linux
 FROM ubuntu:22.04
 
-RUN apt-get update && apt-get install --no-install-recommends -y \
+RUN apt-get update && \
+ DEBIAN_FRONTEND="noninteractive" apt-get install -y --no-install-recommends \
  autoconf \
  automake \
  ca-certificates \

external/toxcore/c-toxcore/other/docker/clang-tidy/Dockerfile

@@ -0,0 +1,21 @@
+FROM alpine:3.19.0
+
+RUN ["apk", "add", "--no-cache", \
+ "bash", \
+ "clang", \
+ "clang-extra-tools", \
+ "cmake", \
+ "colordiff", \
+ "libconfig-dev", \
+ "libsodium-dev", \
+ "libvpx-dev", \
+ "linux-headers", \
+ "opus-dev", \
+ "pkgconfig", \
+ "samurai"]
+
+ENV CC=clang CXX=clang++
+
+COPY . /c-toxcore/
+WORKDIR /c-toxcore
+RUN other/analysis/run-clang-tidy

external/toxcore/c-toxcore/other/docker/clang-tidy/run

@@ -0,0 +1,5 @@
+#!/bin/sh
+
+set -eux
+BUILD=clang-tidy
+docker build -t "toxchat/c-toxcore:$BUILD" -f "other/docker/$BUILD/Dockerfile" .

external/toxcore/c-toxcore/other/docker/coverage/Dockerfile

@@ -19,11 +19,14 @@ RUN apt-get update && \
  make \
  ninja-build \
  pkg-config \
+ python3-lxml \
  python3-pip \
  python3-pygments \
  && apt-get clean \
  && rm -rf /var/lib/apt/lists/* \
  && pip3 install --no-cache-dir gcovr
+# strip gtest so it doesn't end up in stack traces. This speeds up the
+# mallocfail run below by a lot.
 RUN ["strip", "-g",\
  "/usr/lib/x86_64-linux-gnu/libgtest.a",\
  "/usr/lib/x86_64-linux-gnu/libgtest_main.a"]

external/toxcore/c-toxcore/other/docker/cppcheck/toxcore.cfg

@@ -92,6 +92,10 @@
     <alloc init="true">new_networking_no_udp</alloc>
     <dealloc arg="1">kill_networking</dealloc>
   </resource>
+  <resource>
+    <alloc init="true">net_new_strerror</alloc>
+    <dealloc arg="1">net_kill_strerror</dealloc>
+  </resource>
   <resource>
     <alloc init="true">new_onion</alloc>
     <dealloc arg="1">kill_onion</dealloc>

external/toxcore/c-toxcore/other/docker/misra/Dockerfile

@@ -1,6 +1,7 @@
 FROM ubuntu:20.04
 
-RUN apt-get update && apt-get install --no-install-recommends -y \
+RUN apt-get update && \
+ DEBIAN_FRONTEND="noninteractive" apt-get install -y --no-install-recommends \
  ca-certificates \
  cppcheck \
  libopus-dev \

external/toxcore/c-toxcore/other/docker/tokstyle/Dockerfile

@@ -1,7 +1,8 @@
 FROM toxchat/haskell:hs-tokstyle AS tokstyle
 FROM ubuntu:22.04
 
-RUN apt-get update && apt-get install --no-install-recommends -y \
+RUN apt-get update && \
+ DEBIAN_FRONTEND="noninteractive" apt-get install -y --no-install-recommends \
  ca-certificates \
  clang \
  git \