Squashed 'external/toxcore/c-toxcore/' changes from c9cdae001..9ed2fa80d

9ed2fa80d fix(toxav): remove extra copy of video frame on encode
de30cf3ad docs: Add new file kinds, that should be useful to all clients.
d5b5e879d fix(DHT): Correct node skipping logic timed out nodes.
30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch.
8fdbb0b50 style: Format parameter lists in event handlers.
d00dee12b refactor: Add warning logs when losing chat invites.
b144e8db1 feat: Add a way to look up a file number by ID.
849281ea0 feat: Add a way to fetch groups by chat ID.
a2c177396 refactor: Harden event system and improve type safety.
8f5caa656 refactor: Add MessagePack string support to bin_pack.
34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner.
f7b068010 refactor: Add nullability annotations to event headers.
788abe651 refactor(toxav): Use system allocator for mutexes.
2e4b423eb refactor: Use specific typedefs for public API arrays.
2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354
2f87ac67b feat: Add Event Loop abstraction (Ev).
f8dfc38d8 test: Fix data race in ToxScenario virtual_clock.
38313921e test(TCP): Add regression test for TCP priority queue integrity.
f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex.
ad054511e refactor: Internalize DHT structs and add debug helpers.
8b467cc96 fix: Prevent potential integer overflow in group chat handshake.
4962bdbb8 test: Improve TCP simulation and add tests
5f0227093 refactor: Allow nullable data in group chat handlers.
e97b18ea9 chore: Improve Windows Docker support.
b14943bbd refactor: Move Logger out of Messenger into Tox.
dd3136250 cleanup: Apply nullability qualifiers to C++ codebase.
1849f70fc refactor: Extract low-level networking code to net and os_network.
8fec75421 refactor: Delete tox_random, align on rng and os_random.
a03ae8051 refactor: Delete tox_memory, align on mem and os_memory.
4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code.
72452f2ae test: Add some more tests for onion and shared key cache.
d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it.
b6f5b9fc5 test: Add some benchmarks for various high level things.
8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier
d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around
REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode

git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8

testing/Messenger_test.c

@@ -102,14 +102,27 @@ int main(int argc, char *argv[])
         exit(0);
     }
 
-    Messenger_Options options = {0};
+    Messenger_Options options = {nullptr};
     options.ipv6enabled = ipv6enabled;
+
+    Logger *logger = logger_new(mem);
+
+    if (logger == nullptr) {
+        fputs("Failed to allocate logger datastructure\n", stderr);
+        mono_time_free(mem, mono_time);
+        exit(1);
+    }
+
+    options.log = logger;
+
     Messenger_Error err;
     m = new_messenger(mono_time, mem, os_random(), os_network(), &options, &err);
 
     if (!m) {
         fprintf(stderr, "Failed to allocate messenger datastructure: %u\n", err);
-        exit(0);
+        logger_kill(logger);
+        mono_time_free(mem, mono_time);
+        exit(1);
     }
 
     if (argc == argvoffset + 4) {
@@ -117,6 +130,9 @@ int main(int argc, char *argv[])
 
         if (port_conv <= 0 || port_conv > UINT16_MAX) {
             printf("Failed to convert \"%s\" into a valid port. Exiting...\n", argv[argvoffset + 2]);
+            kill_messenger(m);
+            logger_kill(logger);
+            mono_time_free(mem, mono_time);
             exit(1);
         }
 
@@ -131,6 +147,9 @@ int main(int argc, char *argv[])
 
         if (!res) {
             printf("Failed to convert \"%s\" into an IP address. Exiting...\n", argv[argvoffset + 1]);
+            kill_messenger(m);
+            logger_kill(logger);
+            mono_time_free(mem, mono_time);
             exit(1);
         }
     }
@@ -157,6 +176,9 @@ int main(int argc, char *argv[])
     printf("\nEnter the address of the friend you wish to add (38 bytes HEX format):\n");
 
     if (!fgets(temp_hex_id, sizeof(temp_hex_id), stdin)) {
+        kill_messenger(m);
+        logger_kill(logger);
+        mono_time_free(mem, mono_time);
         exit(0);
     }
 
@@ -186,6 +208,8 @@ int main(int argc, char *argv[])
         if (file == nullptr) {
             printf("Failed to open file %s\n", filename);
             kill_messenger(m);
+            logger_kill(logger);
+            mono_time_free(mem, mono_time);
             return 1;
         }
 
@@ -195,6 +219,8 @@ int main(int argc, char *argv[])
             fputs("Failed to allocate memory\n", stderr);
             fclose(file);
             kill_messenger(m);
+            logger_kill(logger);
+            mono_time_free(mem, mono_time);
             return 1;
         }
 
@@ -205,6 +231,8 @@ int main(int argc, char *argv[])
             free(buffer);
             fclose(file);
             kill_messenger(m);
+            logger_kill(logger);
+            mono_time_free(mem, mono_time);
             return 1;
         }