Squashed 'external/toxcore/c-toxcore/' changes from c9cdae001..9ed2fa80d

9ed2fa80d fix(toxav): remove extra copy of video frame on encode
de30cf3ad docs: Add new file kinds, that should be useful to all clients.
d5b5e879d fix(DHT): Correct node skipping logic timed out nodes.
30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch.
8fdbb0b50 style: Format parameter lists in event handlers.
d00dee12b refactor: Add warning logs when losing chat invites.
b144e8db1 feat: Add a way to look up a file number by ID.
849281ea0 feat: Add a way to fetch groups by chat ID.
a2c177396 refactor: Harden event system and improve type safety.
8f5caa656 refactor: Add MessagePack string support to bin_pack.
34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner.
f7b068010 refactor: Add nullability annotations to event headers.
788abe651 refactor(toxav): Use system allocator for mutexes.
2e4b423eb refactor: Use specific typedefs for public API arrays.
2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354
2f87ac67b feat: Add Event Loop abstraction (Ev).
f8dfc38d8 test: Fix data race in ToxScenario virtual_clock.
38313921e test(TCP): Add regression test for TCP priority queue integrity.
f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex.
ad054511e refactor: Internalize DHT structs and add debug helpers.
8b467cc96 fix: Prevent potential integer overflow in group chat handshake.
4962bdbb8 test: Improve TCP simulation and add tests
5f0227093 refactor: Allow nullable data in group chat handlers.
e97b18ea9 chore: Improve Windows Docker support.
b14943bbd refactor: Move Logger out of Messenger into Tox.
dd3136250 cleanup: Apply nullability qualifiers to C++ codebase.
1849f70fc refactor: Extract low-level networking code to net and os_network.
8fec75421 refactor: Delete tox_random, align on rng and os_random.
a03ae8051 refactor: Delete tox_memory, align on mem and os_memory.
4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code.
72452f2ae test: Add some more tests for onion and shared key cache.
d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it.
b6f5b9fc5 test: Add some benchmarks for various high level things.
8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier
d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around
REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode

git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8

toxav/rtp_fuzz_test.cc

@@ -1,10 +1,13 @@
 #include "rtp.h"
 
+#include <cstddef>
+#include <cstdint>
 #include <cstdlib>
 #include <memory>
 #include <vector>
 
 #include "../testing/support/public/fuzz_data.hh"
+#include "../toxcore/attributes.h"
 #include "../toxcore/logger.h"
 #include "../toxcore/mono_time.h"
 #include "../toxcore/os_memory.h"
@@ -15,12 +18,14 @@ using tox::test::Fuzz_Data;
 
 struct MockSessionData { };
 
-static int mock_send_packet(void * /*user_data*/, const uint8_t * /*data*/, uint16_t /*length*/)
+static int mock_send_packet(
+    void *_Nullable /*user_data*/, const std::uint8_t *_Nonnull /*data*/, std::uint16_t /*length*/)
 {
     return 0;
 }
 
-static int mock_m_cb(const Mono_Time * /*mono_time*/, void * /*cs*/, RTPMessage *msg)
+static int mock_m_cb(
+    const Mono_Time *_Nonnull /*mono_time*/, void *_Nullable /*cs*/, RTPMessage *_Nonnull msg)
 {
     std::free(msg);
     return 0;
@@ -28,28 +33,28 @@ static int mock_m_cb(const Mono_Time * /*mono_time*/, void * /*cs*/, RTPMessage
 
 void fuzz_rtp_receive(Fuzz_Data &input)
 {
-    const Memory *mem = os_memory();
+    const Memory *_Nonnull mem = os_memory();
     struct LoggerDeleter {
-        void operator()(Logger *l) { logger_kill(l); }
+        void operator()(Logger *_Nullable l) { logger_kill(l); }
     };
     std::unique_ptr<Logger, LoggerDeleter> log(logger_new(mem));
 
-    auto time_cb = [](void *) -> uint64_t { return 0; };
+    auto time_cb = [](void *_Nullable) -> std::uint64_t { return 0; };
     struct MonoTimeDeleter {
-        const Memory *m;
-        void operator()(Mono_Time *t) { mono_time_free(m, t); }
+        const Memory *_Nonnull m;
+        void operator()(Mono_Time *_Nullable t) { mono_time_free(m, t); }
     };
     std::unique_ptr<Mono_Time, MonoTimeDeleter> mono_time(
         mono_time_new(mem, time_cb, nullptr), MonoTimeDeleter{mem});
 
     MockSessionData sd;
 
-    CONSUME1_OR_RETURN(uint8_t, payload_type_byte, input);
+    CONSUME1_OR_RETURN(std::uint8_t, payload_type_byte, input);
     int payload_type = (payload_type_byte % 2 == 0) ? RTP_TYPE_AUDIO : RTP_TYPE_VIDEO;
 
     struct RtpSessionDeleter {
-        Logger *l;
-        void operator()(RTPSession *s) { rtp_kill(l, s); }
+        Logger *_Nonnull l;
+        void operator()(RTPSession *_Nullable s) { rtp_kill(l, s); }
     };
     std::unique_ptr<RTPSession, RtpSessionDeleter> session(
         rtp_new(log.get(), payload_type, mono_time.get(), mock_send_packet, &sd, nullptr, nullptr,
@@ -57,7 +62,7 @@ void fuzz_rtp_receive(Fuzz_Data &input)
         RtpSessionDeleter{log.get()});
 
     while (!input.empty()) {
-        CONSUME1_OR_RETURN(uint16_t, len, input);
+        CONSUME1_OR_RETURN(std::uint16_t, len, input);
 
         if (input.size() < len) {
             len = input.size();
@@ -67,16 +72,16 @@ void fuzz_rtp_receive(Fuzz_Data &input)
             break;
         }
 
-        const uint8_t *pkt_data = input.consume(__func__, len);
+        const std::uint8_t *pkt_data = input.consume(__func__, len);
         rtp_receive_packet(session.get(), pkt_data, len);
     }
 }
 
 }  // namespace
 
-extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size);
+extern "C" int LLVMFuzzerTestOneInput(const std::uint8_t *data, std::size_t size);
 
-extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
+extern "C" int LLVMFuzzerTestOneInput(const std::uint8_t *data, std::size_t size)
 {
     Fuzz_Data input(data, size);
     fuzz_rtp_receive(input);