Squashed 'external/toxcore/c-toxcore/' changes from c9cdae001..9ed2fa80d

9ed2fa80d fix(toxav): remove extra copy of video frame on encode
de30cf3ad docs: Add new file kinds, that should be useful to all clients.
d5b5e879d fix(DHT): Correct node skipping logic timed out nodes.
30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch.
8fdbb0b50 style: Format parameter lists in event handlers.
d00dee12b refactor: Add warning logs when losing chat invites.
b144e8db1 feat: Add a way to look up a file number by ID.
849281ea0 feat: Add a way to fetch groups by chat ID.
a2c177396 refactor: Harden event system and improve type safety.
8f5caa656 refactor: Add MessagePack string support to bin_pack.
34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner.
f7b068010 refactor: Add nullability annotations to event headers.
788abe651 refactor(toxav): Use system allocator for mutexes.
2e4b423eb refactor: Use specific typedefs for public API arrays.
2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354
2f87ac67b feat: Add Event Loop abstraction (Ev).
f8dfc38d8 test: Fix data race in ToxScenario virtual_clock.
38313921e test(TCP): Add regression test for TCP priority queue integrity.
f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex.
ad054511e refactor: Internalize DHT structs and add debug helpers.
8b467cc96 fix: Prevent potential integer overflow in group chat handshake.
4962bdbb8 test: Improve TCP simulation and add tests
5f0227093 refactor: Allow nullable data in group chat handlers.
e97b18ea9 chore: Improve Windows Docker support.
b14943bbd refactor: Move Logger out of Messenger into Tox.
dd3136250 cleanup: Apply nullability qualifiers to C++ codebase.
1849f70fc refactor: Extract low-level networking code to net and os_network.
8fec75421 refactor: Delete tox_random, align on rng and os_random.
a03ae8051 refactor: Delete tox_memory, align on mem and os_memory.
4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code.
72452f2ae test: Add some more tests for onion and shared key cache.
d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it.
b6f5b9fc5 test: Add some benchmarks for various high level things.
8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier
d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around
REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode

git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8

toxcore/mono_time_test.cc

@@ -5,6 +5,7 @@
 
 #include <gtest/gtest.h>
 
+#include "attributes.h"
 #include "mono_time_test_util.hh"
 
 namespace {
@@ -15,19 +16,19 @@ using tox::test::SimulatedEnvironment;
 TEST(MonoTime, TimeIncreasesWhenAdvanced)
 {
     SimulatedEnvironment env;
-    auto c_mem = env.fake_memory().get_c_memory();
+    auto c_mem = env.fake_memory().c_memory();
     Mono_Time *mono_time = mono_time_new(&c_mem, nullptr, nullptr);
     ASSERT_NE(mono_time, nullptr);
     setup_fake_clock(mono_time, env.fake_clock());
 
     mono_time_update(mono_time);
-    uint64_t const start = mono_time_get(mono_time);
+    std::uint64_t const start = mono_time_get(mono_time);
 
     // Advance 10 seconds to ensure we definitely cross second boundaries and see an increase
     env.fake_clock().advance(10000);
     mono_time_update(mono_time);
 
-    uint64_t const end = mono_time_get(mono_time);
+    std::uint64_t const end = mono_time_get(mono_time);
     EXPECT_GT(end, start);
     EXPECT_EQ(end, start + 10);
 
@@ -37,13 +38,13 @@ TEST(MonoTime, TimeIncreasesWhenAdvanced)
 TEST(MonoTime, IsTimeout)
 {
     SimulatedEnvironment env;
-    auto c_mem = env.fake_memory().get_c_memory();
+    auto c_mem = env.fake_memory().c_memory();
     Mono_Time *mono_time = mono_time_new(&c_mem, nullptr, nullptr);
     ASSERT_NE(mono_time, nullptr);
     setup_fake_clock(mono_time, env.fake_clock());
 
     mono_time_update(mono_time);  // Ensure start is consistent with fake clock
-    uint64_t const start = mono_time_get(mono_time);
+    std::uint64_t const start = mono_time_get(mono_time);
     EXPECT_FALSE(mono_time_is_timeout(mono_time, start, 1));
 
     env.fake_clock().advance(2000);  // 2 seconds
@@ -57,13 +58,13 @@ TEST(MonoTime, IsTimeout)
 TEST(MonoTime, IsTimeoutWithIntermediateUpdates)
 {
     SimulatedEnvironment env;
-    auto c_mem = env.fake_memory().get_c_memory();
+    auto c_mem = env.fake_memory().c_memory();
     Mono_Time *mono_time = mono_time_new(&c_mem, nullptr, nullptr);
     ASSERT_NE(mono_time, nullptr);
     setup_fake_clock(mono_time, env.fake_clock());
 
     mono_time_update(mono_time);
-    uint64_t const start = mono_time_get(mono_time);
+    std::uint64_t const start = mono_time_get(mono_time);
     EXPECT_FALSE(mono_time_is_timeout(mono_time, start, 5));
 
     env.fake_clock().advance(100);
@@ -82,18 +83,20 @@ TEST(MonoTime, IsTimeoutWithIntermediateUpdates)
 TEST(MonoTime, CustomTime)
 {
     SimulatedEnvironment env;
-    auto c_mem = env.fake_memory().get_c_memory();
+    auto c_mem = env.fake_memory().c_memory();
     Mono_Time *mono_time = mono_time_new(&c_mem, nullptr, nullptr);
     ASSERT_NE(mono_time, nullptr);
 
-    uint64_t test_time = 123456;
+    std::uint64_t test_time = 123456;
     mono_time_set_current_time_callback(
-        mono_time, [](void *user_data) { return *static_cast<uint64_t *>(user_data); }, &test_time);
+        mono_time,
+        [](void *_Nullable user_data) { return *static_cast<std::uint64_t *>(user_data); },
+        &test_time);
     mono_time_update(mono_time);
 
     EXPECT_EQ(current_time_monotonic(mono_time), test_time);
 
-    uint64_t const start = mono_time_get(mono_time);
+    std::uint64_t const start = mono_time_get(mono_time);
 
     test_time += 7000;
     mono_time_update(mono_time);