Squashed 'external/toxcore/c-toxcore/' changes from c9cdae001..9ed2fa80d

9ed2fa80d fix(toxav): remove extra copy of video frame on encode
de30cf3ad docs: Add new file kinds, that should be useful to all clients.
d5b5e879d fix(DHT): Correct node skipping logic timed out nodes.
30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch.
8fdbb0b50 style: Format parameter lists in event handlers.
d00dee12b refactor: Add warning logs when losing chat invites.
b144e8db1 feat: Add a way to look up a file number by ID.
849281ea0 feat: Add a way to fetch groups by chat ID.
a2c177396 refactor: Harden event system and improve type safety.
8f5caa656 refactor: Add MessagePack string support to bin_pack.
34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner.
f7b068010 refactor: Add nullability annotations to event headers.
788abe651 refactor(toxav): Use system allocator for mutexes.
2e4b423eb refactor: Use specific typedefs for public API arrays.
2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354
2f87ac67b feat: Add Event Loop abstraction (Ev).
f8dfc38d8 test: Fix data race in ToxScenario virtual_clock.
38313921e test(TCP): Add regression test for TCP priority queue integrity.
f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex.
ad054511e refactor: Internalize DHT structs and add debug helpers.
8b467cc96 fix: Prevent potential integer overflow in group chat handshake.
4962bdbb8 test: Improve TCP simulation and add tests
5f0227093 refactor: Allow nullable data in group chat handlers.
e97b18ea9 chore: Improve Windows Docker support.
b14943bbd refactor: Move Logger out of Messenger into Tox.
dd3136250 cleanup: Apply nullability qualifiers to C++ codebase.
1849f70fc refactor: Extract low-level networking code to net and os_network.
8fec75421 refactor: Delete tox_random, align on rng and os_random.
a03ae8051 refactor: Delete tox_memory, align on mem and os_memory.
4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code.
72452f2ae test: Add some more tests for onion and shared key cache.
d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it.
b6f5b9fc5 test: Add some benchmarks for various high level things.
8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier
d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around
REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode

git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8

toxcore/sort_test.cc

@@ -24,7 +24,7 @@ TEST(MergeSort, BehavesLikeStdSort)
     constexpr auto int_funcs = sort_funcs<int>();
 
     // Test with int arrays.
-    for (uint32_t i = 1; i < 500; ++i) {
+    for (std::uint32_t i = 1; i < 500; ++i) {
         std::vector<int> vec(i);
         std::generate(std::begin(vec), std::end(vec), [&]() { return dist(rng); });
 
@@ -34,7 +34,7 @@ TEST(MergeSort, BehavesLikeStdSort)
         // If vec was accidentally sorted, add another larger element that almost definitely makes
         // it not sorted.
         if (vec == sorted) {
-            int const largest = *std::prev(sorted.end()) + 1;
+            int const largest = sorted.empty() ? 0 : sorted.back() + 1;
             sorted.push_back(largest);
             vec.insert(vec.begin(), largest);
         }
@@ -55,7 +55,7 @@ TEST(MergeSort, WorksWithNonTrivialTypes)
     constexpr auto string_funcs = sort_funcs<std::string>();
 
     // Test with std::string arrays.
-    for (uint32_t i = 1; i < 500; ++i) {
+    for (std::uint32_t i = 1; i < 500; ++i) {
         std::vector<std::string> vec(i);
         std::generate(std::begin(vec), std::end(vec), [&]() { return std::to_string(dist(rng)); });
 
@@ -67,7 +67,11 @@ TEST(MergeSort, WorksWithNonTrivialTypes)
         if (vec == sorted) {
             std::string const largest = "larger than largest int";
             sorted.push_back(largest);
-            vec.insert(vec.begin(), largest);
+            vec.push_back(largest);
+            // Swap the last two elements. Since i >= 1, vec has at least 2 elements now.
+            // This guarantees the vector is not sorted because 'largest' is now before the last
+            // element (which is smaller than 'largest').
+            std::iter_swap(vec.end() - 2, vec.end() - 1);
         }
         ASSERT_NE(vec, sorted);