From ab12fbe8206ffa960ae43638886fe9e83f170b53 Mon Sep 17 00:00:00 2001 From: Green Sky Date: Fri, 16 May 2025 12:03:45 +0200 Subject: [PATCH] Squashed 'external/toxcore/c-toxcore/' changes from 465fbc8721..1701691d53 1701691d53 chore(toxav): use realtime deadline for vp8 encoder Technically all this does is choose a quality based on frame duration, which we always set to 1, and as such is always realtime. (In same timebase as pts, which we use as a frame counter...) a875058675 fix(toxav): remove extra copy of video frame on encode Tested and works, but there might be alignment issues and other stuff. 6794447518 chore(toxav): increase the idle iterate interval to 1 second and remove a non-existant reference in a comment 3e22fd5cc4 fix(toxav): handle vpx_image_alloc failure 4057695c5f chore(toxav): tighten the video bitrate to the same as the vp8 encoder internally checks. 3e6b22f5de chore: Release v0.2.21 219773bff5 fix(ngc): dont double every message, if we are not directly connected but we and the other peer would support direct. REVERT: 465fbc8721 Merge branch 'toxav_deadline' of github.com:Green-Sky/c-toxcore into tomato_testing_in_prod REVERT: 6f16b5f4e5 chore(toxav): use realtime deadline for vp8 encoder Technically all this does is choose a quality based on frame duration, which we always set to 1, and as such is always realtime. (In same timebase as pts, which we use as a frame counter...) REVERT: 0b49ba2d94 Merge branch 'toxav_video_bitrate' of github.com:Green-Sky/c-toxcore into tomato_testing_in_prod REVERT: 9c0977d7c6 Merge branch 'toxav_remove_img_copy_encode' of github.com:Green-Sky/c-toxcore into tomato_testing_in_prod REVERT: 4071d74cc9 fix(ngc): dont double every message, if we are not directly connected but we and the other peer would support direct. REVERT: fa015c7e2e fix(toxav): remove extra copy of video frame on encode Tested and works, but there might be alignment issues and other stuff. REVERT: d34f7d1f5c fix(toxav): handle vpx_image_alloc failure REVERT: dd12b9889a chore(toxav): tighten the video bitrate to the same as the vp8 encoder internally checks. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: 1701691d5358599bf17c73226319f0edc18cbacd --- CHANGELOG.md | 26 +++++++++++++++++++ .../docker/tox-bootstrapd.sha256 | 2 +- toxav/toxav.c | 2 +- toxav/video.c | 2 +- 4 files changed, 29 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dd1f073..fd7d686 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,29 @@ + + +## v0.2.21 (2025-05-15) + +### Release notes + +This release brings 2 great featues. First, the abillty to disable DNS lookups, which has been a long requested security feature, which we plan to default to in an upcoming version. +Second, there is an network profiler, which tallies up sent and received network packets. + +Beside these features we also have fixes like a 75% memory usage reduction for NGCs and connecting to NGC with a password if we are already joined, which might be necessary if a password was set or changed while you where away. +Furthermore, we now have better localhost discovery, which means that nodes on the same system find each other. + +--- + +If you have not yet upgraded to the previous release (0.2.20), you absolutely should, as it fixes a security issue. All releases before 0.2.20 used VBR opus encoding, which is susceptible to transcription attacks. ( see https://github.com/TokTok/c-toxcore/pull/2757 ) + +#### Bug Fixes + +- forgot an enum in the nodes request rename see https://github.com/TokTok/c-toxcore/pull/2860 ([9324a974](https://github.com/TokTok/c-toxcore/commit/9324a974d473641a90a750e5117108b3c672010e)) +- **bazel:** + - one more fuzz target that needs netprof ([1d4cc783](https://github.com/TokTok/c-toxcore/commit/1d4cc783b142cbfc77a639a4034fa7a79555e5c2)) + - make `net_prof` visible to its consumers ([066aafbf](https://github.com/TokTok/c-toxcore/commit/066aafbfcdf5cbe4176e6a7e0ba58033a6576378)) + - missing dep for `auto_tests` ([9dcc2f53](https://github.com/TokTok/c-toxcore/commit/9dcc2f530d67696a162275c07ceb4ddf2199fa72)) + - missing dep for fuzz target ([741ac5f5](https://github.com/TokTok/c-toxcore/commit/741ac5f5e65e54c0b2e2542e95d28ea529fcc200)) +- **ngc:** dont double every message, if we are not directly connected but we and the other peer would support direct. ([219773bf](https://github.com/TokTok/c-toxcore/commit/219773bff599c3f23ccc20080c8cfa1b29a1117b)) + ## v0.2.21-rc.1 (2025-02-24) diff --git a/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 b/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 index 74d18c4..7a6a3eb 100644 --- a/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 +++ b/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 @@ -1 +1 @@ -abd103553021d86f54c874fe582001f28372b4e56502421955552117ac5f7b3b /usr/local/bin/tox-bootstrapd +1d87f94fd38a9737cf1f4fbc51fcd83254e4f9b663fba67c5680ed35c32fad0e /usr/local/bin/tox-bootstrapd diff --git a/toxav/toxav.c b/toxav/toxav.c index c329f66..50eb47f 100644 --- a/toxav/toxav.c +++ b/toxav/toxav.c @@ -27,7 +27,7 @@ #define VIDEO_SEND_X_KEYFRAMES_FIRST 7 // force the first n frames to be keyframes! // iteration interval that is used when no call is active -#define IDLE_ITERATION_INTERVAL_MS 200 +#define IDLE_ITERATION_INTERVAL_MS 1000 #ifndef TOXAV_CALL_DEFINED #define TOXAV_CALL_DEFINED diff --git a/toxav/video.c b/toxav/video.c index 9434feb..7d0c12e 100644 --- a/toxav/video.c +++ b/toxav/video.c @@ -329,7 +329,7 @@ int vc_queue_message(const Mono_Time *mono_time, void *cs, struct RTPMessage *ms /* This function is called with complete messages * they have already been assembled. - * this function gets called from handle_rtp_packet() and handle_rtp_packet_v3() + * this function gets called from handle_rtp_packet() */ if (vc == nullptr || msg == nullptr) { free(msg);