Squashed 'external/toxcore/c-toxcore/' changes from da438763d5b..671b1f92332

671b1f92332 fix: toxav rtp temp buffer allocation size was too large and cast from 32bit to 16bit, causing a overflow and making the allocated size too small
258148bd4e1 chore(ci): new minimum for all android versions is 21
d369c93c489 chore: Fix Emscripten build failing with no host specified
51b24d1c239 chore: Run CompCert on the stable branch of libsodium
cab1f7d522b chore: Update WineHQ's apt key hash
102a1fa9b82 chore: Fix -Werror=maybe-uninitialized in a test
cc9515da9c7 chore: Fix cpplint failing to install
3485b5feef3 chore: Disable -Wswitch-default and -Wunsafe-buffer-usage
719041e04b6 chore: Fix Circle CI failing on a missing clang lib
5344d7f84d0 fix: Memory leak in the bootstrap daemon
fa201681e18 cleanup: Remove useless if clause
7572888a218 chore: Fix GitHub actions deprecation warnings

git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: 671b1f92332a8314dccf76d5df93c0b6c1230636

other/analysis/run-clang

@@ -28,8 +28,10 @@ run() {
     -Wno-old-style-cast \
     -Wno-padded \
     -Wno-sign-compare \
+    -Wno-switch-default \
     -Wno-tautological-pointer-compare \
     -Wno-unreachable-code-return \
+    -Wno-unsafe-buffer-usage \
     -Wno-unused-parameter \
     -Wno-used-but-marked-unused \
     -Wno-source-uses-openmp

other/bootstrap_daemon/src/config.c

@@ -200,6 +200,8 @@ bool get_general_config(const char *cfg_file_path, char **pid_file_path, char **
     *keys_file_path = (char *)malloc(keys_file_path_len);
     if (*keys_file_path == nullptr) {
         log_write(LOG_LEVEL_ERROR, "Allocation failure.\n");
+        free(*pid_file_path);
+        *pid_file_path = nullptr;
         return false;
     }
     memcpy(*keys_file_path, tmp_keys_file, keys_file_path_len);

other/docker/compcert/compcert.Dockerfile

@@ -13,7 +13,7 @@ COPY --from=sources /src/ /work/
 
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 
-RUN git clone --depth=1 https://github.com/jedisct1/libsodium /work/libsodium
+RUN git clone --depth=1 --branch=stable https://github.com/jedisct1/libsodium /work/libsodium
 COPY other/docker/compcert/Makefile /work/
 RUN make "-j$(nproc)"
 RUN ./send_message_test | grep 'tox clients connected'

other/docker/windows/get_packages.sh

@@ -52,7 +52,7 @@ if [ "$SUPPORT_TEST" = "true" ]; then
     https://dl.winehq.org/wine-builds/debian/dists/bookworm/winehq-bookworm.sources
 
   . ./check_sha256.sh
-  check_sha256 "78b185fabdb323971d13bd329fefc8038e08559aa51c4996de18db0639a51df6" \
+  check_sha256 "d965d646defe94b3dfba6d5b4406900ac6c81065428bf9d9303ad7a72ee8d1b8" \
     "/etc/apt/keyrings/winehq-archive.key"
   check_sha256 "8dd8ef66c749d56e798646674c1c185a99b3ed6727ca0fbb5e493951e66c0f9e" \
     "/etc/apt/sources.list.d/winehq-bookworm.sources"

other/emscripten/Dockerfile

@@ -34,6 +34,7 @@ RUN . "/work/emsdk/emsdk_env.sh" \
  && emconfigure ./configure --disable-shared \
   --without-pthreads \
   --disable-ssp --disable-asm --disable-pie \
+  --host x86_64-linux-gnu \
  && emmake make install -j8
 
 # Build an unused libsodium binding first so emcc caches all the system