Green Sky
aae086cc65
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to. 32e67ab4c2 cleanup: use typedef for private message ID's in callback 7b1db6adc1 feat: add message IDs to private group messages 99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests e742deddff feat: Check hashes of Windows dependencies when cross-compiling dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image 14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes ed37616249 docs: Update the Windows cross-compilation section 9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies 19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows 1be311e51f feat: Build the fun utils when cross-compiling to Windows 88133f8446 chore: Strip Windows binaries 3cc0ae7535 refactor: Copy over all of the required static dependencies c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows 74bbac5363 feat: Let CMake create the dll instead of doing so ourselves 246642e9ae feat: Harden Windows cross-compilation 8d431c0d11 chore: Bump Windows build dependency versions e519f7998b fix: Remove unnecessary wsock32 dependency on Windows ed2b60c217 chore: Use a specific non-broken slimcc version. d7f21010a1 chore: Update github actions. e71a68b7f2 docs: Update the list of CMake options 77e08876ff chore: Remove mod and founder from group API naming scheme 12bc042767 docs: add the experimental api build option to INSTALL.md e1fa5cae96 refactor: Rename Queries to Query to align with other enums. be82a3ea30 fix: Correct type for conference offline peer numbers. 0627c36716 test: Add pkgsrc build. 92578afe4b test: Add FreeBSD VM action on GitHub. 52ece0f57b test: Build toxcore on NetBSD (VM). 3fe8ee2c11 chore: Only install tox_private.h on request. 9a8dfa06ab fix: save_compatibility_test failing on big-endian systems 86f5e55578 fix: Don't serve files from websockify. 710eb674a5 fix: Correctly pass extended public keys to group moderation code. 021db7031c refactor: Use `struct`s for extended public/secret keys. a1e999fd80 chore: Compile libsodium reference implementation with compcert. fbe3c19cf5 cleanup: correct a few nullable annotations 623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. c71567dc18 fix: Pass array, not array pointer, to `memcmp`. 9b46a08144 cleanup: Never pass `void*` directly to `memcpy`. 5d7b7a7bbc refactor: Use tox rng to seed the keypair generation. 961891d568 cleanup: Small improvements found by PVS Studio. 8201019f0d chore: Disable NGC saving by default, enable through Tox_Options. 5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`. ca4606d49d refactor: Use strong typedef for NGC peer id. 442213b722 cleanup: Simplify custom packet length check in NGC. 08d3393def fix: Correct a few potential null derefs in bootstrap daemon. b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope. dab5fe44b9 fix: Zero out stack-allocated secret key before return. f058103299 refactor: Make prune_gc_sanctions_list more obviously correct. 3ba7a0dec9 docs: Add static analysis tool list to README. 8d0811a0f3 docs: Run prettier-markdown on markdown files. 969e3a2bfc refactor: Fix network test not using the strong typedef 93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`. 9fe18b176f fix: Fix some false positive from PVS Studio. 7c44379ccb cleanup: Check that WINXP macro exists before comparing it. 5c93231bef refactor: Make tox mutex non-recursive. aacff73939 docs: Fix up doxyfile. d55fc85ff5 docs: Add more documentation to crypto_core. 5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`. e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests. 34df938f52 chore: Use C++ mode for clang-tidy. 8b05296a78 chore: Check that both gtest and gmock exist for tests. 42010660e1 test: Add slimcc compiler compatibility test. b473630321 chore: Add some comments to the astyle config. b7404f24f6 cleanup: Remove implicit bool conversions. 4e2dba4d9f chore: Reformat sources with astyle. 4359e3a6bc chore: Rename C++ headers to .hh suffixes. 0c05566e58 cleanup: Further `#include` cleanups. 8d29935b7a chore: Only check the bootstrap daemon checksum on release. f70e588bc6 cleanup: Add more `const` where possible. 511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene. 1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module. a975943564 chore: Really fix coverage docker image build. c08409390f chore: Fix post-submit coverage image. 39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s. d94246a906 fix: partially fix a bug that prevented group part messages from sending. eeaa039222 chore: Fix rpm build; add a CI check for it. 8328449c1a chore: Speed up docker builds a bit by reducing layer count. d6d67d56f3 cleanup: Add `const` where possible in auto tests. 6aa9e6850d cleanup: Minor cleanup of event unpack code. bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`. 203e1af81e fix: a few off by one errors in group autotests 5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`. 662c2140f3 test: Add goblint static analyser. 8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`. a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`. 6370d0f15d cleanup: Expand the `Tox_Options` accessor macros. 14a1a0b9bd cleanup: Remove plan9 support. a05dccad13 test: Add a simple new/delete test for Tox. 1cdcf938b9 cleanup: Add comment after every `#endif`. ba99d4dc4b test: Fix comment I broke in the events test PR. e07248debb refactor: Migrate auto_tests to new events API. bdd42b5452 refactor: Add common msgpack array packer with callback. 3c659f5288 cleanup: Rename group to conference in groupav documentation. 89957be230 cleanup: Ensure handler params are named after callback params. c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks. e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events. 5e2c8cabc1 cleanup: make some improvements to group moderation test 259de4867e cleanup: Remove `bin_pack_{new,free}`. 21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion 16809dc36e feat: Add dht_get_nodes_response event to the events system. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
210 lines
8.2 KiB
C++
210 lines
8.2 KiB
C++
#include "tox.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <array>
|
|
#include <vector>
|
|
|
|
#include "crypto_core.h"
|
|
#include "tox_private.h"
|
|
|
|
namespace {
|
|
|
|
static void set_random_name_and_status_message(
|
|
Tox *tox, const Random *rng, uint8_t *name, uint8_t *status_message)
|
|
{
|
|
for (uint16_t i = 0; i < tox_max_name_length(); ++i) {
|
|
name[i] = random_u08(rng);
|
|
}
|
|
|
|
for (uint16_t i = 0; i < tox_max_status_message_length(); ++i) {
|
|
status_message[i] = random_u08(rng);
|
|
}
|
|
}
|
|
|
|
TEST(Tox, CurrentVersionIsCompatibleWithItself)
|
|
{
|
|
EXPECT_TRUE(
|
|
TOX_VERSION_IS_API_COMPATIBLE(TOX_VERSION_MAJOR, TOX_VERSION_MINOR, TOX_VERSION_PATCH));
|
|
EXPECT_TRUE(TOX_VERSION_IS_ABI_COMPATIBLE());
|
|
EXPECT_TRUE(
|
|
tox_version_is_compatible(tox_version_major(), tox_version_minor(), tox_version_patch()));
|
|
}
|
|
|
|
TEST(Tox, ConstantsAreNonZero)
|
|
{
|
|
EXPECT_GT(tox_public_key_size(), 0);
|
|
EXPECT_GT(tox_secret_key_size(), 0);
|
|
EXPECT_GT(tox_conference_uid_size(), 0);
|
|
EXPECT_GT(tox_conference_id_size(), 0);
|
|
EXPECT_GT(tox_nospam_size(), 0);
|
|
EXPECT_GT(tox_address_size(), 0);
|
|
EXPECT_GT(tox_max_name_length(), 0);
|
|
EXPECT_GT(tox_max_status_message_length(), 0);
|
|
EXPECT_GT(tox_max_friend_request_length(), 0);
|
|
EXPECT_GT(tox_max_message_length(), 0);
|
|
EXPECT_GT(tox_max_custom_packet_size(), 0);
|
|
EXPECT_GT(tox_hash_length(), 0);
|
|
EXPECT_GT(tox_file_id_length(), 0);
|
|
EXPECT_GT(tox_max_filename_length(), 0);
|
|
EXPECT_GT(tox_max_hostname_length(), 0);
|
|
EXPECT_GT(tox_group_max_topic_length(), 0);
|
|
EXPECT_GT(tox_group_max_part_length(), 0);
|
|
EXPECT_GT(tox_group_max_message_length(), 0);
|
|
EXPECT_GT(tox_group_max_custom_lossy_packet_length(), 0);
|
|
EXPECT_GT(tox_group_max_custom_lossless_packet_length(), 0);
|
|
EXPECT_GT(tox_group_max_group_name_length(), 0);
|
|
EXPECT_GT(tox_group_max_password_size(), 0);
|
|
EXPECT_GT(tox_group_chat_id_size(), 0);
|
|
EXPECT_GT(tox_group_peer_public_key_size(), 0);
|
|
EXPECT_GT(tox_dht_node_ip_string_size(), 0);
|
|
EXPECT_GT(tox_dht_node_public_key_size(), 0);
|
|
}
|
|
|
|
TEST(Tox, BootstrapErrorCodes)
|
|
{
|
|
Tox *tox = tox_new(nullptr, nullptr);
|
|
ASSERT_NE(tox, nullptr);
|
|
|
|
Tox_Err_Bootstrap err;
|
|
std::array<uint8_t, TOX_PUBLIC_KEY_SIZE> pk;
|
|
tox_bootstrap(tox, "127.0.0.1", 0, pk.data(), &err);
|
|
EXPECT_EQ(err, TOX_ERR_BOOTSTRAP_BAD_PORT);
|
|
|
|
tox_bootstrap(tox, nullptr, 33445, pk.data(), &err);
|
|
EXPECT_EQ(err, TOX_ERR_BOOTSTRAP_NULL);
|
|
|
|
tox_kill(tox);
|
|
}
|
|
|
|
TEST(Tox, OneTest)
|
|
{
|
|
struct Tox_Options *options = tox_options_new(nullptr);
|
|
ASSERT_NE(options, nullptr);
|
|
|
|
tox_options_set_log_callback(options,
|
|
[](Tox *tox, Tox_Log_Level level, const char *file, uint32_t line, const char *func,
|
|
const char *message, void *user_data) {
|
|
fprintf(stderr, "[%c] %s:%d(%s): %s\n", tox_log_level_to_string(level)[0], file, line,
|
|
func, message);
|
|
});
|
|
|
|
// Higher start/end point here to avoid conflict with the LAN discovery test.
|
|
tox_options_set_start_port(options, 33545);
|
|
tox_options_set_end_port(options, 33545 + 2000);
|
|
|
|
std::vector<uint8_t> name(tox_max_name_length());
|
|
std::vector<uint8_t> status_message(tox_max_status_message_length());
|
|
|
|
std::vector<uint8_t> name2(tox_max_name_length());
|
|
std::vector<uint8_t> status_message2(tox_max_status_message_length());
|
|
|
|
Tox *tox1 = tox_new(options, nullptr);
|
|
ASSERT_NE(tox1, nullptr);
|
|
const Random *rng = os_random();
|
|
ASSERT_NE(rng, nullptr);
|
|
set_random_name_and_status_message(tox1, rng, name.data(), status_message.data());
|
|
Tox *tox2 = tox_new(options, nullptr);
|
|
ASSERT_NE(tox2, nullptr);
|
|
set_random_name_and_status_message(tox2, rng, name2.data(), status_message2.data());
|
|
|
|
std::array<uint8_t, TOX_ADDRESS_SIZE> address;
|
|
tox_self_get_address(tox1, address.data());
|
|
Tox_Err_Friend_Add error;
|
|
uint32_t ret
|
|
= tox_friend_add(tox1, address.data(), reinterpret_cast<const uint8_t *>("m"), 1, &error);
|
|
EXPECT_EQ(error, TOX_ERR_FRIEND_ADD_OWN_KEY) << "Adding own address worked.";
|
|
EXPECT_EQ(ret, UINT32_MAX);
|
|
|
|
tox_self_get_address(tox2, address.data());
|
|
std::vector<uint8_t> message(tox_max_friend_request_length() + 1);
|
|
ret = tox_friend_add(tox1, address.data(), nullptr, 0, &error);
|
|
EXPECT_EQ(error, TOX_ERR_FRIEND_ADD_NULL) << "Sending request with no message worked.";
|
|
EXPECT_EQ(ret, UINT32_MAX);
|
|
ret = tox_friend_add(tox1, address.data(), message.data(), 0, &error);
|
|
EXPECT_EQ(error, TOX_ERR_FRIEND_ADD_NO_MESSAGE) << "Sending request with no message worked.";
|
|
EXPECT_EQ(ret, UINT32_MAX);
|
|
ret = tox_friend_add(tox1, address.data(), message.data(), message.size(), &error);
|
|
EXPECT_EQ(error, TOX_ERR_FRIEND_ADD_TOO_LONG) << "tox_max_friend_request_length() is too big.";
|
|
EXPECT_EQ(ret, UINT32_MAX);
|
|
|
|
address[0]++;
|
|
ret = tox_friend_add(tox1, address.data(), reinterpret_cast<const uint8_t *>("m"), 1, &error);
|
|
EXPECT_EQ(error, TOX_ERR_FRIEND_ADD_BAD_CHECKSUM) << "Adding address with bad checksum worked.";
|
|
EXPECT_EQ(ret, UINT32_MAX);
|
|
|
|
tox_self_get_address(tox2, address.data());
|
|
ret = tox_friend_add(
|
|
tox1, address.data(), message.data(), tox_max_friend_request_length(), &error);
|
|
EXPECT_EQ(error, TOX_ERR_FRIEND_ADD_OK) << "Failed to add friend.";
|
|
EXPECT_EQ(ret, 0);
|
|
ret = tox_friend_add(
|
|
tox1, address.data(), message.data(), tox_max_friend_request_length(), &error);
|
|
EXPECT_EQ(error, TOX_ERR_FRIEND_ADD_ALREADY_SENT) << "Adding friend twice worked.";
|
|
EXPECT_EQ(ret, UINT32_MAX);
|
|
|
|
tox_self_set_name(tox1, name.data(), name.size(), nullptr);
|
|
EXPECT_EQ(tox_self_get_name_size(tox1), name.size())
|
|
<< "Can't set name of length " << tox_max_name_length();
|
|
|
|
tox_self_set_status_message(tox1, status_message.data(), status_message.size(), nullptr);
|
|
EXPECT_EQ(tox_self_get_status_message_size(tox1), status_message.size())
|
|
<< "Can't set status message of length " << tox_max_status_message_length();
|
|
|
|
tox_self_get_address(tox1, address.data());
|
|
std::vector<uint8_t> data(tox_get_savedata_size(tox1));
|
|
tox_get_savedata(tox1, data.data());
|
|
|
|
tox_kill(tox2);
|
|
Tox_Err_New err_n;
|
|
|
|
tox_options_set_savedata_type(options, TOX_SAVEDATA_TYPE_TOX_SAVE);
|
|
tox_options_set_savedata_data(options, data.data(), data.size());
|
|
tox2 = tox_new(options, &err_n);
|
|
EXPECT_EQ(err_n, TOX_ERR_NEW_OK) << "Load failed";
|
|
|
|
EXPECT_EQ(tox_self_get_name_size(tox2), name.size()) << "Wrong name size.";
|
|
EXPECT_EQ(tox_self_get_status_message_size(tox2), status_message.size())
|
|
<< "Wrong status message size";
|
|
|
|
std::vector<uint8_t> name_loaded(tox_max_name_length());
|
|
tox_self_get_name(tox2, name_loaded.data());
|
|
EXPECT_EQ(name, name_loaded) << "Wrong name.";
|
|
|
|
std::vector<uint8_t> status_message_loaded(tox_max_status_message_length());
|
|
tox_self_get_status_message(tox2, status_message_loaded.data());
|
|
EXPECT_EQ(status_message, status_message_loaded) << "Wrong status message.";
|
|
|
|
std::array<uint8_t, TOX_ADDRESS_SIZE> address2;
|
|
tox_self_get_address(tox2, address2.data());
|
|
EXPECT_EQ(address2, address) << "Wrong address.";
|
|
std::vector<uint8_t> new_name(tox_max_name_length());
|
|
tox_self_get_name(tox2, new_name.data());
|
|
EXPECT_EQ(name, new_name) << "Wrong name";
|
|
|
|
std::array<uint8_t, TOX_SECRET_KEY_SIZE> sk;
|
|
tox_self_get_secret_key(tox2, sk.data());
|
|
tox_kill(tox2);
|
|
|
|
tox_options_default(options);
|
|
tox_options_set_savedata_type(options, TOX_SAVEDATA_TYPE_SECRET_KEY);
|
|
tox_options_set_savedata_data(options, sk.data(), sk.size());
|
|
tox2 = tox_new(options, &err_n);
|
|
ASSERT_EQ(err_n, TOX_ERR_NEW_OK) << "Load failed";
|
|
tox_self_set_nospam(tox2, tox_self_get_nospam(tox1));
|
|
std::array<uint8_t, TOX_ADDRESS_SIZE> address3;
|
|
tox_self_get_address(tox2, address3.data());
|
|
EXPECT_EQ(address3, address) << "Wrong public key.";
|
|
std::array<uint8_t, TOX_PUBLIC_KEY_SIZE> pk;
|
|
tox_self_get_public_key(tox2, pk.data());
|
|
std::array<uint8_t, TOX_PUBLIC_KEY_SIZE> pk_from_addr;
|
|
std::copy(address.begin(), address.begin() + TOX_PUBLIC_KEY_SIZE, pk_from_addr.begin());
|
|
EXPECT_EQ(pk, pk_from_addr) << "Wrong public key.";
|
|
|
|
tox_options_free(options);
|
|
tox_kill(tox1);
|
|
tox_kill(tox2);
|
|
}
|
|
|
|
} // namespace
|