81b1e4f6348 chore: Release v0.2.21-rc.1 9303e2e49a1 chore: Update the pkgsrc versions in the update-versions tool 71ec4b3b1e9 chore: Update the version-sync script to work in a post-tox.api.h world 66da842f753 chore: Add version update script compatible with ci-tools. 199878f7660 chore: Use new bazel script for circle ci. 8278e9cda46 chore: Add release issue template and workflow. a9bb3a1c4d1 chore: Fix alpine-s390x build. 6e0a641272e chore: Add a source tarball deploy workflow. 4adebe4d8b1 chore: Don't upload ios/macos variants in deploy workflows. 18f1d858ccb chore: Move one of the 3 freebsd builds to post-submit. 432ab60c002 feat: Add a Makefile for the single file deploy build. a86c0011fd5 chore: Add deploy job for single C file library. 2e7495e8f2a docs: Update changelog format to use the new clog-compatible way. a682da99e84 chore: Export wasmExports from the wasm binary. 12f34cdff27 chore: Add wasm to the nightly binary deploys. 1451029613f chore: Add strict-abi support for macOS/iOS. c53c30e09d9 chore: Add time option to manual fuzz trigger. 2ccecdc2a1a chore: Add remaining fuzz tests to cflite. 4626c2e230e test: Add a Net_Crypto fuzz test. b4a0e617c48 refactor: Use IP string length from ip_ntoa instead of strlen. b85b91f22f6 cleanup: rename getnodes/sendnodes to nodes request/response This change alignes the naming to be closer to the spec and make it less ambiguous. This change also changes the naming of some private/experimental marked APIs. - tox_callback_dht_nodes_response() - tox_dht_nodes_request() - Tox_Event_Dht_Get_Nodes_Response f1991aaa029 perf: Use stack allocation for strerror rendering. 3984211ccbf cleanup: remove kicked peers from saved peers list 26a991ed2be fix: ip to string function not accepting tcp families 712861f2e6d cleanup: Make websockify output qtox-compatible logging. 01932ea2f73 chore: Add opus and vpx to the toxcore wasm build. d29c42ef631 refactor: don't fully discard received DHT nodes. This is mostly forward thinking, where we might introduce other ip families, in addition to ipv4, ipv6, tcp_ipv4 etc. 21e2325934f chore: Fix xcframework tarball creation. b10c8b766ba chore: Fix xcframework checksum creation. 93787a9322e chore: Add ios/macos framework build. 9f723f891d3 fix: run do_gca also in bootstrap nodes 496cc703556 chore: Support arm64 iphone simulator. aa0e2a8e928 chore: Add support for more iOS architectures. 13ad8e81cbf chore: Add binary deploy workflows. c8344726378 refactor: Move tox_log_level out into its own file. 8799bea76c3 cleanup: Mark events/dispatch headers as experimental. d4164edb548 refactor: Remove tox_types.h; use `struct` tags instead. d408c982090 refactor: Move `Tox_Options` to `tox_options.h`. 5ab42d41209 chore: Move most cirrus jobs to circleci. 463eeae1144 cleanup: Avoid clashing with global define `DEBUG`. 92cc1e91747 refactor: Make Tox_Options own the passed proxy host and savedata. f276b397226 test: Add some more asserts for I/O and alloc to succeed. edb4dfc4869 fix: Don't crash on malloc failures in bin_unpack. be457d5d0b2 cleanup: Use tox memory for bin_unpack and net_strerror. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: 81b1e4f6348124784088591c4fe9ab41e273031d
77 lines
2.6 KiB
JavaScript
77 lines
2.6 KiB
JavaScript
// jshint esversion: 6
|
|
|
|
// This code will check that the pull request has been approved via GitHub
|
|
// review approval by a minimum number of reviewers and by all assignees, and
|
|
// that no changes were requested by any reviewers. Only reviewers with write
|
|
// access to the repository are considered.
|
|
//
|
|
// This is very similar to GitHub's built-in branch protection option to require
|
|
// pull request reviews before merging, but allows for much more flexibility and
|
|
// customization.
|
|
|
|
// dependencies: lodash4
|
|
|
|
// Helper function to check if a user is a bot.
|
|
function isBotAuthor(author) {
|
|
return (
|
|
author.username.endsWith("[bot]") || author.username.startsWith("toktok-")
|
|
);
|
|
}
|
|
|
|
function equals(a) {
|
|
return (b) => a === b;
|
|
}
|
|
|
|
// The number of approvals required to merge: at least 2 humans must approve the
|
|
// code. If the author is a bot, then 2 approvals are required; otherwise, only
|
|
// 1 approval is required (because 1 human wrote the code, so they approve).
|
|
let numApprovalsRequired = isBotAuthor(review.pullRequest.author) ? 2 : 1;
|
|
|
|
const approvals = review.pullRequest.approvals;
|
|
|
|
let numApprovals = _.filter(approvals, equals("approved")).length;
|
|
const numRejections = _.filter(approvals, equals("changes_requested")).length;
|
|
|
|
const discussionBlockers = _(review.discussions)
|
|
.filter((x) => !x.resolved)
|
|
.flatMap("participants")
|
|
.filter((x) => !x.resolved)
|
|
.map((user) => _.pick(user, "username"))
|
|
.value();
|
|
|
|
let pendingReviewers = _(discussionBlockers)
|
|
.map((user) => _.pick(user, "username"))
|
|
.concat(review.pullRequest.requestedReviewers)
|
|
.value();
|
|
|
|
const required = _.map(review.pullRequest.assignees, "username");
|
|
_.pull(required, review.pullRequest.author.username);
|
|
if (required.length) {
|
|
numApprovalsRequired = _.max([required.length, numApprovalsRequired]);
|
|
numApprovals =
|
|
_(approvals).pick(required).filter(equals("approved")).size() +
|
|
_.min([numApprovals, numApprovalsRequired - required.length]);
|
|
pendingReviewers = _(required)
|
|
.reject((username) => approvals[username] === "approved")
|
|
.reject((username) => pendingReviewers.length && approvals[username])
|
|
.map((username) => ({ username }))
|
|
.concat(pendingReviewers)
|
|
.value();
|
|
}
|
|
|
|
pendingReviewers = _.uniqBy(pendingReviewers, "username");
|
|
|
|
const description =
|
|
(numRejections ? `${numRejections} change requests, ` : "") +
|
|
`${numApprovals} of ${numApprovalsRequired} approvals obtained`;
|
|
const shortDescription =
|
|
(numRejections ? `${numRejections} ✗, ` : "") +
|
|
`${numApprovals} of ${numApprovalsRequired} ✓`;
|
|
|
|
return {
|
|
completed: numApprovals >= numApprovalsRequired,
|
|
description,
|
|
shortDescription,
|
|
pendingReviewers,
|
|
};
|