9ed2fa80d fix(toxav): remove extra copy of video frame on encode de30cf3ad docs: Add new file kinds, that should be useful to all clients. d5b5e879d fix(DHT): Correct node skipping logic timed out nodes. 30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch. 8fdbb0b50 style: Format parameter lists in event handlers. d00dee12b refactor: Add warning logs when losing chat invites. b144e8db1 feat: Add a way to look up a file number by ID. 849281ea0 feat: Add a way to fetch groups by chat ID. a2c177396 refactor: Harden event system and improve type safety. 8f5caa656 refactor: Add MessagePack string support to bin_pack. 34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner. f7b068010 refactor: Add nullability annotations to event headers. 788abe651 refactor(toxav): Use system allocator for mutexes. 2e4b423eb refactor: Use specific typedefs for public API arrays. 2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354 2f87ac67b feat: Add Event Loop abstraction (Ev). f8dfc38d8 test: Fix data race in ToxScenario virtual_clock. 38313921e test(TCP): Add regression test for TCP priority queue integrity. f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex. ad054511e refactor: Internalize DHT structs and add debug helpers. 8b467cc96 fix: Prevent potential integer overflow in group chat handshake. 4962bdbb8 test: Improve TCP simulation and add tests 5f0227093 refactor: Allow nullable data in group chat handlers. e97b18ea9 chore: Improve Windows Docker support. b14943bbd refactor: Move Logger out of Messenger into Tox. dd3136250 cleanup: Apply nullability qualifiers to C++ codebase. 1849f70fc refactor: Extract low-level networking code to net and os_network. 8fec75421 refactor: Delete tox_random, align on rng and os_random. a03ae8051 refactor: Delete tox_memory, align on mem and os_memory. 4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code. 72452f2ae test: Add some more tests for onion and shared key cache. d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it. b6f5b9fc5 test: Add some benchmarks for various high level things. 8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8
243 lines
5.8 KiB
C++
243 lines
5.8 KiB
C++
#include "ring_buffer.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <algorithm>
|
|
#include <cassert>
|
|
#include <cstdint>
|
|
#include <vector>
|
|
|
|
#include "../toxcore/attributes.h"
|
|
|
|
namespace {
|
|
|
|
template <typename T>
|
|
class TypedRingBuffer;
|
|
|
|
template <typename T>
|
|
class TypedRingBuffer<T *> {
|
|
public:
|
|
explicit TypedRingBuffer(int size)
|
|
: rb_(rb_new(size))
|
|
{
|
|
}
|
|
~TypedRingBuffer() { rb_kill(rb_); }
|
|
TypedRingBuffer(TypedRingBuffer const &) = delete;
|
|
|
|
bool full() const { return rb_full(rb_); }
|
|
bool empty() const { return rb_empty(rb_); }
|
|
T *_Nullable write(T *_Nullable p) { return static_cast<T *>(rb_write(rb_, p)); }
|
|
bool read(T *_Nullable *_Nonnull p)
|
|
{
|
|
void *_Nullable vp;
|
|
bool res = rb_read(rb_, &vp);
|
|
*p = static_cast<T *>(vp);
|
|
return res;
|
|
}
|
|
|
|
std::uint16_t size() const { return rb_size(rb_); }
|
|
std::uint16_t data(T *_Nullable *_Nonnull dest, std::uint16_t dest_size) const
|
|
{
|
|
const std::uint16_t current_size = std::min(size(), dest_size);
|
|
std::vector<void *_Nullable> vdest(current_size);
|
|
const std::uint16_t res = rb_data(rb_, vdest.data(), current_size);
|
|
for (std::uint16_t i = 0; i < res; i++) {
|
|
dest[i] = static_cast<T *>(vdest.at(i));
|
|
}
|
|
return res;
|
|
}
|
|
|
|
bool contains(T *_Nullable p) const
|
|
{
|
|
const std::uint16_t current_size = size();
|
|
std::vector<T *_Nullable> elts(current_size);
|
|
data(elts.data(), current_size);
|
|
return std::find(elts.begin(), elts.end(), p) != elts.end();
|
|
}
|
|
|
|
bool ok() const { return rb_ != nullptr; }
|
|
|
|
private:
|
|
RingBuffer *_Nullable rb_;
|
|
};
|
|
|
|
TEST(RingBuffer, EmptyBufferReportsEmpty)
|
|
{
|
|
TypedRingBuffer<int *> rb(10);
|
|
ASSERT_TRUE(rb.ok());
|
|
EXPECT_TRUE(rb.empty());
|
|
}
|
|
|
|
TEST(RingBuffer, EmptyBufferReportsNotFull)
|
|
{
|
|
TypedRingBuffer<int *> rb(10);
|
|
ASSERT_TRUE(rb.ok());
|
|
EXPECT_FALSE(rb.full());
|
|
}
|
|
|
|
TEST(RingBuffer, ZeroSizedRingBufferIsBothEmptyAndFull)
|
|
{
|
|
TypedRingBuffer<int *> rb(0);
|
|
ASSERT_TRUE(rb.ok());
|
|
EXPECT_TRUE(rb.empty());
|
|
EXPECT_TRUE(rb.full());
|
|
}
|
|
|
|
TEST(RingBuffer, WritingMakesBufferNotEmpty)
|
|
{
|
|
TypedRingBuffer<int *> rb(2);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
rb.write(&value0);
|
|
EXPECT_FALSE(rb.empty());
|
|
}
|
|
|
|
TEST(RingBuffer, WritingOneElementMakesBufferNotFull)
|
|
{
|
|
TypedRingBuffer<int *> rb(2);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
rb.write(&value0);
|
|
EXPECT_FALSE(rb.full());
|
|
}
|
|
|
|
TEST(RingBuffer, WritingAllElementsMakesBufferFull)
|
|
{
|
|
TypedRingBuffer<int *> rb(2);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
int value1 = 231;
|
|
rb.write(&value0);
|
|
rb.write(&value1);
|
|
EXPECT_TRUE(rb.full());
|
|
}
|
|
|
|
TEST(RingBuffer, ReadingElementFromFullBufferMakesItNotFull)
|
|
{
|
|
TypedRingBuffer<int *> rb(2);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
int value1 = 231;
|
|
rb.write(&value0);
|
|
rb.write(&value1);
|
|
EXPECT_TRUE(rb.full());
|
|
int *retrieved;
|
|
// Reading deletes the element.
|
|
EXPECT_TRUE(rb.read(&retrieved));
|
|
EXPECT_FALSE(rb.full());
|
|
}
|
|
|
|
TEST(RingBuffer, ZeroSizeBufferCanBeWrittenToOnce)
|
|
{
|
|
TypedRingBuffer<int *> rb(0);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
// Strange behaviour: we can write one element to a 0-size buffer.
|
|
EXPECT_EQ(nullptr, rb.write(&value0));
|
|
EXPECT_EQ(&value0, rb.write(&value0));
|
|
int *retrieved = nullptr;
|
|
// But then we can't read it.
|
|
EXPECT_FALSE(rb.read(&retrieved));
|
|
EXPECT_EQ(nullptr, retrieved);
|
|
}
|
|
|
|
TEST(RingBuffer, ReadingFromEmptyBufferFails)
|
|
{
|
|
TypedRingBuffer<int *> rb(2);
|
|
ASSERT_TRUE(rb.ok());
|
|
int *retrieved;
|
|
EXPECT_FALSE(rb.read(&retrieved));
|
|
}
|
|
|
|
TEST(RingBuffer, WritingToBufferWhenFullOverwritesBeginning)
|
|
{
|
|
TypedRingBuffer<int *> rb(2);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
int value1 = 231;
|
|
int value2 = 312;
|
|
int value3 = 432;
|
|
EXPECT_EQ(nullptr, rb.write(&value0));
|
|
EXPECT_EQ(nullptr, rb.write(&value1));
|
|
EXPECT_TRUE(rb.contains(&value0));
|
|
EXPECT_TRUE(rb.contains(&value1));
|
|
|
|
// Adding another element evicts the first element.
|
|
EXPECT_EQ(&value0, rb.write(&value2));
|
|
EXPECT_FALSE(rb.contains(&value0));
|
|
EXPECT_TRUE(rb.contains(&value2));
|
|
|
|
// Adding another evicts the second.
|
|
EXPECT_EQ(&value1, rb.write(&value3));
|
|
EXPECT_FALSE(rb.contains(&value1));
|
|
EXPECT_TRUE(rb.contains(&value3));
|
|
}
|
|
|
|
TEST(RingBuffer, SizeIsNumberOfElementsInBuffer)
|
|
{
|
|
TypedRingBuffer<int *> rb(10);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
EXPECT_EQ(rb.size(), 0);
|
|
rb.write(&value0);
|
|
EXPECT_EQ(rb.size(), 1);
|
|
rb.write(&value0);
|
|
EXPECT_EQ(rb.size(), 2);
|
|
rb.write(&value0);
|
|
EXPECT_EQ(rb.size(), 3);
|
|
rb.write(&value0);
|
|
EXPECT_EQ(rb.size(), 4);
|
|
|
|
int *retrieved;
|
|
rb.read(&retrieved);
|
|
EXPECT_EQ(rb.size(), 3);
|
|
rb.read(&retrieved);
|
|
EXPECT_EQ(rb.size(), 2);
|
|
rb.read(&retrieved);
|
|
EXPECT_EQ(rb.size(), 1);
|
|
rb.read(&retrieved);
|
|
EXPECT_EQ(rb.size(), 0);
|
|
}
|
|
|
|
TEST(RingBuffer, SizeIsLimitedByMaxSize)
|
|
{
|
|
TypedRingBuffer<int *> rb(4);
|
|
ASSERT_TRUE(rb.ok());
|
|
int value0 = 123;
|
|
rb.write(&value0);
|
|
rb.write(&value0);
|
|
rb.write(&value0);
|
|
rb.write(&value0);
|
|
EXPECT_EQ(rb.size(), 4);
|
|
|
|
// Add one more.
|
|
rb.write(&value0);
|
|
// Still size is 4.
|
|
EXPECT_EQ(rb.size(), 4);
|
|
}
|
|
|
|
TEST(RingBuffer, NewWithInvalidSizeReturnsNull)
|
|
{
|
|
EXPECT_EQ(nullptr, rb_new(-1));
|
|
EXPECT_EQ(nullptr, rb_new(65535));
|
|
}
|
|
|
|
TEST(RingBuffer, DataWithSmallerDestSizeIsTruncated)
|
|
{
|
|
TypedRingBuffer<int *> rb(4);
|
|
ASSERT_TRUE(rb.ok());
|
|
int values[] = {1, 2, 3, 4};
|
|
rb.write(&values[0]);
|
|
rb.write(&values[1]);
|
|
rb.write(&values[2]);
|
|
rb.write(&values[3]);
|
|
|
|
int *dest[2];
|
|
std::uint16_t res = rb.data(dest, 2);
|
|
EXPECT_EQ(res, 2);
|
|
EXPECT_EQ(dest[0], &values[0]);
|
|
EXPECT_EQ(dest[1], &values[1]);
|
|
}
|
|
|
|
} // namespace
|