9b36dd9d99
9ed2fa80d fix(toxav): remove extra copy of video frame on encode de30cf3ad docs: Add new file kinds, that should be useful to all clients. d5b5e879d fix(DHT): Correct node skipping logic timed out nodes. 30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch. 8fdbb0b50 style: Format parameter lists in event handlers. d00dee12b refactor: Add warning logs when losing chat invites. b144e8db1 feat: Add a way to look up a file number by ID. 849281ea0 feat: Add a way to fetch groups by chat ID. a2c177396 refactor: Harden event system and improve type safety. 8f5caa656 refactor: Add MessagePack string support to bin_pack. 34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner. f7b068010 refactor: Add nullability annotations to event headers. 788abe651 refactor(toxav): Use system allocator for mutexes. 2e4b423eb refactor: Use specific typedefs for public API arrays. 2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354 2f87ac67b feat: Add Event Loop abstraction (Ev). f8dfc38d8 test: Fix data race in ToxScenario virtual_clock. 38313921e test(TCP): Add regression test for TCP priority queue integrity. f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex. ad054511e refactor: Internalize DHT structs and add debug helpers. 8b467cc96 fix: Prevent potential integer overflow in group chat handshake. 4962bdbb8 test: Improve TCP simulation and add tests 5f0227093 refactor: Allow nullable data in group chat handlers. e97b18ea9 chore: Improve Windows Docker support. b14943bbd refactor: Move Logger out of Messenger into Tox. dd3136250 cleanup: Apply nullability qualifiers to C++ codebase. 1849f70fc refactor: Extract low-level networking code to net and os_network. 8fec75421 refactor: Delete tox_random, align on rng and os_random. a03ae8051 refactor: Delete tox_memory, align on mem and os_memory. 4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code. 72452f2ae test: Add some more tests for onion and shared key cache. d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it. b6f5b9fc5 test: Add some benchmarks for various high level things. 8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8
99 lines
2.8 KiB
C++
99 lines
2.8 KiB
C++
#include "TCP_common.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "logger.h"
|
|
#include "os_memory.h"
|
|
#include "os_random.h"
|
|
|
|
namespace {
|
|
|
|
TEST(TCP_common, PriorityQueueOrderingAndIntegrity)
|
|
{
|
|
constexpr Network_Funcs mock_funcs = {
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
// Mock net_send to simulate a full buffer (returns 0)
|
|
// This forces packets into the priority queue.
|
|
[](void *obj, Socket sock, const uint8_t *buf, size_t len) {
|
|
(void)obj;
|
|
(void)sock;
|
|
(void)buf;
|
|
(void)len;
|
|
return 0;
|
|
},
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
nullptr,
|
|
};
|
|
|
|
TCP_Connection con;
|
|
memset(&con, 0, sizeof(con));
|
|
con.mem = os_memory();
|
|
con.rng = os_random();
|
|
Network ns = {&mock_funcs, nullptr};
|
|
con.ns = &ns;
|
|
|
|
Logger *logger = logger_new(con.mem);
|
|
ASSERT_NE(logger, nullptr);
|
|
|
|
// Minimal initialization to make write_packet_tcp_secure_connection happy
|
|
// It calls encrypt_data_symmetric which needs shared_key and sent_nonce
|
|
memset(con.shared_key, 0x42, sizeof(con.shared_key));
|
|
memset(con.sent_nonce, 0x12, sizeof(con.sent_nonce));
|
|
|
|
uint8_t data1[] = "packet1";
|
|
uint8_t data2[] = "packet2";
|
|
uint8_t data3[] = "packet3";
|
|
|
|
// First packet: will fail net_send (mocked to 0) and go to add_priority
|
|
// Queue: [packet1]
|
|
int ret1 = write_packet_tcp_secure_connection(logger, &con, data1, sizeof(data1), true);
|
|
ASSERT_EQ(ret1, 1);
|
|
ASSERT_NE(con.priority_queue_start, nullptr);
|
|
ASSERT_EQ(con.priority_queue_start, con.priority_queue_end);
|
|
|
|
// Second packet: will go to add_priority
|
|
// Queue: [packet1] -> [packet2]
|
|
int ret2 = write_packet_tcp_secure_connection(logger, &con, data2, sizeof(data2), true);
|
|
ASSERT_EQ(ret2, 1);
|
|
ASSERT_NE(con.priority_queue_start->next, nullptr);
|
|
ASSERT_EQ(con.priority_queue_start->next, con.priority_queue_end);
|
|
|
|
// Third packet: will go to add_priority
|
|
// WITH BUG: Queue becomes [packet1] -> [packet3], packet2 is LOST
|
|
// WITHOUT BUG: Queue: [packet1] -> [packet2] -> [packet3]
|
|
int ret3 = write_packet_tcp_secure_connection(logger, &con, data3, sizeof(data3), true);
|
|
ASSERT_EQ(ret3, 1);
|
|
|
|
// Verify integrity
|
|
TCP_Priority_List *p = con.priority_queue_start;
|
|
int count = 0;
|
|
while (p) {
|
|
count++;
|
|
p = p->next;
|
|
}
|
|
|
|
// This is where it will fail if the change in
|
|
// https://github.com/TokTok/c-toxcore/pull/2387 is applied.
|
|
// The count will be 2 instead of 3.
|
|
EXPECT_EQ(count, 3)
|
|
<< "Priority queue lost packets! (likely due to incorrect tail pointer usage)";
|
|
|
|
// Clean up
|
|
wipe_priority_list(con.mem, con.priority_queue_start);
|
|
logger_kill(logger);
|
|
}
|
|
|
|
}
|