9ed2fa80d fix(toxav): remove extra copy of video frame on encode de30cf3ad docs: Add new file kinds, that should be useful to all clients. d5b5e879d fix(DHT): Correct node skipping logic timed out nodes. 30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch. 8fdbb0b50 style: Format parameter lists in event handlers. d00dee12b refactor: Add warning logs when losing chat invites. b144e8db1 feat: Add a way to look up a file number by ID. 849281ea0 feat: Add a way to fetch groups by chat ID. a2c177396 refactor: Harden event system and improve type safety. 8f5caa656 refactor: Add MessagePack string support to bin_pack. 34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner. f7b068010 refactor: Add nullability annotations to event headers. 788abe651 refactor(toxav): Use system allocator for mutexes. 2e4b423eb refactor: Use specific typedefs for public API arrays. 2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354 2f87ac67b feat: Add Event Loop abstraction (Ev). f8dfc38d8 test: Fix data race in ToxScenario virtual_clock. 38313921e test(TCP): Add regression test for TCP priority queue integrity. f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex. ad054511e refactor: Internalize DHT structs and add debug helpers. 8b467cc96 fix: Prevent potential integer overflow in group chat handshake. 4962bdbb8 test: Improve TCP simulation and add tests 5f0227093 refactor: Allow nullable data in group chat handlers. e97b18ea9 chore: Improve Windows Docker support. b14943bbd refactor: Move Logger out of Messenger into Tox. dd3136250 cleanup: Apply nullability qualifiers to C++ codebase. 1849f70fc refactor: Extract low-level networking code to net and os_network. 8fec75421 refactor: Delete tox_random, align on rng and os_random. a03ae8051 refactor: Delete tox_memory, align on mem and os_memory. 4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code. 72452f2ae test: Add some more tests for onion and shared key cache. d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it. b6f5b9fc5 test: Add some benchmarks for various high level things. 8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8
299 lines
9.4 KiB
C++
299 lines
9.4 KiB
C++
// clang-format off
|
|
#include "../testing/support/public/simulated_environment.hh"
|
|
#include "group_moderation.h"
|
|
// clang-format on
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <algorithm>
|
|
#include <array>
|
|
#include <cstdint>
|
|
#include <cstring>
|
|
#include <vector>
|
|
|
|
#include "DHT.h"
|
|
#include "crypto_core.h"
|
|
#include "crypto_core_test_util.hh"
|
|
#include "logger.h"
|
|
#include "util.h"
|
|
|
|
namespace {
|
|
|
|
using tox::test::SimulatedEnvironment;
|
|
using ModerationHash = std::array<std::uint8_t, MOD_MODERATION_HASH_SIZE>;
|
|
|
|
TEST(ModList, PackedSizeOfEmptyModListIsZero)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
EXPECT_EQ(mod_list_packed_size(&mods), 0);
|
|
|
|
std::uint8_t byte = 1;
|
|
mod_list_pack(&mods, &byte);
|
|
EXPECT_EQ(byte, 1);
|
|
}
|
|
|
|
TEST(ModList, UnpackingZeroSizeArrayIsNoop)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
const std::uint8_t byte = 1;
|
|
EXPECT_EQ(mod_list_unpack(&mods, &byte, 0, 0), 0);
|
|
}
|
|
|
|
TEST(ModList, AddRemoveMultipleMods)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
std::uint8_t sig_pk1[32] = {1};
|
|
std::uint8_t sig_pk2[32] = {2};
|
|
EXPECT_TRUE(mod_list_add_entry(&mods, sig_pk1));
|
|
EXPECT_TRUE(mod_list_add_entry(&mods, sig_pk2));
|
|
EXPECT_TRUE(mod_list_remove_entry(&mods, sig_pk1));
|
|
EXPECT_TRUE(mod_list_remove_entry(&mods, sig_pk2));
|
|
}
|
|
|
|
TEST(ModList, PackingAndUnpackingList)
|
|
{
|
|
using ModListEntry = std::array<std::uint8_t, MOD_LIST_ENTRY_SIZE>;
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
EXPECT_TRUE(mod_list_add_entry(&mods, ModListEntry{}.data()));
|
|
|
|
std::vector<std::uint8_t> packed(mod_list_packed_size(&mods));
|
|
mod_list_pack(&mods, packed.data());
|
|
|
|
EXPECT_TRUE(mod_list_remove_entry(&mods, ModListEntry{}.data()));
|
|
|
|
Moderation mods2{&c_mem};
|
|
EXPECT_EQ(mod_list_unpack(&mods2, packed.data(), packed.size(), 1), packed.size());
|
|
EXPECT_TRUE(mod_list_remove_entry(&mods2, ModListEntry{}.data()));
|
|
}
|
|
|
|
TEST(ModList, UnpackingTooManyModsFails)
|
|
{
|
|
using ModListEntry = std::array<std::uint8_t, MOD_LIST_ENTRY_SIZE>;
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
EXPECT_TRUE(mod_list_add_entry(&mods, ModListEntry{}.data()));
|
|
|
|
std::vector<std::uint8_t> packed(mod_list_packed_size(&mods));
|
|
mod_list_pack(&mods, packed.data());
|
|
|
|
Moderation mods2{&c_mem};
|
|
EXPECT_EQ(mod_list_unpack(&mods2, packed.data(), packed.size(), 2), -1);
|
|
EXPECT_TRUE(mod_list_remove_entry(&mods, ModListEntry{}.data()));
|
|
}
|
|
|
|
TEST(ModList, UnpackingFromEmptyBufferFails)
|
|
{
|
|
std::vector<std::uint8_t> packed(1);
|
|
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
EXPECT_EQ(mod_list_unpack(&mods, packed.data(), 0, 1), -1);
|
|
}
|
|
|
|
TEST(ModList, HashOfEmptyModListZeroesOutBuffer)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
auto c_rng = env.fake_random().c_random();
|
|
|
|
Moderation mods{&c_mem};
|
|
|
|
// Fill with random data, check that it's zeroed.
|
|
ModerationHash hash;
|
|
random_bytes(&c_rng, hash.data(), hash.size());
|
|
EXPECT_TRUE(mod_list_make_hash(&mods, hash.data()));
|
|
EXPECT_EQ(hash, ModerationHash{});
|
|
}
|
|
|
|
TEST(ModList, RemoveIndexFromEmptyModListFails)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
EXPECT_FALSE(mod_list_remove_index(&mods, 0));
|
|
EXPECT_FALSE(mod_list_remove_index(&mods, UINT16_MAX));
|
|
}
|
|
|
|
TEST(ModList, RemoveEntryFromEmptyModListFails)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
std::uint8_t sig_pk[32] = {0};
|
|
EXPECT_FALSE(mod_list_remove_entry(&mods, sig_pk));
|
|
}
|
|
|
|
TEST(ModList, ModListRemoveIndex)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
std::uint8_t sig_pk[32] = {1};
|
|
EXPECT_TRUE(mod_list_add_entry(&mods, sig_pk));
|
|
EXPECT_TRUE(mod_list_remove_index(&mods, 0));
|
|
}
|
|
|
|
TEST(ModList, CleanupOnEmptyModsIsNoop)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
mod_list_cleanup(&mods);
|
|
}
|
|
|
|
TEST(ModList, EmptyModListCannotVerifyAnySigPk)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
std::uint8_t sig_pk[32] = {1};
|
|
EXPECT_FALSE(mod_list_verify_sig_pk(&mods, sig_pk));
|
|
}
|
|
|
|
TEST(ModList, ModListAddVerifyRemoveSigPK)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods{&c_mem};
|
|
std::uint8_t sig_pk[32] = {1};
|
|
EXPECT_TRUE(mod_list_add_entry(&mods, sig_pk));
|
|
EXPECT_TRUE(mod_list_verify_sig_pk(&mods, sig_pk));
|
|
EXPECT_TRUE(mod_list_remove_entry(&mods, sig_pk));
|
|
EXPECT_FALSE(mod_list_verify_sig_pk(&mods, sig_pk));
|
|
}
|
|
|
|
TEST(ModList, ModListHashCheck)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mods1{&c_mem};
|
|
std::uint8_t sig_pk1[32] = {1};
|
|
std::array<std::uint8_t, MOD_MODERATION_HASH_SIZE> hash1;
|
|
|
|
EXPECT_TRUE(mod_list_add_entry(&mods1, sig_pk1));
|
|
EXPECT_TRUE(mod_list_make_hash(&mods1, hash1.data()));
|
|
EXPECT_TRUE(mod_list_remove_entry(&mods1, sig_pk1));
|
|
}
|
|
|
|
TEST(SanctionsList, PackingIntoUndersizedBufferFails)
|
|
{
|
|
Mod_Sanction sanctions[1] = {};
|
|
std::array<std::uint8_t, 1> packed;
|
|
EXPECT_EQ(sanctions_list_pack(packed.data(), packed.size(), sanctions, 1, nullptr), -1);
|
|
|
|
std::uint16_t length = sanctions_list_packed_size(1) - 1;
|
|
std::vector<std::uint8_t> packed2(length);
|
|
EXPECT_EQ(sanctions_list_pack(packed2.data(), packed2.size(), sanctions, 1, nullptr), -1);
|
|
}
|
|
|
|
TEST(SanctionsList, PackUnpackSanctionsCreds)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
Moderation mod{&c_mem};
|
|
std::array<std::uint8_t, MOD_SANCTIONS_CREDS_SIZE> packed;
|
|
EXPECT_EQ(sanctions_creds_pack(&mod.sanctions_creds, packed.data()), MOD_SANCTIONS_CREDS_SIZE);
|
|
EXPECT_EQ(
|
|
sanctions_creds_unpack(&mod.sanctions_creds, packed.data()), MOD_SANCTIONS_CREDS_SIZE);
|
|
}
|
|
|
|
struct SanctionsListMod : ::testing::Test {
|
|
protected:
|
|
SimulatedEnvironment env;
|
|
Memory c_mem_;
|
|
Random c_rng_;
|
|
|
|
Extended_Public_Key pk;
|
|
Extended_Secret_Key sk;
|
|
Logger *log = nullptr;
|
|
Moderation mod;
|
|
|
|
Mod_Sanction sanctions[2] = {};
|
|
const std::uint8_t sanctioned_pk1[32] = {1};
|
|
const std::uint8_t sanctioned_pk2[32] = {2};
|
|
|
|
SanctionsListMod()
|
|
: c_mem_(env.fake_memory().c_memory())
|
|
, c_rng_(env.fake_random().c_random())
|
|
, mod{&c_mem_}
|
|
{
|
|
}
|
|
|
|
void SetUp() override
|
|
{
|
|
log = logger_new(&c_mem_);
|
|
ASSERT_TRUE(create_extended_keypair(&pk, &sk, &c_rng_));
|
|
|
|
mod.log = log;
|
|
|
|
std::memcpy(mod.self_public_sig_key, get_sig_pk(&pk), SIG_PUBLIC_KEY_SIZE);
|
|
std::memcpy(mod.self_secret_sig_key, get_sig_sk(&sk), SIG_SECRET_KEY_SIZE);
|
|
|
|
ASSERT_TRUE(mod_list_add_entry(&mod, get_sig_pk(&pk)));
|
|
|
|
EXPECT_FALSE(sanctions_list_check_integrity(&mod, &mod.sanctions_creds, &sanctions[0], 0));
|
|
EXPECT_FALSE(sanctions_list_check_integrity(&mod, &mod.sanctions_creds, &sanctions[0], 1));
|
|
EXPECT_FALSE(
|
|
sanctions_list_check_integrity(&mod, &mod.sanctions_creds, &sanctions[0], UINT16_MAX));
|
|
|
|
EXPECT_TRUE(sanctions_list_make_entry(&mod, sanctioned_pk1, &sanctions[0], SA_OBSERVER));
|
|
EXPECT_TRUE(sanctions_list_check_integrity(
|
|
&mod, &mod.sanctions_creds, sanctions, mod.num_sanctions));
|
|
EXPECT_TRUE(sanctions_list_make_entry(&mod, sanctioned_pk2, &sanctions[1], SA_OBSERVER));
|
|
EXPECT_TRUE(sanctions_list_check_integrity(
|
|
&mod, &mod.sanctions_creds, sanctions, mod.num_sanctions));
|
|
}
|
|
|
|
~SanctionsListMod() override
|
|
{
|
|
EXPECT_TRUE(sanctions_list_remove_observer(&mod, sanctioned_pk1, nullptr));
|
|
EXPECT_TRUE(sanctions_list_remove_observer(&mod, sanctioned_pk2, nullptr));
|
|
EXPECT_FALSE(sanctions_list_entry_exists(&mod, &sanctions[0]));
|
|
EXPECT_FALSE(sanctions_list_entry_exists(&mod, &sanctions[1]));
|
|
EXPECT_TRUE(mod_list_remove_entry(&mod, get_sig_pk(&pk)));
|
|
|
|
logger_kill(log);
|
|
}
|
|
};
|
|
|
|
// TODO(JFreegman): Split this up into smaller subtests
|
|
TEST_F(SanctionsListMod, PackUnpackSanction)
|
|
{
|
|
std::vector<std::uint8_t> packed(sanctions_list_packed_size(2));
|
|
|
|
EXPECT_EQ(
|
|
sanctions_list_pack(packed.data(), packed.size(), sanctions, 2, nullptr), packed.size());
|
|
|
|
Mod_Sanction unpacked_sanctions[2] = {};
|
|
std::uint16_t processed_data_len = 0;
|
|
|
|
EXPECT_EQ(sanctions_list_unpack(unpacked_sanctions, &mod.sanctions_creds, 2, packed.data(),
|
|
packed.size(), &processed_data_len),
|
|
2);
|
|
|
|
EXPECT_EQ(processed_data_len, packed.size());
|
|
EXPECT_TRUE(sanctions_list_check_integrity(
|
|
&mod, &mod.sanctions_creds, unpacked_sanctions, mod.num_sanctions));
|
|
EXPECT_TRUE(sanctions_list_entry_exists(&mod, &unpacked_sanctions[0]));
|
|
EXPECT_TRUE(sanctions_list_entry_exists(&mod, &unpacked_sanctions[1]));
|
|
}
|
|
|
|
TEST_F(SanctionsListMod, ReplaceSanctionSignatures)
|
|
{
|
|
EXPECT_EQ(sanctions_list_replace_sig(&mod, mod.self_public_sig_key), mod.num_sanctions);
|
|
EXPECT_TRUE(
|
|
sanctions_list_check_integrity(&mod, &mod.sanctions_creds, sanctions, mod.num_sanctions));
|
|
}
|
|
|
|
} // namespace
|