Green Sky
aae086cc65
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to. 32e67ab4c2 cleanup: use typedef for private message ID's in callback 7b1db6adc1 feat: add message IDs to private group messages 99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests e742deddff feat: Check hashes of Windows dependencies when cross-compiling dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image 14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes ed37616249 docs: Update the Windows cross-compilation section 9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies 19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows 1be311e51f feat: Build the fun utils when cross-compiling to Windows 88133f8446 chore: Strip Windows binaries 3cc0ae7535 refactor: Copy over all of the required static dependencies c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows 74bbac5363 feat: Let CMake create the dll instead of doing so ourselves 246642e9ae feat: Harden Windows cross-compilation 8d431c0d11 chore: Bump Windows build dependency versions e519f7998b fix: Remove unnecessary wsock32 dependency on Windows ed2b60c217 chore: Use a specific non-broken slimcc version. d7f21010a1 chore: Update github actions. e71a68b7f2 docs: Update the list of CMake options 77e08876ff chore: Remove mod and founder from group API naming scheme 12bc042767 docs: add the experimental api build option to INSTALL.md e1fa5cae96 refactor: Rename Queries to Query to align with other enums. be82a3ea30 fix: Correct type for conference offline peer numbers. 0627c36716 test: Add pkgsrc build. 92578afe4b test: Add FreeBSD VM action on GitHub. 52ece0f57b test: Build toxcore on NetBSD (VM). 3fe8ee2c11 chore: Only install tox_private.h on request. 9a8dfa06ab fix: save_compatibility_test failing on big-endian systems 86f5e55578 fix: Don't serve files from websockify. 710eb674a5 fix: Correctly pass extended public keys to group moderation code. 021db7031c refactor: Use `struct`s for extended public/secret keys. a1e999fd80 chore: Compile libsodium reference implementation with compcert. fbe3c19cf5 cleanup: correct a few nullable annotations 623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. c71567dc18 fix: Pass array, not array pointer, to `memcmp`. 9b46a08144 cleanup: Never pass `void*` directly to `memcpy`. 5d7b7a7bbc refactor: Use tox rng to seed the keypair generation. 961891d568 cleanup: Small improvements found by PVS Studio. 8201019f0d chore: Disable NGC saving by default, enable through Tox_Options. 5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`. ca4606d49d refactor: Use strong typedef for NGC peer id. 442213b722 cleanup: Simplify custom packet length check in NGC. 08d3393def fix: Correct a few potential null derefs in bootstrap daemon. b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope. dab5fe44b9 fix: Zero out stack-allocated secret key before return. f058103299 refactor: Make prune_gc_sanctions_list more obviously correct. 3ba7a0dec9 docs: Add static analysis tool list to README. 8d0811a0f3 docs: Run prettier-markdown on markdown files. 969e3a2bfc refactor: Fix network test not using the strong typedef 93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`. 9fe18b176f fix: Fix some false positive from PVS Studio. 7c44379ccb cleanup: Check that WINXP macro exists before comparing it. 5c93231bef refactor: Make tox mutex non-recursive. aacff73939 docs: Fix up doxyfile. d55fc85ff5 docs: Add more documentation to crypto_core. 5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`. e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests. 34df938f52 chore: Use C++ mode for clang-tidy. 8b05296a78 chore: Check that both gtest and gmock exist for tests. 42010660e1 test: Add slimcc compiler compatibility test. b473630321 chore: Add some comments to the astyle config. b7404f24f6 cleanup: Remove implicit bool conversions. 4e2dba4d9f chore: Reformat sources with astyle. 4359e3a6bc chore: Rename C++ headers to .hh suffixes. 0c05566e58 cleanup: Further `#include` cleanups. 8d29935b7a chore: Only check the bootstrap daemon checksum on release. f70e588bc6 cleanup: Add more `const` where possible. 511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene. 1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module. a975943564 chore: Really fix coverage docker image build. c08409390f chore: Fix post-submit coverage image. 39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s. d94246a906 fix: partially fix a bug that prevented group part messages from sending. eeaa039222 chore: Fix rpm build; add a CI check for it. 8328449c1a chore: Speed up docker builds a bit by reducing layer count. d6d67d56f3 cleanup: Add `const` where possible in auto tests. 6aa9e6850d cleanup: Minor cleanup of event unpack code. bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`. 203e1af81e fix: a few off by one errors in group autotests 5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`. 662c2140f3 test: Add goblint static analyser. 8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`. a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`. 6370d0f15d cleanup: Expand the `Tox_Options` accessor macros. 14a1a0b9bd cleanup: Remove plan9 support. a05dccad13 test: Add a simple new/delete test for Tox. 1cdcf938b9 cleanup: Add comment after every `#endif`. ba99d4dc4b test: Fix comment I broke in the events test PR. e07248debb refactor: Migrate auto_tests to new events API. bdd42b5452 refactor: Add common msgpack array packer with callback. 3c659f5288 cleanup: Rename group to conference in groupav documentation. 89957be230 cleanup: Ensure handler params are named after callback params. c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks. e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events. 5e2c8cabc1 cleanup: make some improvements to group moderation test 259de4867e cleanup: Remove `bin_pack_{new,free}`. 21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion 16809dc36e feat: Add dht_get_nodes_response event to the events system. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
284 lines
8.9 KiB
C++
284 lines
8.9 KiB
C++
#include "group_announce.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "DHT.h"
|
|
#include "crypto_core.h"
|
|
#include "logger.h"
|
|
#include "mem_test_util.hh"
|
|
#include "mono_time.h"
|
|
#include "network.h"
|
|
|
|
namespace {
|
|
|
|
struct Announces : ::testing::Test {
|
|
protected:
|
|
Test_Memory mem_;
|
|
uint64_t clock_ = 1000;
|
|
Mono_Time *mono_time_ = nullptr;
|
|
GC_Announces_List *gca_ = nullptr;
|
|
GC_Announce _ann1;
|
|
GC_Announce _ann2;
|
|
|
|
void SetUp() override
|
|
{
|
|
mono_time_ = mono_time_new(mem_, nullptr, nullptr);
|
|
ASSERT_NE(mono_time_, nullptr);
|
|
mono_time_set_current_time_callback(
|
|
mono_time_, [](void *user_data) { return *static_cast<uint64_t *>(user_data); },
|
|
&clock_);
|
|
gca_ = new_gca_list();
|
|
ASSERT_NE(gca_, nullptr);
|
|
}
|
|
|
|
~Announces() override
|
|
{
|
|
kill_gca(gca_);
|
|
mono_time_free(mem_, mono_time_);
|
|
}
|
|
|
|
void advance_clock(uint64_t increment)
|
|
{
|
|
clock_ += increment;
|
|
mono_time_update(mono_time_);
|
|
}
|
|
};
|
|
|
|
TEST_F(Announces, KillGcaOnNullptrIsNoop)
|
|
{
|
|
// All kill functions should be nullable.
|
|
kill_gca(nullptr);
|
|
}
|
|
|
|
TEST_F(Announces, CanBeCreatedAndDeleted)
|
|
{
|
|
GC_Public_Announce ann{};
|
|
ann.chat_public_key[0] = 0x88;
|
|
ASSERT_NE(gca_add_announce(mono_time_, gca_, &ann), nullptr);
|
|
#ifndef _DEBUG
|
|
ASSERT_EQ(gca_add_announce(mono_time_, gca_, nullptr), nullptr);
|
|
ASSERT_EQ(gca_add_announce(mono_time_, nullptr, &ann), nullptr);
|
|
#endif
|
|
}
|
|
|
|
TEST_F(Announces, AnnouncesCanTimeOut)
|
|
{
|
|
advance_clock(100);
|
|
ASSERT_EQ(gca_->root_announces, nullptr);
|
|
GC_Public_Announce ann{};
|
|
ann.chat_public_key[0] = 0xae;
|
|
ASSERT_NE(gca_add_announce(mono_time_, gca_, &ann), nullptr);
|
|
ASSERT_NE(gca_->root_announces, nullptr);
|
|
ASSERT_EQ(gca_->root_announces->chat_id[0], 0xae);
|
|
|
|
// One iteration without having any time passed => announce is still here.
|
|
do_gca(mono_time_, gca_);
|
|
ASSERT_NE(gca_->root_announces, nullptr);
|
|
|
|
// 29 seconds later, still there
|
|
advance_clock(29000);
|
|
do_gca(mono_time_, gca_);
|
|
ASSERT_NE(gca_->root_announces, nullptr);
|
|
|
|
// One more second and it's gone.
|
|
advance_clock(1000);
|
|
do_gca(mono_time_, gca_);
|
|
ASSERT_EQ(gca_->root_announces, nullptr);
|
|
}
|
|
|
|
TEST_F(Announces, AnnouncesGetAndCleanup)
|
|
{
|
|
GC_Public_Announce ann1{};
|
|
GC_Public_Announce ann2{};
|
|
ann1.chat_public_key[0] = 0x91;
|
|
ann1.base_announce.peer_public_key[0] = 0x7f;
|
|
ann2.chat_public_key[0] = 0x92;
|
|
ann2.base_announce.peer_public_key[0] = 0x7c;
|
|
|
|
ASSERT_NE(gca_add_announce(mono_time_, gca_, &ann1), nullptr);
|
|
ASSERT_NE(gca_add_announce(mono_time_, gca_, &ann2), nullptr);
|
|
ASSERT_NE(gca_add_announce(mono_time_, gca_, &ann2), nullptr);
|
|
|
|
uint8_t empty_pk[ENC_PUBLIC_KEY_SIZE] = {0};
|
|
|
|
GC_Announce announces;
|
|
ASSERT_EQ(gca_get_announces(gca_, &announces, 1, ann1.chat_public_key, empty_pk), 1);
|
|
ASSERT_EQ(gca_get_announces(gca_, &announces, 1, ann2.chat_public_key, empty_pk), 1);
|
|
|
|
cleanup_gca(gca_, ann1.chat_public_key);
|
|
ASSERT_EQ(gca_get_announces(gca_, &announces, 1, ann1.chat_public_key, empty_pk), 0);
|
|
|
|
cleanup_gca(gca_, ann2.chat_public_key);
|
|
ASSERT_EQ(gca_get_announces(gca_, &announces, 1, ann2.chat_public_key, empty_pk), 0);
|
|
#ifndef _DEBUG
|
|
ASSERT_EQ(gca_get_announces(gca_, nullptr, 1, ann2.chat_public_key, empty_pk), -1);
|
|
#endif
|
|
}
|
|
|
|
struct AnnouncesPack : ::testing::Test {
|
|
protected:
|
|
std::vector<GC_Announce> announces_;
|
|
Logger *logger_ = nullptr;
|
|
|
|
void SetUp() override
|
|
{
|
|
logger_ = logger_new();
|
|
ASSERT_NE(logger_, nullptr);
|
|
|
|
// Add an announce without TCP relay.
|
|
announces_.emplace_back();
|
|
auto &ann1 = announces_.back();
|
|
|
|
ann1.peer_public_key[0] = 0xae;
|
|
ann1.ip_port.ip.family = net_family_ipv4();
|
|
ann1.ip_port.ip.ip.v4.uint8[0] = 0x7f; // 127.0.0.1
|
|
ann1.ip_port.ip.ip.v4.uint8[3] = 0x1;
|
|
ann1.ip_port_is_set = 1;
|
|
|
|
// Add an announce with TCP relay.
|
|
announces_.emplace_back();
|
|
auto &ann2 = announces_.back();
|
|
|
|
ann2.peer_public_key[0] = 0xaf; // different key
|
|
ann2.ip_port.ip.family = net_family_ipv4();
|
|
ann2.ip_port.ip.ip.v4.uint8[0] = 0x7f; // 127.0.0.2
|
|
ann2.ip_port.ip.ip.v4.uint8[3] = 0x2;
|
|
ann2.ip_port_is_set = 1;
|
|
ann2.tcp_relays_count = 1;
|
|
ann2.tcp_relays[0].ip_port.ip.family = net_family_ipv4();
|
|
ann2.tcp_relays[0].ip_port.ip.ip.v4 = get_ip4_broadcast();
|
|
ann2.tcp_relays[0].public_key[0] = 0xea;
|
|
}
|
|
|
|
~AnnouncesPack() override { logger_kill(logger_); }
|
|
};
|
|
|
|
TEST_F(AnnouncesPack, PublicAnnounceCanBePackedAndUnpacked)
|
|
{
|
|
GC_Public_Announce ann{};
|
|
ann.chat_public_key[0] = 0x88;
|
|
ann.base_announce = announces_[0];
|
|
|
|
std::vector<uint8_t> packed(GCA_PUBLIC_ANNOUNCE_MAX_SIZE);
|
|
const int packed_size = gca_pack_public_announce(logger_, packed.data(), packed.size(), &ann);
|
|
|
|
EXPECT_GT(packed_size, 0);
|
|
|
|
GC_Public_Announce unpacked_ann{};
|
|
EXPECT_EQ(gca_unpack_public_announce(logger_, packed.data(), packed.size(), &unpacked_ann),
|
|
packed_size);
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, UnpackEmptyPublicAnnounce)
|
|
{
|
|
#ifndef _DEBUG
|
|
GC_Public_Announce ann{};
|
|
std::vector<uint8_t> packed(GCA_PUBLIC_ANNOUNCE_MAX_SIZE);
|
|
|
|
EXPECT_EQ(gca_unpack_public_announce(logger_, nullptr, 0, &ann), -1);
|
|
EXPECT_EQ(gca_unpack_public_announce(logger_, packed.data(), packed.size(), nullptr), -1);
|
|
#endif
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, PackEmptyPublicAnnounce)
|
|
{
|
|
#ifndef _DEBUG
|
|
GC_Public_Announce ann{};
|
|
std::vector<uint8_t> packed(GCA_PUBLIC_ANNOUNCE_MAX_SIZE);
|
|
EXPECT_EQ(gca_pack_public_announce(logger_, packed.data(), packed.size(), nullptr), -1);
|
|
EXPECT_EQ(gca_pack_public_announce(logger_, nullptr, 0, &ann), -1);
|
|
#endif
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, PublicAnnouncePackNull)
|
|
{
|
|
GC_Public_Announce ann{};
|
|
std::vector<uint8_t> packed(GCA_PUBLIC_ANNOUNCE_MAX_SIZE);
|
|
EXPECT_EQ(gca_pack_public_announce(logger_, packed.data(), packed.size(), &ann), -1);
|
|
|
|
ann.chat_public_key[0] = 0x88;
|
|
ann.base_announce = announces_[0];
|
|
|
|
std::vector<uint8_t> packedTooSmall(GCA_PUBLIC_ANNOUNCE_MAX_SIZE - 1);
|
|
EXPECT_EQ(
|
|
gca_pack_public_announce(logger_, packedTooSmall.data(), packedTooSmall.size(), &ann), -1);
|
|
|
|
ann.base_announce.ip_port_is_set = 0;
|
|
ann.base_announce.tcp_relays_count = 0;
|
|
|
|
EXPECT_EQ(gca_pack_public_announce(logger_, packed.data(), packed.size(), &ann), -1);
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, AnnouncesValidationCheck)
|
|
{
|
|
#ifndef _DEBUG
|
|
EXPECT_EQ(gca_is_valid_announce(nullptr), false);
|
|
#endif
|
|
|
|
GC_Announce announce = {0};
|
|
EXPECT_EQ(gca_is_valid_announce(&announce), false);
|
|
EXPECT_EQ(gca_is_valid_announce(&announces_[0]), true);
|
|
EXPECT_EQ(gca_is_valid_announce(&announces_[1]), true);
|
|
announces_[0].ip_port_is_set = 0;
|
|
announces_[0].tcp_relays_count = 0;
|
|
EXPECT_EQ(gca_is_valid_announce(&announces_[0]), false);
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, UnpackIncompleteAnnouncesList)
|
|
{
|
|
const uint8_t data[] = {0x00, 0x24, 0x3d, 0x00, 0x3d, 0xff, 0xff, 0x5b, 0x04, 0x20, 0x00, 0x01,
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00};
|
|
|
|
GC_Announce announce;
|
|
EXPECT_EQ(gca_unpack_announces_list(logger_, data, sizeof(data), &announce, 1), -1);
|
|
#ifndef _DEBUG
|
|
EXPECT_EQ(gca_unpack_announces_list(logger_, data, sizeof(data), nullptr, 1), -1);
|
|
EXPECT_EQ(gca_unpack_announces_list(logger_, nullptr, 0, &announce, 1), -1);
|
|
#endif
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, PackedAnnouncesListCanBeUnpacked)
|
|
{
|
|
const uint16_t size = gca_pack_announces_list_size(announces_.size());
|
|
std::vector<uint8_t> packed(size);
|
|
|
|
size_t processed = 0;
|
|
|
|
EXPECT_GT(gca_pack_announces_list(logger_, packed.data(), packed.size(), announces_.data(),
|
|
announces_.size(), &processed),
|
|
0);
|
|
ASSERT_GE(processed, ENC_PUBLIC_KEY_SIZE + 2);
|
|
ASSERT_LE(processed, size);
|
|
|
|
std::vector<GC_Announce> announces_unpacked(announces_.size());
|
|
ASSERT_EQ(gca_unpack_announces_list(logger_, packed.data(), packed.size(),
|
|
announces_unpacked.data(), announces_unpacked.size()),
|
|
announces_unpacked.size());
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, PackingEmptyAnnounceFails)
|
|
{
|
|
GC_Announce announce{}; // all zeroes
|
|
std::vector<uint8_t> packed(gca_pack_announces_list_size(1));
|
|
EXPECT_EQ(
|
|
gca_pack_announces_list(logger_, packed.data(), packed.size(), &announce, 1, nullptr), -1);
|
|
#ifndef _DEBUG
|
|
EXPECT_EQ(
|
|
gca_pack_announces_list(logger_, packed.data(), packed.size(), nullptr, 1, nullptr), -1);
|
|
EXPECT_EQ(gca_pack_announces_list(logger_, nullptr, 0, &announce, 1, nullptr), -1);
|
|
#endif
|
|
}
|
|
|
|
TEST_F(AnnouncesPack, PackAnnounceNull)
|
|
{
|
|
#ifndef _DEBUG
|
|
std::vector<uint8_t> data(GCA_ANNOUNCE_MAX_SIZE);
|
|
GC_Announce announce;
|
|
ASSERT_EQ(gca_pack_announce(logger_, nullptr, 0, &announce), -1);
|
|
ASSERT_EQ(gca_pack_announce(logger_, data.data(), data.size(), nullptr), -1);
|
|
#endif
|
|
}
|
|
|
|
} // namespace
|