Green Sky
aae086cc65
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to. 32e67ab4c2 cleanup: use typedef for private message ID's in callback 7b1db6adc1 feat: add message IDs to private group messages 99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests e742deddff feat: Check hashes of Windows dependencies when cross-compiling dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image 14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes ed37616249 docs: Update the Windows cross-compilation section 9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies 19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows 1be311e51f feat: Build the fun utils when cross-compiling to Windows 88133f8446 chore: Strip Windows binaries 3cc0ae7535 refactor: Copy over all of the required static dependencies c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows 74bbac5363 feat: Let CMake create the dll instead of doing so ourselves 246642e9ae feat: Harden Windows cross-compilation 8d431c0d11 chore: Bump Windows build dependency versions e519f7998b fix: Remove unnecessary wsock32 dependency on Windows ed2b60c217 chore: Use a specific non-broken slimcc version. d7f21010a1 chore: Update github actions. e71a68b7f2 docs: Update the list of CMake options 77e08876ff chore: Remove mod and founder from group API naming scheme 12bc042767 docs: add the experimental api build option to INSTALL.md e1fa5cae96 refactor: Rename Queries to Query to align with other enums. be82a3ea30 fix: Correct type for conference offline peer numbers. 0627c36716 test: Add pkgsrc build. 92578afe4b test: Add FreeBSD VM action on GitHub. 52ece0f57b test: Build toxcore on NetBSD (VM). 3fe8ee2c11 chore: Only install tox_private.h on request. 9a8dfa06ab fix: save_compatibility_test failing on big-endian systems 86f5e55578 fix: Don't serve files from websockify. 710eb674a5 fix: Correctly pass extended public keys to group moderation code. 021db7031c refactor: Use `struct`s for extended public/secret keys. a1e999fd80 chore: Compile libsodium reference implementation with compcert. fbe3c19cf5 cleanup: correct a few nullable annotations 623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. c71567dc18 fix: Pass array, not array pointer, to `memcmp`. 9b46a08144 cleanup: Never pass `void*` directly to `memcpy`. 5d7b7a7bbc refactor: Use tox rng to seed the keypair generation. 961891d568 cleanup: Small improvements found by PVS Studio. 8201019f0d chore: Disable NGC saving by default, enable through Tox_Options. 5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`. ca4606d49d refactor: Use strong typedef for NGC peer id. 442213b722 cleanup: Simplify custom packet length check in NGC. 08d3393def fix: Correct a few potential null derefs in bootstrap daemon. b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope. dab5fe44b9 fix: Zero out stack-allocated secret key before return. f058103299 refactor: Make prune_gc_sanctions_list more obviously correct. 3ba7a0dec9 docs: Add static analysis tool list to README. 8d0811a0f3 docs: Run prettier-markdown on markdown files. 969e3a2bfc refactor: Fix network test not using the strong typedef 93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`. 9fe18b176f fix: Fix some false positive from PVS Studio. 7c44379ccb cleanup: Check that WINXP macro exists before comparing it. 5c93231bef refactor: Make tox mutex non-recursive. aacff73939 docs: Fix up doxyfile. d55fc85ff5 docs: Add more documentation to crypto_core. 5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`. e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests. 34df938f52 chore: Use C++ mode for clang-tidy. 8b05296a78 chore: Check that both gtest and gmock exist for tests. 42010660e1 test: Add slimcc compiler compatibility test. b473630321 chore: Add some comments to the astyle config. b7404f24f6 cleanup: Remove implicit bool conversions. 4e2dba4d9f chore: Reformat sources with astyle. 4359e3a6bc chore: Rename C++ headers to .hh suffixes. 0c05566e58 cleanup: Further `#include` cleanups. 8d29935b7a chore: Only check the bootstrap daemon checksum on release. f70e588bc6 cleanup: Add more `const` where possible. 511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene. 1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module. a975943564 chore: Really fix coverage docker image build. c08409390f chore: Fix post-submit coverage image. 39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s. d94246a906 fix: partially fix a bug that prevented group part messages from sending. eeaa039222 chore: Fix rpm build; add a CI check for it. 8328449c1a chore: Speed up docker builds a bit by reducing layer count. d6d67d56f3 cleanup: Add `const` where possible in auto tests. 6aa9e6850d cleanup: Minor cleanup of event unpack code. bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`. 203e1af81e fix: a few off by one errors in group autotests 5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`. 662c2140f3 test: Add goblint static analyser. 8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`. a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`. 6370d0f15d cleanup: Expand the `Tox_Options` accessor macros. 14a1a0b9bd cleanup: Remove plan9 support. a05dccad13 test: Add a simple new/delete test for Tox. 1cdcf938b9 cleanup: Add comment after every `#endif`. ba99d4dc4b test: Fix comment I broke in the events test PR. e07248debb refactor: Migrate auto_tests to new events API. bdd42b5452 refactor: Add common msgpack array packer with callback. 3c659f5288 cleanup: Rename group to conference in groupav documentation. 89957be230 cleanup: Ensure handler params are named after callback params. c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks. e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events. 5e2c8cabc1 cleanup: make some improvements to group moderation test 259de4867e cleanup: Remove `bin_pack_{new,free}`. 21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion 16809dc36e feat: Add dht_get_nodes_response event to the events system. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
260 lines
8.2 KiB
C
260 lines
8.2 KiB
C
/*
|
|
* Does a basic functionality test for TCP connections.
|
|
*/
|
|
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
|
|
#include "auto_test_support.h"
|
|
|
|
#define NUM_GROUP_TOXES 2
|
|
#define CODEWORD "RONALD MCDONALD"
|
|
#define CODEWORD_LEN (sizeof(CODEWORD) - 1)
|
|
|
|
typedef struct State {
|
|
size_t num_peers;
|
|
bool got_code;
|
|
bool got_second_code;
|
|
uint32_t peer_id[NUM_GROUP_TOXES - 1];
|
|
} State;
|
|
|
|
static void group_invite_handler(const Tox_Event_Group_Invite *event, void *user_data)
|
|
{
|
|
AutoTox *autotox = (AutoTox *)user_data;
|
|
ck_assert(autotox != nullptr);
|
|
|
|
const uint32_t friend_number = tox_event_group_invite_get_friend_number(event);
|
|
const uint8_t *invite_data = tox_event_group_invite_get_invite_data(event);
|
|
const size_t length = tox_event_group_invite_get_invite_data_length(event);
|
|
|
|
printf("Accepting friend invite\n");
|
|
|
|
Tox_Err_Group_Invite_Accept err_accept;
|
|
tox_group_invite_accept(autotox->tox, friend_number, invite_data, length, (const uint8_t *)"test", 4,
|
|
nullptr, 0, &err_accept);
|
|
ck_assert(err_accept == TOX_ERR_GROUP_INVITE_ACCEPT_OK);
|
|
}
|
|
|
|
static void group_peer_join_handler(const Tox_Event_Group_Peer_Join *event, void *user_data)
|
|
{
|
|
AutoTox *autotox = (AutoTox *)user_data;
|
|
ck_assert(autotox != nullptr);
|
|
|
|
State *state = (State *)autotox->state;
|
|
|
|
const uint32_t peer_id = tox_event_group_peer_join_get_peer_id(event);
|
|
|
|
fprintf(stderr, "joined: %zu, %u\n", state->num_peers, peer_id);
|
|
ck_assert_msg(state->num_peers < NUM_GROUP_TOXES - 1, "%zu", state->num_peers);
|
|
|
|
state->peer_id[state->num_peers++] = peer_id;
|
|
}
|
|
|
|
static void group_private_message_handler(const Tox_Event_Group_Private_Message *event, void *user_data)
|
|
{
|
|
const uint8_t *message = tox_event_group_private_message_get_message(event);
|
|
const size_t length = tox_event_group_private_message_get_message_length(event);
|
|
|
|
AutoTox *autotox = (AutoTox *)user_data;
|
|
ck_assert(autotox != nullptr);
|
|
|
|
State *state = (State *)autotox->state;
|
|
|
|
ck_assert(length == CODEWORD_LEN);
|
|
ck_assert(memcmp(CODEWORD, message, length) == 0);
|
|
|
|
printf("Codeword: %s\n", CODEWORD);
|
|
|
|
state->got_code = true;
|
|
}
|
|
|
|
static void group_message_handler(const Tox_Event_Group_Message *event, void *user_data)
|
|
{
|
|
const uint8_t *message = tox_event_group_message_get_message(event);
|
|
const size_t length = tox_event_group_message_get_message_length(event);
|
|
|
|
AutoTox *autotox = (AutoTox *)user_data;
|
|
ck_assert(autotox != nullptr);
|
|
|
|
State *state = (State *)autotox->state;
|
|
|
|
ck_assert(length == CODEWORD_LEN);
|
|
ck_assert(memcmp(CODEWORD, message, length) == 0);
|
|
|
|
printf("Codeword: %s\n", CODEWORD);
|
|
|
|
state->got_second_code = true;
|
|
}
|
|
|
|
/*
|
|
* We need different constants to make TCP run smoothly. TODO(Jfreegman): is this because of the group
|
|
* implementation or just an autotest quirk?
|
|
*/
|
|
#define GROUP_ITERATION_INTERVAL 100
|
|
static void iterate_group(AutoTox *autotoxes, uint32_t num_toxes, size_t interval)
|
|
{
|
|
for (uint32_t i = 0; i < num_toxes; i++) {
|
|
if (autotoxes[i].alive) {
|
|
tox_iterate(autotoxes[i].tox, &autotoxes[i]);
|
|
autotoxes[i].clock += interval;
|
|
}
|
|
}
|
|
|
|
c_sleep(50);
|
|
}
|
|
|
|
static bool all_peers_connected(AutoTox *autotoxes)
|
|
{
|
|
iterate_group(autotoxes, NUM_GROUP_TOXES, GROUP_ITERATION_INTERVAL);
|
|
|
|
size_t count = 0;
|
|
|
|
for (size_t i = 0; i < NUM_GROUP_TOXES; ++i) {
|
|
const State *state = (const State *)autotoxes[i].state;
|
|
|
|
if (state->num_peers == NUM_GROUP_TOXES - 1) {
|
|
++count;
|
|
}
|
|
}
|
|
|
|
return count == NUM_GROUP_TOXES;
|
|
}
|
|
|
|
static bool all_peers_got_code(AutoTox *autotoxes)
|
|
{
|
|
iterate_group(autotoxes, NUM_GROUP_TOXES, GROUP_ITERATION_INTERVAL);
|
|
|
|
size_t count = 0;
|
|
|
|
for (size_t i = 0; i < NUM_GROUP_TOXES; ++i) {
|
|
const State *state = (const State *)autotoxes[i].state;
|
|
|
|
if (state->got_code) {
|
|
++count;
|
|
}
|
|
}
|
|
|
|
return count == NUM_GROUP_TOXES - 1;
|
|
}
|
|
|
|
static void group_tcp_test(AutoTox *autotoxes)
|
|
{
|
|
ck_assert(NUM_GROUP_TOXES >= 2);
|
|
|
|
State *state0 = (State *)autotoxes[0].state;
|
|
State *state1 = (State *)autotoxes[1].state;
|
|
|
|
for (size_t i = 0; i < NUM_GROUP_TOXES; ++i) {
|
|
tox_events_callback_group_peer_join(autotoxes[i].dispatch, group_peer_join_handler);
|
|
tox_events_callback_group_private_message(autotoxes[i].dispatch, group_private_message_handler);
|
|
}
|
|
|
|
tox_events_callback_group_message(autotoxes[1].dispatch, group_message_handler);
|
|
tox_events_callback_group_invite(autotoxes[1].dispatch, group_invite_handler);
|
|
|
|
Tox_Err_Group_New new_err;
|
|
uint32_t groupnumber = tox_group_new(autotoxes[0].tox, TOX_GROUP_PRIVACY_STATE_PUBLIC, (const uint8_t *)"test", 4,
|
|
(const uint8_t *)"test", 4, &new_err);
|
|
ck_assert_msg(new_err == TOX_ERR_GROUP_NEW_OK, "tox_group_new failed: %d", new_err);
|
|
|
|
iterate_group(autotoxes, NUM_GROUP_TOXES, GROUP_ITERATION_INTERVAL);
|
|
|
|
Tox_Err_Group_State_Query id_err;
|
|
uint8_t chat_id[TOX_GROUP_CHAT_ID_SIZE];
|
|
|
|
tox_group_get_chat_id(autotoxes[0].tox, groupnumber, chat_id, &id_err);
|
|
ck_assert_msg(id_err == TOX_ERR_GROUP_STATE_QUERY_OK, "%d", id_err);
|
|
|
|
printf("Tox 0 created new group...\n");
|
|
|
|
for (size_t i = 1; i < NUM_GROUP_TOXES; ++i) {
|
|
Tox_Err_Group_Join jerr;
|
|
tox_group_join(autotoxes[i].tox, chat_id, (const uint8_t *)"test", 4, nullptr, 0, &jerr);
|
|
ck_assert_msg(jerr == TOX_ERR_GROUP_JOIN_OK, "%d", jerr);
|
|
iterate_group(autotoxes, NUM_GROUP_TOXES, GROUP_ITERATION_INTERVAL * 10);
|
|
}
|
|
|
|
while (!all_peers_connected(autotoxes))
|
|
;
|
|
|
|
printf("%d peers successfully joined. Waiting for code...\n", NUM_GROUP_TOXES);
|
|
printf("Tox 0 sending secret code to all peers\n");
|
|
|
|
for (size_t i = 0; i < NUM_GROUP_TOXES - 1; ++i) {
|
|
|
|
Tox_Err_Group_Send_Private_Message perr;
|
|
tox_group_send_private_message(autotoxes[0].tox, groupnumber, state0->peer_id[i],
|
|
TOX_MESSAGE_TYPE_NORMAL,
|
|
(const uint8_t *)CODEWORD, CODEWORD_LEN, &perr);
|
|
ck_assert_msg(perr == TOX_ERR_GROUP_SEND_PRIVATE_MESSAGE_OK, "%d", perr);
|
|
}
|
|
|
|
while (!all_peers_got_code(autotoxes))
|
|
;
|
|
|
|
Tox_Err_Group_Leave err_exit;
|
|
tox_group_leave(autotoxes[1].tox, groupnumber, nullptr, 0, &err_exit);
|
|
ck_assert(err_exit == TOX_ERR_GROUP_LEAVE_OK);
|
|
|
|
iterate_group(autotoxes, NUM_GROUP_TOXES, GROUP_ITERATION_INTERVAL);
|
|
|
|
state0->num_peers = 0;
|
|
state1->num_peers = 0;
|
|
|
|
// now do a friend invite to make sure the TCP-specific logic for friend invites is okay
|
|
|
|
printf("Tox1 leaves group and Tox0 does a friend group invite for tox1\n");
|
|
|
|
Tox_Err_Group_Invite_Friend err_invite;
|
|
tox_group_invite_friend(autotoxes[0].tox, groupnumber, 0, &err_invite);
|
|
ck_assert(err_invite == TOX_ERR_GROUP_INVITE_FRIEND_OK);
|
|
|
|
while (state0->num_peers == 0 && state1->num_peers == 0) {
|
|
iterate_group(autotoxes, NUM_GROUP_TOXES, GROUP_ITERATION_INTERVAL);
|
|
}
|
|
|
|
printf("Tox 1 successfully joined. Waiting for code...\n");
|
|
|
|
Tox_Err_Group_Send_Message merr;
|
|
tox_group_send_message(autotoxes[0].tox, groupnumber, TOX_MESSAGE_TYPE_NORMAL,
|
|
(const uint8_t *)CODEWORD, CODEWORD_LEN, &merr);
|
|
ck_assert(merr == TOX_ERR_GROUP_SEND_MESSAGE_OK);
|
|
|
|
while (!state1->got_second_code) {
|
|
iterate_group(autotoxes, NUM_GROUP_TOXES, GROUP_ITERATION_INTERVAL);
|
|
}
|
|
|
|
for (size_t i = 0; i < NUM_GROUP_TOXES; i++) {
|
|
tox_group_leave(autotoxes[i].tox, groupnumber, nullptr, 0, &err_exit);
|
|
ck_assert(err_exit == TOX_ERR_GROUP_LEAVE_OK);
|
|
}
|
|
|
|
printf("Test passed!\n");
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
setvbuf(stdout, nullptr, _IONBF, 0);
|
|
|
|
struct Tox_Options *options = tox_options_new(nullptr);
|
|
ck_assert(options != nullptr);
|
|
|
|
tox_options_set_udp_enabled(options, false);
|
|
|
|
Run_Auto_Options autotest_opts = default_run_auto_options();
|
|
autotest_opts.graph = GRAPH_COMPLETE;
|
|
|
|
// TODO(JFreegman): Fix this test and remove the "if".
|
|
if (argc > 2) {
|
|
run_auto_test(options, NUM_GROUP_TOXES, group_tcp_test, sizeof(State), &autotest_opts);
|
|
}
|
|
|
|
tox_options_free(options);
|
|
return 0;
|
|
}
|
|
|
|
#undef CODEWORD_LEN
|
|
#undef CODEWORD
|
|
#undef NUM_GROUP_TOXES
|