Green Sky
9ddeea3d06
adbd5b32d8 feat: add ngc events 15ee46d431 add simple test for max sized lossy custom group packet 01e7950c67 increase lossy custom packet size in ngc to the toxcore common max of 1373 9b3c1089f1 Make group saving/loading more forgiving with data errors 55a76003b0 Replace memset(int32_t*, -1, _) with a for-loop 66453439ac fix: also Install header for private/experimental API functions with autotools 3983369103 fix: Enable debug flag for ubsan. 4d1db21102 Update tox-boostrapd hash e700c31b70 Fix memory leak in group connection 2994441d9c Fix memory leak in save-generator d0400df13d Fix memory leak in tox-bootstrapd 7a6d50ebe3 Install header for private/experimental API functions d89677fb5f Remove defunct IRC channel from README.md 26d41fc604 Replace DEFAULT_TCP_RELAY_PORTS_COUNT with a compile-time calculation 63fb2941ca Clarify disabling of static assert checks 65b3375b98 refactor: Use Bin_Pack for packing Node_format. 84ba154f6a group connection queries now return our own connection type a4df2862ed Replace tabs with spaces 1b6dee7594 Update tox-bootstrapd's base Docker images a030cdee5c Fix Docker tox-bootstrapd hash update failing when using BuildKit 7cfe35dff2 cleanup: Remove explicit layering_check feature. d390947245 chore: Upgrade sonar-scan jvm to java 17. d1e850c56c fix: Add missing `htons` call when adding configured TCP relay. 814090f2b8 chore: Cancel old PR builds on docker and sonar-scan workflows. 83efb17367 perf: Add a KVM FreeBSD build on cirrus ci. a927183233 test: Add a test for encrypting 100MB of data. 28f39049f6 chore: Retry freebsd tests 2 times. 47e77d1bb0 chore: Use C99 on MSVC instead of C11. 7155f7f60e test: Add an s390x build (on alpine) for CI. 6c35cef63f chore: Add a compcert docker run script. 41e6ea865e cleanup: Use tcc docker image for CI. e726b197b0 refactor: Store time in Mono_Time in milliseconds. REVERT: d4b06edc2a feat: add ngc events git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: adbd5b32d85d9c13800f5ece17c0a9dce99faacd
145 lines
5.1 KiB
Bash
Executable File
145 lines
5.1 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
CHECKS="*"
|
|
|
|
# We don't use memcpy_s.
|
|
CHECKS="$CHECKS,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling"
|
|
|
|
# __attribute__((nonnull)) causes this warning on defensive null checks.
|
|
CHECKS="$CHECKS,-clang-diagnostic-pointer-bool-conversion"
|
|
CHECKS="$CHECKS,-clang-diagnostic-tautological-pointer-compare"
|
|
|
|
# Conflicts with "Variable is assigned a value that is never used."
|
|
# [unreadVariable]
|
|
CHECKS="$CHECKS,-cppcoreguidelines-init-variables"
|
|
|
|
# Short variable names are used quite a lot, and we don't consider them a
|
|
# readability issue.
|
|
CHECKS="$CHECKS,-readability-identifier-length"
|
|
|
|
# Altera checks are for GPUs (OpenCL). Our code doesn't run on GPUs.
|
|
CHECKS="$CHECKS,-altera-id-dependent-backward-branch"
|
|
CHECKS="$CHECKS,-altera-struct-pack-align"
|
|
CHECKS="$CHECKS,-altera-unroll-loops"
|
|
|
|
# We target systems other than Android, so we don't want to use non-standard
|
|
# functions from the Android libc.
|
|
CHECKS="$CHECKS,-android-cloexec-accept"
|
|
CHECKS="$CHECKS,-android-cloexec-fopen"
|
|
|
|
# This catches all the feature test macros (_POSIX_SOURCE etc.).
|
|
CHECKS="$CHECKS,-bugprone-reserved-identifier"
|
|
CHECKS="$CHECKS,-cert-dcl37-c"
|
|
CHECKS="$CHECKS,-cert-dcl51-cpp"
|
|
|
|
# Too restrictive. This makes sense if the branch clone is very large, but not
|
|
# if it's a single line. It can make the code less readable.
|
|
CHECKS="$CHECKS,-bugprone-branch-clone"
|
|
|
|
# We intentionally send some not null-terminated strings in tests and use it for
|
|
# the toxencryptsave magic number.
|
|
CHECKS="$CHECKS,-bugprone-not-null-terminated-result"
|
|
|
|
# We don't want default labels in enum switches.
|
|
CHECKS="$CHECKS,-hicpp-multiway-paths-covered"
|
|
|
|
# This can make readability quite a bit worse when the 2 cases look very
|
|
# similar.
|
|
CHECKS="$CHECKS,-llvm-else-after-return"
|
|
CHECKS="$CHECKS,-readability-else-after-return"
|
|
|
|
# We need 'return;' in empty functions because cimple won't allow empty
|
|
# functions otherwise.
|
|
CHECKS="$CHECKS,-readability-redundant-control-flow"
|
|
|
|
# These are incredibly annoying, because things like
|
|
# uint16_t a = 0, b = 1, c = a > b ? a : b;
|
|
# ^
|
|
# Trip the checker, which is true, because of integer promotion, but also not
|
|
# very helpful as a diagnostic.
|
|
CHECKS="$CHECKS,-bugprone-narrowing-conversions"
|
|
CHECKS="$CHECKS,-cppcoreguidelines-narrowing-conversions"
|
|
|
|
# Mistakenly thinks that
|
|
# const int a = 0, b = 1;
|
|
# assert(a < b);
|
|
# is a constant expression in C (it is in C++ though, which is probably why it's
|
|
# mistaken), suggesting to replace 'assert()' with 'static_assert()' in cases
|
|
# where that won't work.
|
|
#
|
|
# There are ways to make 'static_assert()' work, but they are rather annoying --
|
|
# they are somewhat ugly, hurting the readability, and some are error-prone:
|
|
#
|
|
# - Turning 'a' and 'b' into enum constants would make it work, but this falls
|
|
# apart if the enum types are compared against non-enums down the line
|
|
# error: enumerated and non-enumerated type in conditional expression [-Werror=extra]
|
|
#
|
|
# - Turning 'a' and 'b' into pre-processor macros is the only option left, but
|
|
# #defines and #undefs in the middle of a function hurt the readability and
|
|
# are less idiomatic than simply using 'const int'.
|
|
CHECKS="$CHECKS,-cert-dcl03-c"
|
|
CHECKS="$CHECKS,-hicpp-static-assert"
|
|
CHECKS="$CHECKS,-misc-static-assert"
|
|
|
|
# TODO(iphydf): We might want some of these. For the ones we don't want, add a
|
|
# comment explaining why not.
|
|
CHECKS="$CHECKS,-clang-analyzer-optin.performance.Padding"
|
|
CHECKS="$CHECKS,-hicpp-signed-bitwise"
|
|
CHECKS="$CHECKS,-misc-unused-parameters"
|
|
CHECKS="$CHECKS,-readability-function-cognitive-complexity"
|
|
|
|
# TODO(iphydf): Maybe fix these?
|
|
CHECKS="$CHECKS,-bugprone-easily-swappable-parameters"
|
|
CHECKS="$CHECKS,-bugprone-implicit-widening-of-multiplication-result"
|
|
CHECKS="$CHECKS,-bugprone-integer-division"
|
|
CHECKS="$CHECKS,-clang-analyzer-core.NullDereference"
|
|
CHECKS="$CHECKS,-clang-analyzer-valist.Uninitialized"
|
|
CHECKS="$CHECKS,-concurrency-mt-unsafe"
|
|
CHECKS="$CHECKS,-cppcoreguidelines-avoid-non-const-global-variables"
|
|
CHECKS="$CHECKS,-misc-no-recursion"
|
|
|
|
# TODO(iphydf): Probably fix these.
|
|
CHECKS="$CHECKS,-cert-err33-c"
|
|
CHECKS="$CHECKS,-cppcoreguidelines-avoid-magic-numbers"
|
|
CHECKS="$CHECKS,-google-readability-casting"
|
|
CHECKS="$CHECKS,-modernize-macro-to-enum"
|
|
CHECKS="$CHECKS,-readability-magic-numbers"
|
|
|
|
# TODO(iphydf): These two trip on list.c. Investigate why.
|
|
CHECKS="$CHECKS,-clang-analyzer-core.NonNullParamChecker"
|
|
CHECKS="$CHECKS,-clang-analyzer-unix.Malloc"
|
|
|
|
ERRORS="*"
|
|
|
|
# TODO(iphydf): Fix these.
|
|
ERRORS="$ERRORS,-bugprone-macro-parentheses"
|
|
ERRORS="$ERRORS,-cert-err34-c"
|
|
ERRORS="$ERRORS,-cert-str34-c"
|
|
ERRORS="$ERRORS,-readability-suspicious-call-argument"
|
|
|
|
set -eux
|
|
|
|
run() {
|
|
echo "Running clang-tidy in variant '$*'"
|
|
EXTRA_ARGS=("$@")
|
|
for i in "${!EXTRA_ARGS[@]}"; do
|
|
EXTRA_ARGS[$i]="--extra-arg=${EXTRA_ARGS[$i]}"
|
|
done
|
|
clang-tidy-14 \
|
|
-p=_build \
|
|
--extra-arg=-DMIN_LOGGER_LEVEL=LOGGER_LEVEL_TRACE \
|
|
"${EXTRA_ARGS[@]}" \
|
|
--checks="$CHECKS" \
|
|
--warnings-as-errors="$ERRORS" \
|
|
--use-color \
|
|
other/bootstrap_daemon/src/*.c \
|
|
other/*.c \
|
|
toxav/*.c \
|
|
toxcore/*.c \
|
|
toxencryptsave/*.c
|
|
}
|
|
|
|
cmake . -B_build -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
|
|
|
|
. other/analysis/variants.sh
|