Green Sky
aae086cc65
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to. 32e67ab4c2 cleanup: use typedef for private message ID's in callback 7b1db6adc1 feat: add message IDs to private group messages 99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests e742deddff feat: Check hashes of Windows dependencies when cross-compiling dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image 14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes ed37616249 docs: Update the Windows cross-compilation section 9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies 19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows 1be311e51f feat: Build the fun utils when cross-compiling to Windows 88133f8446 chore: Strip Windows binaries 3cc0ae7535 refactor: Copy over all of the required static dependencies c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows 74bbac5363 feat: Let CMake create the dll instead of doing so ourselves 246642e9ae feat: Harden Windows cross-compilation 8d431c0d11 chore: Bump Windows build dependency versions e519f7998b fix: Remove unnecessary wsock32 dependency on Windows ed2b60c217 chore: Use a specific non-broken slimcc version. d7f21010a1 chore: Update github actions. e71a68b7f2 docs: Update the list of CMake options 77e08876ff chore: Remove mod and founder from group API naming scheme 12bc042767 docs: add the experimental api build option to INSTALL.md e1fa5cae96 refactor: Rename Queries to Query to align with other enums. be82a3ea30 fix: Correct type for conference offline peer numbers. 0627c36716 test: Add pkgsrc build. 92578afe4b test: Add FreeBSD VM action on GitHub. 52ece0f57b test: Build toxcore on NetBSD (VM). 3fe8ee2c11 chore: Only install tox_private.h on request. 9a8dfa06ab fix: save_compatibility_test failing on big-endian systems 86f5e55578 fix: Don't serve files from websockify. 710eb674a5 fix: Correctly pass extended public keys to group moderation code. 021db7031c refactor: Use `struct`s for extended public/secret keys. a1e999fd80 chore: Compile libsodium reference implementation with compcert. fbe3c19cf5 cleanup: correct a few nullable annotations 623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. c71567dc18 fix: Pass array, not array pointer, to `memcmp`. 9b46a08144 cleanup: Never pass `void*` directly to `memcpy`. 5d7b7a7bbc refactor: Use tox rng to seed the keypair generation. 961891d568 cleanup: Small improvements found by PVS Studio. 8201019f0d chore: Disable NGC saving by default, enable through Tox_Options. 5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`. ca4606d49d refactor: Use strong typedef for NGC peer id. 442213b722 cleanup: Simplify custom packet length check in NGC. 08d3393def fix: Correct a few potential null derefs in bootstrap daemon. b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope. dab5fe44b9 fix: Zero out stack-allocated secret key before return. f058103299 refactor: Make prune_gc_sanctions_list more obviously correct. 3ba7a0dec9 docs: Add static analysis tool list to README. 8d0811a0f3 docs: Run prettier-markdown on markdown files. 969e3a2bfc refactor: Fix network test not using the strong typedef 93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`. 9fe18b176f fix: Fix some false positive from PVS Studio. 7c44379ccb cleanup: Check that WINXP macro exists before comparing it. 5c93231bef refactor: Make tox mutex non-recursive. aacff73939 docs: Fix up doxyfile. d55fc85ff5 docs: Add more documentation to crypto_core. 5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`. e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests. 34df938f52 chore: Use C++ mode for clang-tidy. 8b05296a78 chore: Check that both gtest and gmock exist for tests. 42010660e1 test: Add slimcc compiler compatibility test. b473630321 chore: Add some comments to the astyle config. b7404f24f6 cleanup: Remove implicit bool conversions. 4e2dba4d9f chore: Reformat sources with astyle. 4359e3a6bc chore: Rename C++ headers to .hh suffixes. 0c05566e58 cleanup: Further `#include` cleanups. 8d29935b7a chore: Only check the bootstrap daemon checksum on release. f70e588bc6 cleanup: Add more `const` where possible. 511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene. 1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module. a975943564 chore: Really fix coverage docker image build. c08409390f chore: Fix post-submit coverage image. 39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s. d94246a906 fix: partially fix a bug that prevented group part messages from sending. eeaa039222 chore: Fix rpm build; add a CI check for it. 8328449c1a chore: Speed up docker builds a bit by reducing layer count. d6d67d56f3 cleanup: Add `const` where possible in auto tests. 6aa9e6850d cleanup: Minor cleanup of event unpack code. bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`. 203e1af81e fix: a few off by one errors in group autotests 5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`. 662c2140f3 test: Add goblint static analyser. 8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`. a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`. 6370d0f15d cleanup: Expand the `Tox_Options` accessor macros. 14a1a0b9bd cleanup: Remove plan9 support. a05dccad13 test: Add a simple new/delete test for Tox. 1cdcf938b9 cleanup: Add comment after every `#endif`. ba99d4dc4b test: Fix comment I broke in the events test PR. e07248debb refactor: Migrate auto_tests to new events API. bdd42b5452 refactor: Add common msgpack array packer with callback. 3c659f5288 cleanup: Rename group to conference in groupav documentation. 89957be230 cleanup: Ensure handler params are named after callback params. c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks. e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events. 5e2c8cabc1 cleanup: make some improvements to group moderation test 259de4867e cleanup: Remove `bin_pack_{new,free}`. 21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion 16809dc36e feat: Add dht_get_nodes_response event to the events system. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
307 lines
9.9 KiB
C
307 lines
9.9 KiB
C
/*
|
|
* Tests that we can save a groupchat and load a groupchat with the saved data.
|
|
*/
|
|
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#include <stdint.h>
|
|
#include <stdbool.h>
|
|
|
|
#include "auto_test_support.h"
|
|
|
|
typedef struct State {
|
|
bool peer_joined;
|
|
} State;
|
|
|
|
#define NUM_GROUP_TOXES 2
|
|
#define GROUP_NAME "The Test Chamber"
|
|
#define GROUP_NAME_LEN (sizeof(GROUP_NAME) - 1)
|
|
#define TOPIC "They're waiting for you Gordon..."
|
|
#define TOPIC_LEN (sizeof(TOPIC) - 1)
|
|
#define NEW_PRIV_STATE TOX_GROUP_PRIVACY_STATE_PRIVATE
|
|
#define PASSWORD "password123"
|
|
#define PASS_LEN (sizeof(PASSWORD) - 1)
|
|
#define PEER_LIMIT 69
|
|
#define PEER0_NICK "Mike"
|
|
#define PEER0_NICK_LEN (sizeof(PEER0_NICK) -1)
|
|
#define NEW_USER_STATUS TOX_USER_STATUS_BUSY
|
|
|
|
static void group_invite_handler(const Tox_Event_Group_Invite *event, void *user_data)
|
|
{
|
|
AutoTox *autotox = (AutoTox *)user_data;
|
|
ck_assert(autotox != nullptr);
|
|
|
|
const uint32_t friend_number = tox_event_group_invite_get_friend_number(event);
|
|
const uint8_t *invite_data = tox_event_group_invite_get_invite_data(event);
|
|
const size_t length = tox_event_group_invite_get_invite_data_length(event);
|
|
|
|
Tox_Err_Group_Invite_Accept err_accept;
|
|
tox_group_invite_accept(autotox->tox, friend_number, invite_data, length, (const uint8_t *)"test2", 5,
|
|
nullptr, 0, &err_accept);
|
|
ck_assert(err_accept == TOX_ERR_GROUP_INVITE_ACCEPT_OK);
|
|
|
|
}
|
|
|
|
static void group_peer_join_handler(const Tox_Event_Group_Peer_Join *event, void *user_data)
|
|
{
|
|
AutoTox *autotox = (AutoTox *)user_data;
|
|
ck_assert(autotox != nullptr);
|
|
|
|
State *state = (State *)autotox->state;
|
|
state->peer_joined = true;
|
|
}
|
|
|
|
/* Checks that group has the same state according to the above defines
|
|
*
|
|
* Returns 0 if state is correct.
|
|
* Returns a value < 0 if state is incorrect.
|
|
*/
|
|
static int has_correct_group_state(const Tox *tox, uint32_t group_number, const uint8_t *expected_chat_id)
|
|
{
|
|
Tox_Err_Group_State_Query query_err;
|
|
|
|
Tox_Group_Privacy_State priv_state = tox_group_get_privacy_state(tox, group_number, &query_err);
|
|
ck_assert(query_err == TOX_ERR_GROUP_STATE_QUERY_OK);
|
|
|
|
if (priv_state != NEW_PRIV_STATE) {
|
|
return -1;
|
|
}
|
|
|
|
size_t pass_len = tox_group_get_password_size(tox, group_number, &query_err);
|
|
ck_assert(query_err == TOX_ERR_GROUP_STATE_QUERY_OK);
|
|
|
|
uint8_t password[TOX_GROUP_MAX_PASSWORD_SIZE];
|
|
tox_group_get_password(tox, group_number, password, &query_err);
|
|
ck_assert(query_err == TOX_ERR_GROUP_STATE_QUERY_OK);
|
|
|
|
if (pass_len != PASS_LEN || memcmp(password, PASSWORD, pass_len) != 0) {
|
|
return -2;
|
|
}
|
|
|
|
size_t gname_len = tox_group_get_name_size(tox, group_number, &query_err);
|
|
ck_assert(query_err == TOX_ERR_GROUP_STATE_QUERY_OK);
|
|
|
|
uint8_t group_name[TOX_GROUP_MAX_GROUP_NAME_LENGTH];
|
|
tox_group_get_name(tox, group_number, group_name, &query_err);
|
|
|
|
if (gname_len != GROUP_NAME_LEN || memcmp(group_name, GROUP_NAME, gname_len) != 0) {
|
|
return -3;
|
|
}
|
|
|
|
if (tox_group_get_peer_limit(tox, group_number, nullptr) != PEER_LIMIT) {
|
|
return -4;
|
|
}
|
|
|
|
Tox_Group_Topic_Lock topic_lock = tox_group_get_topic_lock(tox, group_number, &query_err);
|
|
ck_assert(query_err == TOX_ERR_GROUP_STATE_QUERY_OK);
|
|
|
|
if (topic_lock != TOX_GROUP_TOPIC_LOCK_DISABLED) {
|
|
return -5;
|
|
}
|
|
|
|
Tox_Err_Group_State_Query id_err;
|
|
uint8_t chat_id[TOX_GROUP_CHAT_ID_SIZE];
|
|
tox_group_get_chat_id(tox, group_number, chat_id, &id_err);
|
|
|
|
ck_assert(id_err == TOX_ERR_GROUP_STATE_QUERY_OK);
|
|
|
|
if (memcmp(chat_id, expected_chat_id, TOX_GROUP_CHAT_ID_SIZE) != 0) {
|
|
return -6;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int has_correct_self_state(const Tox *tox, uint32_t group_number, const uint8_t *expected_self_pk)
|
|
{
|
|
Tox_Err_Group_Self_Query sq_err;
|
|
size_t self_length = tox_group_self_get_name_size(tox, group_number, &sq_err);
|
|
ck_assert(sq_err == TOX_ERR_GROUP_SELF_QUERY_OK);
|
|
|
|
uint8_t self_name[TOX_MAX_NAME_LENGTH];
|
|
tox_group_self_get_name(tox, group_number, self_name, &sq_err);
|
|
ck_assert(sq_err == TOX_ERR_GROUP_SELF_QUERY_OK);
|
|
|
|
if (self_length != PEER0_NICK_LEN || memcmp(self_name, PEER0_NICK, self_length) != 0) {
|
|
return -1;
|
|
}
|
|
|
|
Tox_User_Status self_status = tox_group_self_get_status(tox, group_number, &sq_err);
|
|
ck_assert(sq_err == TOX_ERR_GROUP_SELF_QUERY_OK);
|
|
|
|
if (self_status != NEW_USER_STATUS) {
|
|
return -2;
|
|
}
|
|
|
|
Tox_Group_Role self_role = tox_group_self_get_role(tox, group_number, &sq_err);
|
|
ck_assert(sq_err == TOX_ERR_GROUP_SELF_QUERY_OK);
|
|
|
|
if (self_role != TOX_GROUP_ROLE_FOUNDER) {
|
|
return -3;
|
|
}
|
|
|
|
uint8_t self_pk[TOX_GROUP_PEER_PUBLIC_KEY_SIZE];
|
|
|
|
tox_group_self_get_public_key(tox, group_number, self_pk, &sq_err);
|
|
ck_assert(sq_err == TOX_ERR_GROUP_SELF_QUERY_OK);
|
|
|
|
if (memcmp(self_pk, expected_self_pk, TOX_GROUP_PEER_PUBLIC_KEY_SIZE) != 0) {
|
|
return -4;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void group_save_test(AutoTox *autotoxes)
|
|
{
|
|
ck_assert_msg(NUM_GROUP_TOXES > 1, "NUM_GROUP_TOXES is too small: %d", NUM_GROUP_TOXES);
|
|
|
|
for (size_t i = 0; i < NUM_GROUP_TOXES; ++i) {
|
|
tox_events_callback_group_invite(autotoxes[i].dispatch, group_invite_handler);
|
|
tox_events_callback_group_peer_join(autotoxes[i].dispatch, group_peer_join_handler);
|
|
}
|
|
|
|
Tox *tox0 = autotoxes[0].tox;
|
|
|
|
const State *state0 = (State *)autotoxes[0].state;
|
|
const State *state1 = (State *)autotoxes[1].state;
|
|
|
|
Tox_Err_Group_New err_new;
|
|
const uint32_t group_number = tox_group_new(tox0, TOX_GROUP_PRIVACY_STATE_PRIVATE, (const uint8_t *)GROUP_NAME,
|
|
GROUP_NAME_LEN, (const uint8_t *)"test", 4, &err_new);
|
|
|
|
ck_assert(err_new == TOX_ERR_GROUP_NEW_OK);
|
|
|
|
uint8_t chat_id[TOX_GROUP_CHAT_ID_SIZE];
|
|
|
|
Tox_Err_Group_State_Query id_err;
|
|
tox_group_get_chat_id(tox0, group_number, chat_id, &id_err);
|
|
ck_assert(id_err == TOX_ERR_GROUP_STATE_QUERY_OK);
|
|
|
|
uint8_t founder_pk[TOX_GROUP_PEER_PUBLIC_KEY_SIZE];
|
|
|
|
Tox_Err_Group_Self_Query sq_err;
|
|
tox_group_self_get_public_key(tox0, group_number, founder_pk, &sq_err);
|
|
ck_assert(sq_err == TOX_ERR_GROUP_SELF_QUERY_OK);
|
|
|
|
Tox_Err_Group_Invite_Friend err_invite;
|
|
tox_group_invite_friend(tox0, group_number, 0, &err_invite);
|
|
|
|
ck_assert(err_invite == TOX_ERR_GROUP_INVITE_FRIEND_OK);
|
|
|
|
while (!state0->peer_joined && !state1->peer_joined) {
|
|
iterate_all_wait(autotoxes, NUM_GROUP_TOXES, ITERATION_INTERVAL);
|
|
}
|
|
|
|
printf("tox0 invites tox1 to group\n");
|
|
|
|
// change group state
|
|
Tox_Err_Group_Topic_Set top_err;
|
|
tox_group_set_topic(tox0, group_number, (const uint8_t *)TOPIC, TOPIC_LEN, &top_err);
|
|
ck_assert(top_err == TOX_ERR_GROUP_TOPIC_SET_OK);
|
|
|
|
Tox_Err_Group_Set_Topic_Lock lock_set_err;
|
|
tox_group_set_topic_lock(tox0, group_number, TOX_GROUP_TOPIC_LOCK_DISABLED, &lock_set_err);
|
|
ck_assert(lock_set_err == TOX_ERR_GROUP_SET_TOPIC_LOCK_OK);
|
|
|
|
Tox_Err_Group_Set_Privacy_State priv_err;
|
|
tox_group_set_privacy_state(tox0, group_number, NEW_PRIV_STATE, &priv_err);
|
|
ck_assert(priv_err == TOX_ERR_GROUP_SET_PRIVACY_STATE_OK);
|
|
|
|
Tox_Err_Group_Set_Password pass_set_err;
|
|
tox_group_set_password(tox0, group_number, (const uint8_t *)PASSWORD, PASS_LEN, &pass_set_err);
|
|
ck_assert(pass_set_err == TOX_ERR_GROUP_SET_PASSWORD_OK);
|
|
|
|
Tox_Err_Group_Set_Peer_Limit limit_set_err;
|
|
tox_group_set_peer_limit(tox0, group_number, PEER_LIMIT, &limit_set_err);
|
|
ck_assert(limit_set_err == TOX_ERR_GROUP_SET_PEER_LIMIT_OK);
|
|
|
|
// change self state
|
|
Tox_Err_Group_Self_Name_Set n_err;
|
|
tox_group_self_set_name(tox0, group_number, (const uint8_t *)PEER0_NICK, PEER0_NICK_LEN, &n_err);
|
|
ck_assert(n_err == TOX_ERR_GROUP_SELF_NAME_SET_OK);
|
|
|
|
Tox_Err_Group_Self_Status_Set s_err;
|
|
tox_group_self_set_status(tox0, group_number, NEW_USER_STATUS, &s_err);
|
|
ck_assert(s_err == TOX_ERR_GROUP_SELF_STATUS_SET_OK);
|
|
|
|
iterate_all_wait(autotoxes, NUM_GROUP_TOXES, ITERATION_INTERVAL);
|
|
|
|
printf("tox0 changes group state\n");
|
|
|
|
const size_t save_length = tox_get_savedata_size(tox0);
|
|
|
|
uint8_t *save = (uint8_t *)malloc(save_length);
|
|
|
|
ck_assert(save != nullptr);
|
|
|
|
tox_get_savedata(tox0, save);
|
|
|
|
for (size_t i = 0; i < NUM_GROUP_TOXES; i++) {
|
|
tox_group_leave(autotoxes[i].tox, group_number, nullptr, 0, nullptr);
|
|
}
|
|
|
|
struct Tox_Options *const options = tox_options_new(nullptr);
|
|
|
|
ck_assert(options != nullptr);
|
|
|
|
tox_options_set_savedata_type(options, TOX_SAVEDATA_TYPE_TOX_SAVE);
|
|
tox_options_set_savedata_data(options, save, save_length);
|
|
tox_options_set_experimental_groups_persistence(options, true);
|
|
|
|
Tox *new_tox = tox_new_log(options, nullptr, nullptr);
|
|
|
|
ck_assert(new_tox != nullptr);
|
|
|
|
iterate_all_wait(autotoxes, NUM_GROUP_TOXES, ITERATION_INTERVAL);
|
|
|
|
printf("tox0 saves group and reloads client\n");
|
|
|
|
const int group_ret = has_correct_group_state(new_tox, group_number, chat_id);
|
|
|
|
ck_assert_msg(group_ret == 0, "incorrect group state: %d", group_ret);
|
|
|
|
const int self_ret = has_correct_self_state(new_tox, group_number, founder_pk);
|
|
|
|
ck_assert_msg(self_ret == 0, "incorrect self state: %d", self_ret);
|
|
|
|
tox_group_leave(new_tox, group_number, nullptr, 0, nullptr);
|
|
|
|
free(save);
|
|
|
|
tox_options_free(options);
|
|
|
|
tox_kill(new_tox);
|
|
|
|
printf("All tests passed!\n");
|
|
}
|
|
|
|
int main(void)
|
|
{
|
|
setvbuf(stdout, nullptr, _IONBF, 0);
|
|
|
|
Run_Auto_Options autotest_opts = default_run_auto_options();
|
|
autotest_opts.graph = GRAPH_COMPLETE;
|
|
|
|
Tox_Options *opts = tox_options_new(nullptr);
|
|
ck_assert(opts != nullptr);
|
|
tox_options_set_experimental_groups_persistence(opts, true);
|
|
run_auto_test(opts, NUM_GROUP_TOXES, group_save_test, sizeof(State), &autotest_opts);
|
|
tox_options_free(opts);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#undef NUM_GROUP_TOXES
|
|
#undef GROUP_NAME
|
|
#undef GROUP_NAME_LEN
|
|
#undef TOPIC
|
|
#undef TOPIC_LEN
|
|
#undef NEW_PRIV_STATE
|
|
#undef PASSWORD
|
|
#undef PASS_LEN
|
|
#undef PEER_LIMIT
|
|
#undef PEER0_NICK
|
|
#undef PEER0_NICK_LEN
|
|
#undef NEW_USER_STATUS
|