forked from Green-Sky/tomato
Green Sky
aae086cc65
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to. 32e67ab4c2 cleanup: use typedef for private message ID's in callback 7b1db6adc1 feat: add message IDs to private group messages 99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests e742deddff feat: Check hashes of Windows dependencies when cross-compiling dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image 14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes ed37616249 docs: Update the Windows cross-compilation section 9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies 19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows 1be311e51f feat: Build the fun utils when cross-compiling to Windows 88133f8446 chore: Strip Windows binaries 3cc0ae7535 refactor: Copy over all of the required static dependencies c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows 74bbac5363 feat: Let CMake create the dll instead of doing so ourselves 246642e9ae feat: Harden Windows cross-compilation 8d431c0d11 chore: Bump Windows build dependency versions e519f7998b fix: Remove unnecessary wsock32 dependency on Windows ed2b60c217 chore: Use a specific non-broken slimcc version. d7f21010a1 chore: Update github actions. e71a68b7f2 docs: Update the list of CMake options 77e08876ff chore: Remove mod and founder from group API naming scheme 12bc042767 docs: add the experimental api build option to INSTALL.md e1fa5cae96 refactor: Rename Queries to Query to align with other enums. be82a3ea30 fix: Correct type for conference offline peer numbers. 0627c36716 test: Add pkgsrc build. 92578afe4b test: Add FreeBSD VM action on GitHub. 52ece0f57b test: Build toxcore on NetBSD (VM). 3fe8ee2c11 chore: Only install tox_private.h on request. 9a8dfa06ab fix: save_compatibility_test failing on big-endian systems 86f5e55578 fix: Don't serve files from websockify. 710eb674a5 fix: Correctly pass extended public keys to group moderation code. 021db7031c refactor: Use `struct`s for extended public/secret keys. a1e999fd80 chore: Compile libsodium reference implementation with compcert. fbe3c19cf5 cleanup: correct a few nullable annotations 623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. c71567dc18 fix: Pass array, not array pointer, to `memcmp`. 9b46a08144 cleanup: Never pass `void*` directly to `memcpy`. 5d7b7a7bbc refactor: Use tox rng to seed the keypair generation. 961891d568 cleanup: Small improvements found by PVS Studio. 8201019f0d chore: Disable NGC saving by default, enable through Tox_Options. 5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`. ca4606d49d refactor: Use strong typedef for NGC peer id. 442213b722 cleanup: Simplify custom packet length check in NGC. 08d3393def fix: Correct a few potential null derefs in bootstrap daemon. b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope. dab5fe44b9 fix: Zero out stack-allocated secret key before return. f058103299 refactor: Make prune_gc_sanctions_list more obviously correct. 3ba7a0dec9 docs: Add static analysis tool list to README. 8d0811a0f3 docs: Run prettier-markdown on markdown files. 969e3a2bfc refactor: Fix network test not using the strong typedef 93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`. 9fe18b176f fix: Fix some false positive from PVS Studio. 7c44379ccb cleanup: Check that WINXP macro exists before comparing it. 5c93231bef refactor: Make tox mutex non-recursive. aacff73939 docs: Fix up doxyfile. d55fc85ff5 docs: Add more documentation to crypto_core. 5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`. e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests. 34df938f52 chore: Use C++ mode for clang-tidy. 8b05296a78 chore: Check that both gtest and gmock exist for tests. 42010660e1 test: Add slimcc compiler compatibility test. b473630321 chore: Add some comments to the astyle config. b7404f24f6 cleanup: Remove implicit bool conversions. 4e2dba4d9f chore: Reformat sources with astyle. 4359e3a6bc chore: Rename C++ headers to .hh suffixes. 0c05566e58 cleanup: Further `#include` cleanups. 8d29935b7a chore: Only check the bootstrap daemon checksum on release. f70e588bc6 cleanup: Add more `const` where possible. 511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene. 1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module. a975943564 chore: Really fix coverage docker image build. c08409390f chore: Fix post-submit coverage image. 39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s. d94246a906 fix: partially fix a bug that prevented group part messages from sending. eeaa039222 chore: Fix rpm build; add a CI check for it. 8328449c1a chore: Speed up docker builds a bit by reducing layer count. d6d67d56f3 cleanup: Add `const` where possible in auto tests. 6aa9e6850d cleanup: Minor cleanup of event unpack code. bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`. 203e1af81e fix: a few off by one errors in group autotests 5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`. 662c2140f3 test: Add goblint static analyser. 8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`. a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`. 6370d0f15d cleanup: Expand the `Tox_Options` accessor macros. 14a1a0b9bd cleanup: Remove plan9 support. a05dccad13 test: Add a simple new/delete test for Tox. 1cdcf938b9 cleanup: Add comment after every `#endif`. ba99d4dc4b test: Fix comment I broke in the events test PR. e07248debb refactor: Migrate auto_tests to new events API. bdd42b5452 refactor: Add common msgpack array packer with callback. 3c659f5288 cleanup: Rename group to conference in groupav documentation. 89957be230 cleanup: Ensure handler params are named after callback params. c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks. e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events. 5e2c8cabc1 cleanup: make some improvements to group moderation test 259de4867e cleanup: Remove `bin_pack_{new,free}`. 21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion 16809dc36e feat: Add dht_get_nodes_response event to the events system. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
479 lines
13 KiB
C
479 lines
13 KiB
C
/* SPDX-License-Identifier: GPL-3.0-or-later
|
|
* Copyright © 2016-2020 The TokTok team.
|
|
* Copyright © 2015 Tox project.
|
|
*/
|
|
|
|
#include "group_announce.h"
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include "DHT.h"
|
|
#include "attributes.h"
|
|
#include "ccompat.h"
|
|
#include "crypto_core.h"
|
|
#include "logger.h"
|
|
#include "mono_time.h"
|
|
#include "network.h"
|
|
|
|
/**
|
|
* Removes `announces` from `gc_announces_list`.
|
|
*/
|
|
non_null()
|
|
static void remove_announces(GC_Announces_List *gc_announces_list, GC_Announces *announces)
|
|
{
|
|
if (announces == nullptr || gc_announces_list == nullptr) {
|
|
return;
|
|
}
|
|
|
|
if (announces->prev_announce != nullptr) {
|
|
announces->prev_announce->next_announce = announces->next_announce;
|
|
} else {
|
|
gc_announces_list->root_announces = announces->next_announce;
|
|
}
|
|
|
|
if (announces->next_announce != nullptr) {
|
|
announces->next_announce->prev_announce = announces->prev_announce;
|
|
}
|
|
|
|
free(announces);
|
|
}
|
|
|
|
/**
|
|
* Returns the announce designated by `chat_id`.
|
|
* Returns null if no announce is found.
|
|
*/
|
|
non_null()
|
|
static GC_Announces *get_announces_by_chat_id(const GC_Announces_List *gc_announces_list, const uint8_t *chat_id)
|
|
{
|
|
GC_Announces *announces = gc_announces_list->root_announces;
|
|
|
|
while (announces != nullptr) {
|
|
if (memcmp(announces->chat_id, chat_id, CHAT_ID_SIZE) == 0) {
|
|
return announces;
|
|
}
|
|
|
|
announces = announces->next_announce;
|
|
}
|
|
|
|
return nullptr;
|
|
}
|
|
|
|
int gca_get_announces(const GC_Announces_List *gc_announces_list, GC_Announce *gc_announces, uint8_t max_nodes,
|
|
const uint8_t *chat_id, const uint8_t *except_public_key)
|
|
{
|
|
if (gc_announces == nullptr || gc_announces_list == nullptr || chat_id == nullptr || max_nodes == 0
|
|
|| except_public_key == nullptr) {
|
|
return -1;
|
|
}
|
|
|
|
const GC_Announces *announces = get_announces_by_chat_id(gc_announces_list, chat_id);
|
|
|
|
if (announces == nullptr) {
|
|
return 0;
|
|
}
|
|
|
|
uint16_t added_count = 0;
|
|
|
|
for (size_t i = 0; i < announces->index && i < GCA_MAX_SAVED_ANNOUNCES_PER_GC && added_count < max_nodes; ++i) {
|
|
const size_t index = i % GCA_MAX_SAVED_ANNOUNCES_PER_GC;
|
|
|
|
if (memcmp(except_public_key, announces->peer_announces[index].base_announce.peer_public_key,
|
|
ENC_PUBLIC_KEY_SIZE) == 0) {
|
|
continue;
|
|
}
|
|
|
|
bool already_added = false;
|
|
|
|
for (size_t j = 0; j < added_count; ++j) {
|
|
if (memcmp(gc_announces[j].peer_public_key, announces->peer_announces[index].base_announce.peer_public_key,
|
|
ENC_PUBLIC_KEY_SIZE) == 0) {
|
|
already_added = true;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (!already_added) {
|
|
gc_announces[added_count] = announces->peer_announces[index].base_announce;
|
|
++added_count;
|
|
}
|
|
}
|
|
|
|
return added_count;
|
|
}
|
|
|
|
uint16_t gca_pack_announces_list_size(uint16_t count)
|
|
{
|
|
return count * GCA_ANNOUNCE_MAX_SIZE;
|
|
}
|
|
|
|
int gca_pack_announce(const Logger *log, uint8_t *data, uint16_t length, const GC_Announce *announce)
|
|
{
|
|
if (length < GCA_ANNOUNCE_MAX_SIZE) {
|
|
LOGGER_ERROR(log, "Invalid announce length: %u", length);
|
|
return -1;
|
|
}
|
|
|
|
if (data == nullptr) {
|
|
LOGGER_ERROR(log, "data is null");
|
|
return -1;
|
|
}
|
|
|
|
if (announce == nullptr) {
|
|
LOGGER_ERROR(log, "announce is null");
|
|
return -1;
|
|
}
|
|
|
|
uint16_t offset = 0;
|
|
memcpy(data + offset, announce->peer_public_key, ENC_PUBLIC_KEY_SIZE);
|
|
offset += ENC_PUBLIC_KEY_SIZE;
|
|
|
|
data[offset] = announce->ip_port_is_set ? 1 : 0;
|
|
++offset;
|
|
|
|
data[offset] = announce->tcp_relays_count;
|
|
++offset;
|
|
|
|
if (!announce->ip_port_is_set && announce->tcp_relays_count == 0) {
|
|
LOGGER_ERROR(log, "Failed to pack announce: no valid ip_port or tcp relay");
|
|
return -1;
|
|
}
|
|
|
|
if (announce->ip_port_is_set) {
|
|
const int ip_port_length = pack_ip_port(log, data + offset, length - offset, &announce->ip_port);
|
|
|
|
if (ip_port_length == -1) {
|
|
LOGGER_ERROR(log, "Failed to pack ip_port");
|
|
return -1;
|
|
}
|
|
|
|
offset += ip_port_length;
|
|
}
|
|
|
|
const int nodes_length = pack_nodes(log, data + offset, length - offset, announce->tcp_relays,
|
|
announce->tcp_relays_count);
|
|
|
|
if (nodes_length == -1) {
|
|
LOGGER_ERROR(log, "Failed to pack TCP nodes");
|
|
return -1;
|
|
}
|
|
|
|
return nodes_length + offset;
|
|
}
|
|
|
|
/**
|
|
* Unpacks `announce` into `data` buffer of size `length`.
|
|
*
|
|
* Returns the size of the unpacked data on success.
|
|
* Returns -1 on failure.
|
|
*/
|
|
non_null()
|
|
static int gca_unpack_announce(const Logger *log, const uint8_t *data, uint16_t length, GC_Announce *announce)
|
|
{
|
|
if (length < ENC_PUBLIC_KEY_SIZE + 2) {
|
|
LOGGER_ERROR(log, "Invalid announce length: %u", length);
|
|
return -1;
|
|
}
|
|
|
|
if (data == nullptr) {
|
|
LOGGER_ERROR(log, "data is null");
|
|
return -1;
|
|
}
|
|
|
|
if (announce == nullptr) {
|
|
LOGGER_ERROR(log, "announce is null");
|
|
return -1;
|
|
}
|
|
|
|
uint16_t offset = 0;
|
|
memcpy(announce->peer_public_key, data + offset, ENC_PUBLIC_KEY_SIZE);
|
|
offset += ENC_PUBLIC_KEY_SIZE;
|
|
|
|
net_unpack_bool(&data[offset], &announce->ip_port_is_set);
|
|
++offset;
|
|
|
|
announce->tcp_relays_count = data[offset];
|
|
++offset;
|
|
|
|
if (announce->tcp_relays_count > GCA_MAX_ANNOUNCED_TCP_RELAYS) {
|
|
return -1;
|
|
}
|
|
|
|
if (announce->ip_port_is_set) {
|
|
if (length - offset == 0) {
|
|
return -1;
|
|
}
|
|
|
|
const int ip_port_length = unpack_ip_port(&announce->ip_port, data + offset, length - offset, false);
|
|
|
|
if (ip_port_length == -1) {
|
|
LOGGER_ERROR(log, "Failed to unpack ip_port");
|
|
return -1;
|
|
}
|
|
|
|
offset += ip_port_length;
|
|
}
|
|
|
|
uint16_t nodes_length;
|
|
const int nodes_count = unpack_nodes(announce->tcp_relays, announce->tcp_relays_count, &nodes_length,
|
|
data + offset, length - offset, true);
|
|
|
|
if (nodes_count != announce->tcp_relays_count) {
|
|
LOGGER_ERROR(log, "Failed to unpack TCP nodes");
|
|
return -1;
|
|
}
|
|
|
|
return offset + nodes_length;
|
|
}
|
|
|
|
int gca_pack_public_announce(const Logger *log, uint8_t *data, uint16_t length,
|
|
const GC_Public_Announce *public_announce)
|
|
{
|
|
if (public_announce == nullptr || data == nullptr || length < CHAT_ID_SIZE) {
|
|
return -1;
|
|
}
|
|
|
|
memcpy(data, public_announce->chat_public_key, CHAT_ID_SIZE);
|
|
|
|
const int packed_size = gca_pack_announce(log, data + CHAT_ID_SIZE, length - CHAT_ID_SIZE,
|
|
&public_announce->base_announce);
|
|
|
|
if (packed_size < 0) {
|
|
LOGGER_ERROR(log, "Failed to pack public group announce");
|
|
return -1;
|
|
}
|
|
|
|
return packed_size + CHAT_ID_SIZE;
|
|
}
|
|
|
|
int gca_unpack_public_announce(const Logger *log, const uint8_t *data, uint16_t length,
|
|
GC_Public_Announce *public_announce)
|
|
{
|
|
if (length < CHAT_ID_SIZE) {
|
|
LOGGER_ERROR(log, "invalid public announce length: %u", length);
|
|
return -1;
|
|
}
|
|
|
|
if (data == nullptr) {
|
|
LOGGER_ERROR(log, "data is null");
|
|
return -1;
|
|
}
|
|
|
|
if (public_announce == nullptr) {
|
|
LOGGER_ERROR(log, "public_announce is null");
|
|
return -1;
|
|
}
|
|
|
|
memcpy(public_announce->chat_public_key, data, CHAT_ID_SIZE);
|
|
|
|
const int base_announce_size = gca_unpack_announce(log, data + ENC_PUBLIC_KEY_SIZE, length - ENC_PUBLIC_KEY_SIZE,
|
|
&public_announce->base_announce);
|
|
|
|
if (base_announce_size == -1) {
|
|
LOGGER_ERROR(log, "Failed to unpack group announce");
|
|
return -1;
|
|
}
|
|
|
|
return base_announce_size + CHAT_ID_SIZE;
|
|
}
|
|
|
|
int gca_pack_announces_list(const Logger *log, uint8_t *data, uint16_t length, const GC_Announce *announces,
|
|
uint8_t announces_count, size_t *processed)
|
|
{
|
|
if (data == nullptr) {
|
|
LOGGER_ERROR(log, "data is null");
|
|
return -1;
|
|
}
|
|
|
|
if (announces == nullptr) {
|
|
LOGGER_ERROR(log, "announces is null");
|
|
return -1;
|
|
}
|
|
|
|
uint16_t offset = 0;
|
|
|
|
for (size_t i = 0; i < announces_count; ++i) {
|
|
const int packed_length = gca_pack_announce(log, data + offset, length - offset, &announces[i]);
|
|
|
|
if (packed_length < 0) {
|
|
LOGGER_ERROR(log, "Failed to pack group announce");
|
|
return -1;
|
|
}
|
|
|
|
offset += packed_length;
|
|
}
|
|
|
|
if (processed != nullptr) {
|
|
*processed = offset;
|
|
}
|
|
|
|
return announces_count;
|
|
}
|
|
|
|
int gca_unpack_announces_list(const Logger *log, const uint8_t *data, uint16_t length, GC_Announce *announces,
|
|
uint8_t max_count)
|
|
{
|
|
if (data == nullptr) {
|
|
LOGGER_ERROR(log, "data is null");
|
|
return -1;
|
|
}
|
|
|
|
if (announces == nullptr) {
|
|
LOGGER_ERROR(log, "announces is null");
|
|
return -1;
|
|
}
|
|
|
|
uint16_t offset = 0;
|
|
int announces_count = 0;
|
|
|
|
for (size_t i = 0; i < max_count && length > offset; ++i) {
|
|
const int unpacked_length = gca_unpack_announce(log, data + offset, length - offset, &announces[i]);
|
|
|
|
if (unpacked_length == -1) {
|
|
LOGGER_WARNING(log, "Failed to unpack group announce: %d %d", length, offset);
|
|
return -1;
|
|
}
|
|
|
|
offset += unpacked_length;
|
|
++announces_count;
|
|
}
|
|
|
|
return announces_count;
|
|
}
|
|
|
|
non_null()
|
|
static GC_Announces *gca_new_announces(
|
|
GC_Announces_List *gc_announces_list,
|
|
const GC_Public_Announce *public_announce)
|
|
{
|
|
GC_Announces *announces = (GC_Announces *)calloc(1, sizeof(GC_Announces));
|
|
|
|
if (announces == nullptr) {
|
|
return nullptr;
|
|
}
|
|
|
|
announces->index = 0;
|
|
announces->prev_announce = nullptr;
|
|
|
|
if (gc_announces_list->root_announces != nullptr) {
|
|
gc_announces_list->root_announces->prev_announce = announces;
|
|
}
|
|
|
|
announces->next_announce = gc_announces_list->root_announces;
|
|
gc_announces_list->root_announces = announces;
|
|
memcpy(announces->chat_id, public_announce->chat_public_key, CHAT_ID_SIZE);
|
|
|
|
return announces;
|
|
}
|
|
|
|
GC_Peer_Announce *gca_add_announce(const Mono_Time *mono_time, GC_Announces_List *gc_announces_list,
|
|
const GC_Public_Announce *public_announce)
|
|
{
|
|
if (gc_announces_list == nullptr || public_announce == nullptr) {
|
|
return nullptr;
|
|
}
|
|
|
|
GC_Announces *announces = get_announces_by_chat_id(gc_announces_list, public_announce->chat_public_key);
|
|
|
|
// No entry for this chat_id exists so we create one
|
|
if (announces == nullptr) {
|
|
announces = gca_new_announces(gc_announces_list, public_announce);
|
|
|
|
if (announces == nullptr) {
|
|
return nullptr;
|
|
}
|
|
}
|
|
|
|
const uint64_t cur_time = mono_time_get(mono_time);
|
|
|
|
announces->last_announce_received_timestamp = cur_time;
|
|
|
|
const uint64_t index = announces->index % GCA_MAX_SAVED_ANNOUNCES_PER_GC;
|
|
|
|
GC_Peer_Announce *gc_peer_announce = &announces->peer_announces[index];
|
|
|
|
gc_peer_announce->base_announce = public_announce->base_announce;
|
|
|
|
gc_peer_announce->timestamp = cur_time;
|
|
|
|
++announces->index;
|
|
|
|
return gc_peer_announce;
|
|
}
|
|
|
|
bool gca_is_valid_announce(const GC_Announce *announce)
|
|
{
|
|
if (announce == nullptr) {
|
|
return false;
|
|
}
|
|
|
|
return announce->tcp_relays_count > 0 || announce->ip_port_is_set;
|
|
}
|
|
|
|
GC_Announces_List *new_gca_list(void)
|
|
{
|
|
return (GC_Announces_List *)calloc(1, sizeof(GC_Announces_List));
|
|
}
|
|
|
|
void kill_gca(GC_Announces_List *announces_list)
|
|
{
|
|
if (announces_list == nullptr) {
|
|
return;
|
|
}
|
|
|
|
GC_Announces *root = announces_list->root_announces;
|
|
|
|
while (root != nullptr) {
|
|
GC_Announces *next = root->next_announce;
|
|
free(root);
|
|
root = next;
|
|
}
|
|
|
|
free(announces_list);
|
|
}
|
|
|
|
/* How long we save a peer's announce before we consider it stale and remove it. */
|
|
#define GCA_ANNOUNCE_SAVE_TIMEOUT 30
|
|
|
|
/* How often we run do_gca() */
|
|
#define GCA_DO_GCA_TIMEOUT 1
|
|
|
|
void do_gca(const Mono_Time *mono_time, GC_Announces_List *gc_announces_list)
|
|
{
|
|
if (gc_announces_list == nullptr) {
|
|
return;
|
|
}
|
|
|
|
if (!mono_time_is_timeout(mono_time, gc_announces_list->last_timeout_check, GCA_DO_GCA_TIMEOUT)) {
|
|
return;
|
|
}
|
|
|
|
gc_announces_list->last_timeout_check = mono_time_get(mono_time);
|
|
|
|
GC_Announces *announces = gc_announces_list->root_announces;
|
|
|
|
while (announces != nullptr) {
|
|
if (mono_time_is_timeout(mono_time, announces->last_announce_received_timestamp, GCA_ANNOUNCE_SAVE_TIMEOUT)) {
|
|
GC_Announces *to_delete = announces;
|
|
announces = announces->next_announce;
|
|
remove_announces(gc_announces_list, to_delete);
|
|
continue;
|
|
}
|
|
|
|
announces = announces->next_announce;
|
|
}
|
|
}
|
|
|
|
void cleanup_gca(GC_Announces_List *gc_announces_list, const uint8_t *chat_id)
|
|
{
|
|
if (gc_announces_list == nullptr || chat_id == nullptr) {
|
|
return;
|
|
}
|
|
|
|
GC_Announces *announces = get_announces_by_chat_id(gc_announces_list, chat_id);
|
|
|
|
if (announces != nullptr) {
|
|
remove_announces(gc_announces_list, announces);
|
|
}
|
|
}
|