forked from Green-Sky/tomato
Green Sky
aae086cc65
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to. 32e67ab4c2 cleanup: use typedef for private message ID's in callback 7b1db6adc1 feat: add message IDs to private group messages 99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests e742deddff feat: Check hashes of Windows dependencies when cross-compiling dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image 14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes ed37616249 docs: Update the Windows cross-compilation section 9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies 19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows 1be311e51f feat: Build the fun utils when cross-compiling to Windows 88133f8446 chore: Strip Windows binaries 3cc0ae7535 refactor: Copy over all of the required static dependencies c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows 74bbac5363 feat: Let CMake create the dll instead of doing so ourselves 246642e9ae feat: Harden Windows cross-compilation 8d431c0d11 chore: Bump Windows build dependency versions e519f7998b fix: Remove unnecessary wsock32 dependency on Windows ed2b60c217 chore: Use a specific non-broken slimcc version. d7f21010a1 chore: Update github actions. e71a68b7f2 docs: Update the list of CMake options 77e08876ff chore: Remove mod and founder from group API naming scheme 12bc042767 docs: add the experimental api build option to INSTALL.md e1fa5cae96 refactor: Rename Queries to Query to align with other enums. be82a3ea30 fix: Correct type for conference offline peer numbers. 0627c36716 test: Add pkgsrc build. 92578afe4b test: Add FreeBSD VM action on GitHub. 52ece0f57b test: Build toxcore on NetBSD (VM). 3fe8ee2c11 chore: Only install tox_private.h on request. 9a8dfa06ab fix: save_compatibility_test failing on big-endian systems 86f5e55578 fix: Don't serve files from websockify. 710eb674a5 fix: Correctly pass extended public keys to group moderation code. 021db7031c refactor: Use `struct`s for extended public/secret keys. a1e999fd80 chore: Compile libsodium reference implementation with compcert. fbe3c19cf5 cleanup: correct a few nullable annotations 623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`. c71567dc18 fix: Pass array, not array pointer, to `memcmp`. 9b46a08144 cleanup: Never pass `void*` directly to `memcpy`. 5d7b7a7bbc refactor: Use tox rng to seed the keypair generation. 961891d568 cleanup: Small improvements found by PVS Studio. 8201019f0d chore: Disable NGC saving by default, enable through Tox_Options. 5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`. ca4606d49d refactor: Use strong typedef for NGC peer id. 442213b722 cleanup: Simplify custom packet length check in NGC. 08d3393def fix: Correct a few potential null derefs in bootstrap daemon. b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope. dab5fe44b9 fix: Zero out stack-allocated secret key before return. f058103299 refactor: Make prune_gc_sanctions_list more obviously correct. 3ba7a0dec9 docs: Add static analysis tool list to README. 8d0811a0f3 docs: Run prettier-markdown on markdown files. 969e3a2bfc refactor: Fix network test not using the strong typedef 93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`. 9fe18b176f fix: Fix some false positive from PVS Studio. 7c44379ccb cleanup: Check that WINXP macro exists before comparing it. 5c93231bef refactor: Make tox mutex non-recursive. aacff73939 docs: Fix up doxyfile. d55fc85ff5 docs: Add more documentation to crypto_core. 5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`. e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests. 34df938f52 chore: Use C++ mode for clang-tidy. 8b05296a78 chore: Check that both gtest and gmock exist for tests. 42010660e1 test: Add slimcc compiler compatibility test. b473630321 chore: Add some comments to the astyle config. b7404f24f6 cleanup: Remove implicit bool conversions. 4e2dba4d9f chore: Reformat sources with astyle. 4359e3a6bc chore: Rename C++ headers to .hh suffixes. 0c05566e58 cleanup: Further `#include` cleanups. 8d29935b7a chore: Only check the bootstrap daemon checksum on release. f70e588bc6 cleanup: Add more `const` where possible. 511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene. 1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module. a975943564 chore: Really fix coverage docker image build. c08409390f chore: Fix post-submit coverage image. 39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s. d94246a906 fix: partially fix a bug that prevented group part messages from sending. eeaa039222 chore: Fix rpm build; add a CI check for it. 8328449c1a chore: Speed up docker builds a bit by reducing layer count. d6d67d56f3 cleanup: Add `const` where possible in auto tests. 6aa9e6850d cleanup: Minor cleanup of event unpack code. bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`. 203e1af81e fix: a few off by one errors in group autotests 5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`. 662c2140f3 test: Add goblint static analyser. 8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`. a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`. 6370d0f15d cleanup: Expand the `Tox_Options` accessor macros. 14a1a0b9bd cleanup: Remove plan9 support. a05dccad13 test: Add a simple new/delete test for Tox. 1cdcf938b9 cleanup: Add comment after every `#endif`. ba99d4dc4b test: Fix comment I broke in the events test PR. e07248debb refactor: Migrate auto_tests to new events API. bdd42b5452 refactor: Add common msgpack array packer with callback. 3c659f5288 cleanup: Rename group to conference in groupav documentation. 89957be230 cleanup: Ensure handler params are named after callback params. c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks. e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events. 5e2c8cabc1 cleanup: make some improvements to group moderation test 259de4867e cleanup: Remove `bin_pack_{new,free}`. 21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion 16809dc36e feat: Add dht_get_nodes_response event to the events system. git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
370 lines
11 KiB
C
370 lines
11 KiB
C
/* SPDX-License-Identifier: GPL-3.0-or-later
|
|
* Copyright © 2016-2018 The TokTok team.
|
|
* Copyright © 2013 Tox project.
|
|
* Copyright © 2013 plutooo
|
|
*/
|
|
|
|
/**
|
|
* Buffered pinging using cyclic arrays.
|
|
*/
|
|
#include "ping.h"
|
|
|
|
#include <string.h>
|
|
|
|
#include "DHT.h"
|
|
#include "attributes.h"
|
|
#include "ccompat.h"
|
|
#include "crypto_core.h"
|
|
#include "mem.h"
|
|
#include "mono_time.h"
|
|
#include "network.h"
|
|
#include "ping_array.h"
|
|
|
|
#define PING_NUM_MAX 512
|
|
|
|
/** Maximum newly announced nodes to ping per TIME_TO_PING seconds. */
|
|
#define MAX_TO_PING 32
|
|
|
|
/** Ping newly announced nodes to ping per TIME_TO_PING seconds*/
|
|
#define TIME_TO_PING 2
|
|
|
|
struct Ping {
|
|
const Mono_Time *mono_time;
|
|
const Random *rng;
|
|
DHT *dht;
|
|
|
|
Ping_Array *ping_array;
|
|
Node_format to_ping[MAX_TO_PING];
|
|
uint64_t last_to_ping;
|
|
};
|
|
|
|
#define PING_PLAIN_SIZE (1 + sizeof(uint64_t))
|
|
#define DHT_PING_SIZE (1 + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE + PING_PLAIN_SIZE + CRYPTO_MAC_SIZE)
|
|
#define PING_DATA_SIZE (CRYPTO_PUBLIC_KEY_SIZE + sizeof(IP_Port))
|
|
|
|
void ping_send_request(Ping *ping, const IP_Port *ipp, const uint8_t *public_key)
|
|
{
|
|
uint8_t pk[DHT_PING_SIZE];
|
|
int rc;
|
|
uint64_t ping_id;
|
|
|
|
if (pk_equal(public_key, dht_get_self_public_key(ping->dht))) {
|
|
return;
|
|
}
|
|
|
|
// generate key to encrypt ping_id with recipient privkey
|
|
const uint8_t *shared_key = dht_get_shared_key_sent(ping->dht, public_key);
|
|
// Generate random ping_id.
|
|
uint8_t data[PING_DATA_SIZE];
|
|
pk_copy(data, public_key);
|
|
memcpy(data + CRYPTO_PUBLIC_KEY_SIZE, ipp, sizeof(IP_Port));
|
|
ping_id = ping_array_add(ping->ping_array, ping->mono_time, ping->rng, data, sizeof(data));
|
|
|
|
if (ping_id == 0) {
|
|
return;
|
|
}
|
|
|
|
uint8_t ping_plain[PING_PLAIN_SIZE];
|
|
ping_plain[0] = NET_PACKET_PING_REQUEST;
|
|
memcpy(ping_plain + 1, &ping_id, sizeof(ping_id));
|
|
|
|
pk[0] = NET_PACKET_PING_REQUEST;
|
|
pk_copy(pk + 1, dht_get_self_public_key(ping->dht)); // Our pubkey
|
|
random_nonce(ping->rng, pk + 1 + CRYPTO_PUBLIC_KEY_SIZE); // Generate new nonce
|
|
|
|
rc = encrypt_data_symmetric(shared_key,
|
|
pk + 1 + CRYPTO_PUBLIC_KEY_SIZE,
|
|
ping_plain, sizeof(ping_plain),
|
|
pk + 1 + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE);
|
|
|
|
if (rc != PING_PLAIN_SIZE + CRYPTO_MAC_SIZE) {
|
|
return;
|
|
}
|
|
|
|
// We never check this return value and failures in sendpacket are already logged
|
|
sendpacket(dht_get_net(ping->dht), ipp, pk, sizeof(pk));
|
|
}
|
|
|
|
non_null()
|
|
static int ping_send_response(const Ping *ping, const IP_Port *ipp, const uint8_t *public_key,
|
|
uint64_t ping_id, const uint8_t *shared_encryption_key)
|
|
{
|
|
uint8_t pk[DHT_PING_SIZE];
|
|
|
|
if (pk_equal(public_key, dht_get_self_public_key(ping->dht))) {
|
|
return 1;
|
|
}
|
|
|
|
uint8_t ping_plain[PING_PLAIN_SIZE];
|
|
ping_plain[0] = NET_PACKET_PING_RESPONSE;
|
|
memcpy(ping_plain + 1, &ping_id, sizeof(ping_id));
|
|
|
|
pk[0] = NET_PACKET_PING_RESPONSE;
|
|
pk_copy(pk + 1, dht_get_self_public_key(ping->dht)); // Our pubkey
|
|
random_nonce(ping->rng, pk + 1 + CRYPTO_PUBLIC_KEY_SIZE); // Generate new nonce
|
|
|
|
// Encrypt ping_id using recipient privkey
|
|
const int rc = encrypt_data_symmetric(shared_encryption_key,
|
|
pk + 1 + CRYPTO_PUBLIC_KEY_SIZE,
|
|
ping_plain, sizeof(ping_plain),
|
|
pk + 1 + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE);
|
|
|
|
if (rc != PING_PLAIN_SIZE + CRYPTO_MAC_SIZE) {
|
|
return 1;
|
|
}
|
|
|
|
return sendpacket(dht_get_net(ping->dht), ipp, pk, sizeof(pk));
|
|
}
|
|
|
|
non_null()
|
|
static int handle_ping_request(void *object, const IP_Port *source, const uint8_t *packet, uint16_t length,
|
|
void *userdata)
|
|
{
|
|
DHT *dht = (DHT *)object;
|
|
|
|
if (length != DHT_PING_SIZE) {
|
|
return 1;
|
|
}
|
|
|
|
Ping *ping = dht_get_ping(dht);
|
|
|
|
if (pk_equal(packet + 1, dht_get_self_public_key(ping->dht))) {
|
|
return 1;
|
|
}
|
|
|
|
const uint8_t *shared_key = dht_get_shared_key_recv(dht, packet + 1);
|
|
|
|
uint8_t ping_plain[PING_PLAIN_SIZE];
|
|
|
|
// Decrypt ping_id
|
|
const int rc = decrypt_data_symmetric(shared_key,
|
|
packet + 1 + CRYPTO_PUBLIC_KEY_SIZE,
|
|
packet + 1 + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE,
|
|
PING_PLAIN_SIZE + CRYPTO_MAC_SIZE,
|
|
ping_plain);
|
|
|
|
if (rc != sizeof(ping_plain)) {
|
|
return 1;
|
|
}
|
|
|
|
if (ping_plain[0] != NET_PACKET_PING_REQUEST) {
|
|
return 1;
|
|
}
|
|
|
|
uint64_t ping_id;
|
|
memcpy(&ping_id, ping_plain + 1, sizeof(ping_id));
|
|
// Send response
|
|
ping_send_response(ping, source, packet + 1, ping_id, shared_key);
|
|
ping_add(ping, packet + 1, source);
|
|
|
|
return 0;
|
|
}
|
|
|
|
non_null()
|
|
static int handle_ping_response(void *object, const IP_Port *source, const uint8_t *packet, uint16_t length,
|
|
void *userdata)
|
|
{
|
|
DHT *dht = (DHT *)object;
|
|
int rc;
|
|
|
|
if (length != DHT_PING_SIZE) {
|
|
return 1;
|
|
}
|
|
|
|
Ping *ping = dht_get_ping(dht);
|
|
|
|
if (pk_equal(packet + 1, dht_get_self_public_key(ping->dht))) {
|
|
return 1;
|
|
}
|
|
|
|
// generate key to encrypt ping_id with recipient privkey
|
|
const uint8_t *shared_key = dht_get_shared_key_sent(ping->dht, packet + 1);
|
|
|
|
uint8_t ping_plain[PING_PLAIN_SIZE];
|
|
// Decrypt ping_id
|
|
rc = decrypt_data_symmetric(shared_key,
|
|
packet + 1 + CRYPTO_PUBLIC_KEY_SIZE,
|
|
packet + 1 + CRYPTO_PUBLIC_KEY_SIZE + CRYPTO_NONCE_SIZE,
|
|
PING_PLAIN_SIZE + CRYPTO_MAC_SIZE,
|
|
ping_plain);
|
|
|
|
if (rc != sizeof(ping_plain)) {
|
|
return 1;
|
|
}
|
|
|
|
if (ping_plain[0] != NET_PACKET_PING_RESPONSE) {
|
|
return 1;
|
|
}
|
|
|
|
uint64_t ping_id;
|
|
memcpy(&ping_id, ping_plain + 1, sizeof(ping_id));
|
|
uint8_t data[PING_DATA_SIZE];
|
|
|
|
if (ping_array_check(ping->ping_array, ping->mono_time, data, sizeof(data), ping_id) != sizeof(data)) {
|
|
return 1;
|
|
}
|
|
|
|
if (!pk_equal(packet + 1, data)) {
|
|
return 1;
|
|
}
|
|
|
|
IP_Port ipp;
|
|
memcpy(&ipp, data + CRYPTO_PUBLIC_KEY_SIZE, sizeof(IP_Port));
|
|
|
|
if (!ipport_equal(&ipp, source)) {
|
|
return 1;
|
|
}
|
|
|
|
addto_lists(dht, source, packet + 1);
|
|
return 0;
|
|
}
|
|
|
|
/** @brief Check if public_key with ip_port is in the list.
|
|
*
|
|
* return true if it is.
|
|
* return false if it isn't.
|
|
*/
|
|
non_null()
|
|
static bool in_list(const Client_data *list, uint16_t length, const Mono_Time *mono_time, const uint8_t *public_key,
|
|
const IP_Port *ip_port)
|
|
{
|
|
for (unsigned int i = 0; i < length; ++i) {
|
|
if (pk_equal(list[i].public_key, public_key)) {
|
|
const IPPTsPng *ipptp;
|
|
|
|
if (net_family_is_ipv4(ip_port->ip.family)) {
|
|
ipptp = &list[i].assoc4;
|
|
} else {
|
|
ipptp = &list[i].assoc6;
|
|
}
|
|
|
|
if (!mono_time_is_timeout(mono_time, ipptp->timestamp, BAD_NODE_TIMEOUT)
|
|
&& ipport_equal(&ipptp->ip_port, ip_port)) {
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/** @brief Add nodes to the to_ping list.
|
|
* All nodes in this list are pinged every TIME_TO_PING seconds
|
|
* and are then removed from the list.
|
|
* If the list is full the nodes farthest from our public_key are replaced.
|
|
* The purpose of this list is to enable quick integration of new nodes into the
|
|
* network while preventing amplification attacks.
|
|
*
|
|
* @retval 0 if node was added.
|
|
* @retval -1 if node was not added.
|
|
*/
|
|
int32_t ping_add(Ping *ping, const uint8_t *public_key, const IP_Port *ip_port)
|
|
{
|
|
if (!ip_isset(&ip_port->ip)) {
|
|
return -1;
|
|
}
|
|
|
|
if (!node_addable_to_close_list(ping->dht, public_key, ip_port)) {
|
|
return -1;
|
|
}
|
|
|
|
if (in_list(dht_get_close_clientlist(ping->dht), LCLIENT_LIST, ping->mono_time, public_key, ip_port)) {
|
|
return -1;
|
|
}
|
|
|
|
IP_Port temp;
|
|
|
|
if (dht_getfriendip(ping->dht, public_key, &temp) == 0) {
|
|
ping_send_request(ping, ip_port, public_key);
|
|
return -1;
|
|
}
|
|
|
|
for (unsigned int i = 0; i < MAX_TO_PING; ++i) {
|
|
if (!ip_isset(&ping->to_ping[i].ip_port.ip)) {
|
|
memcpy(ping->to_ping[i].public_key, public_key, CRYPTO_PUBLIC_KEY_SIZE);
|
|
ipport_copy(&ping->to_ping[i].ip_port, ip_port);
|
|
return 0;
|
|
}
|
|
|
|
if (pk_equal(ping->to_ping[i].public_key, public_key)) {
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
if (add_to_list(ping->to_ping, MAX_TO_PING, public_key, ip_port, dht_get_self_public_key(ping->dht))) {
|
|
return 0;
|
|
}
|
|
|
|
return -1;
|
|
}
|
|
|
|
/** @brief Ping all the valid nodes in the to_ping list every TIME_TO_PING seconds.
|
|
* This function must be run at least once every TIME_TO_PING seconds.
|
|
*/
|
|
void ping_iterate(Ping *ping)
|
|
{
|
|
if (!mono_time_is_timeout(ping->mono_time, ping->last_to_ping, TIME_TO_PING)) {
|
|
return;
|
|
}
|
|
|
|
if (!ip_isset(&ping->to_ping[0].ip_port.ip)) {
|
|
return;
|
|
}
|
|
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < MAX_TO_PING; ++i) {
|
|
if (!ip_isset(&ping->to_ping[i].ip_port.ip)) {
|
|
break;
|
|
}
|
|
|
|
if (!node_addable_to_close_list(ping->dht, ping->to_ping[i].public_key, &ping->to_ping[i].ip_port)) {
|
|
continue;
|
|
}
|
|
|
|
ping_send_request(ping, &ping->to_ping[i].ip_port, ping->to_ping[i].public_key);
|
|
ip_reset(&ping->to_ping[i].ip_port.ip);
|
|
}
|
|
|
|
if (i != 0) {
|
|
ping->last_to_ping = mono_time_get(ping->mono_time);
|
|
}
|
|
}
|
|
|
|
Ping *ping_new(const Memory *mem, const Mono_Time *mono_time, const Random *rng, DHT *dht)
|
|
{
|
|
Ping *ping = (Ping *)mem_alloc(mem, sizeof(Ping));
|
|
|
|
if (ping == nullptr) {
|
|
return nullptr;
|
|
}
|
|
|
|
ping->ping_array = ping_array_new(mem, PING_NUM_MAX, PING_TIMEOUT);
|
|
|
|
if (ping->ping_array == nullptr) {
|
|
mem_delete(mem, ping);
|
|
return nullptr;
|
|
}
|
|
|
|
ping->mono_time = mono_time;
|
|
ping->rng = rng;
|
|
ping->dht = dht;
|
|
networking_registerhandler(dht_get_net(ping->dht), NET_PACKET_PING_REQUEST, &handle_ping_request, dht);
|
|
networking_registerhandler(dht_get_net(ping->dht), NET_PACKET_PING_RESPONSE, &handle_ping_response, dht);
|
|
|
|
return ping;
|
|
}
|
|
|
|
void ping_kill(const Memory *mem, Ping *ping)
|
|
{
|
|
if (ping == nullptr) {
|
|
return;
|
|
}
|
|
|
|
networking_registerhandler(dht_get_net(ping->dht), NET_PACKET_PING_REQUEST, nullptr, nullptr);
|
|
networking_registerhandler(dht_get_net(ping->dht), NET_PACKET_PING_RESPONSE, nullptr, nullptr);
|
|
ping_array_kill(ping->ping_array);
|
|
|
|
mem_delete(mem, ping);
|
|
}
|