forked from Green-Sky/tomato
Green Sky
aae086cc65
b03b571272 fix: flaky tcp test This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to.
32e67ab4c2 cleanup: use typedef for private message ID's in callback
7b1db6adc1 feat: add message IDs to private group messages
99e0bcc27d refactor: Observers/ignored peers can now send and receive custom packets
b3c3c49d26 fix: Disable IPv6 in Windows cross-compilation tests
e742deddff feat: Check hashes of Windows dependencies when cross-compiling
dfb9a0b02b fix: Test the current Windows Dockerfile, not an old Dockerhub image
14de93ccec chore: Use WineHQ's Wine as Debian Bookworm's crashes
ed37616249 docs: Update the Windows cross-compilation section
9bb79c174f cleanup: Remove a couple of unnecessary misc_tools dependencies
19475adb70 chore: Statically link OpenMP into the cracker fun util on Windows
1be311e51f feat: Build the fun utils when cross-compiling to Windows
88133f8446 chore: Strip Windows binaries
3cc0ae7535 refactor: Copy over all of the required static dependencies
c4fa8f7fb1 feat: Generate .def, .exp and .lib files when building for Windows
74bbac5363 feat: Let CMake create the dll instead of doing so ourselves
246642e9ae feat: Harden Windows cross-compilation
8d431c0d11 chore: Bump Windows build dependency versions
e519f7998b fix: Remove unnecessary wsock32 dependency on Windows
ed2b60c217 chore: Use a specific non-broken slimcc version.
d7f21010a1 chore: Update github actions.
e71a68b7f2 docs: Update the list of CMake options
77e08876ff chore: Remove mod and founder from group API naming scheme
12bc042767 docs: add the experimental api build option to INSTALL.md
e1fa5cae96 refactor: Rename Queries to Query to align with other enums.
be82a3ea30 fix: Correct type for conference offline peer numbers.
0627c36716 test: Add pkgsrc build.
92578afe4b test: Add FreeBSD VM action on GitHub.
52ece0f57b test: Build toxcore on NetBSD (VM).
3fe8ee2c11 chore: Only install tox_private.h on request.
9a8dfa06ab fix: save_compatibility_test failing on big-endian systems
86f5e55578 fix: Don't serve files from websockify.
710eb674a5 fix: Correctly pass extended public keys to group moderation code.
021db7031c refactor: Use `struct`s for extended public/secret keys.
a1e999fd80 chore: Compile libsodium reference implementation with compcert.
fbe3c19cf5 cleanup: correct a few nullable annotations
623e3ee5c3 cleanup: Don't use `memcpy` to cast arbitrary `struct`s to `uint8_t[]`.
c71567dc18 fix: Pass array, not array pointer, to `memcmp`.
9b46a08144 cleanup: Never pass `void*` directly to `memcpy`.
5d7b7a7bbc refactor: Use tox rng to seed the keypair generation.
961891d568 cleanup: Small improvements found by PVS Studio.
8201019f0d chore: Disable NGC saving by default, enable through Tox_Options.
5dd9ee3f65 cleanup: Replace pointer arithmetic with explicit `&arr[i]`.
ca4606d49d refactor: Use strong typedef for NGC peer id.
442213b722 cleanup: Simplify custom packet length check in NGC.
08d3393def fix: Correct a few potential null derefs in bootstrap daemon.
b9877b32b0 fix: Add missing memunlock of local variable when it goes out of scope.
dab5fe44b9 fix: Zero out stack-allocated secret key before return.
f058103299 refactor: Make prune_gc_sanctions_list more obviously correct.
3ba7a0dec9 docs: Add static analysis tool list to README.
8d0811a0f3 docs: Run prettier-markdown on markdown files.
969e3a2bfc refactor: Fix network test not using the strong typedef
93c83fbc7c refactor: Use strong typedef instead of struct for `Socket`.
9fe18b176f fix: Fix some false positive from PVS Studio.
7c44379ccb cleanup: Check that WINXP macro exists before comparing it.
5c93231bef refactor: Make tox mutex non-recursive.
aacff73939 docs: Fix up doxyfile.
d55fc85ff5 docs: Add more documentation to crypto_core.
5bdaaaedb6 refactor: Remove `Tox *` from `tox_dispatch`.
e202341e76 refactor: Don't rely on tox_dispatch passing tox in tests.
34df938f52 chore: Use C++ mode for clang-tidy.
8b05296a78 chore: Check that both gtest and gmock exist for tests.
42010660e1 test: Add slimcc compiler compatibility test.
b473630321 chore: Add some comments to the astyle config.
b7404f24f6 cleanup: Remove implicit bool conversions.
4e2dba4d9f chore: Reformat sources with astyle.
4359e3a6bc chore: Rename C++ headers to .hh suffixes.
0c05566e58 cleanup: Further `#include` cleanups.
8d29935b7a chore: Only check the bootstrap daemon checksum on release.
f70e588bc6 cleanup: Add more `const` where possible.
511bfe39c8 cleanup: Use Bazel modules to enforce proper `#include` hygiene.
1710a0d091 refactor: Move pack/unpack `IP_Port` from DHT into network module.
a975943564 chore: Really fix coverage docker image build.
c08409390f chore: Fix post-submit coverage image.
39aadf8922 fix: Don't use `memcmp` to compare `IP_Port`s.
d94246a906 fix: partially fix a bug that prevented group part messages from sending.
eeaa039222 chore: Fix rpm build; add a CI check for it.
8328449c1a chore: Speed up docker builds a bit by reducing layer count.
d6d67d56f3 cleanup: Add `const` where possible in auto tests.
6aa9e6850d cleanup: Minor cleanup of event unpack code.
bdf460a3a9 refactor: Rename `system_{memory,...}` to `os_{memory,...}`.
203e1af81e fix: a few off by one errors in group autotests
5c093c4888 cleanup: Remove all uses of `SIZEOF_VLA`.
662c2140f3 test: Add goblint static analyser.
8f07755834 cleanup: Use `memzero(x, s)` instead of `memset(x, 0, s)`.
a7258e40cf cleanup: Use explicit 0 instead of `PACKET_ID_PADDING`.
6370d0f15d cleanup: Expand the `Tox_Options` accessor macros.
14a1a0b9bd cleanup: Remove plan9 support.
a05dccad13 test: Add a simple new/delete test for Tox.
1cdcf938b9 cleanup: Add comment after every `#endif`.
ba99d4dc4b test: Fix comment I broke in the events test PR.
e07248debb refactor: Migrate auto_tests to new events API.
bdd42b5452 refactor: Add common msgpack array packer with callback.
3c659f5288 cleanup: Rename group to conference in groupav documentation.
89957be230 cleanup: Ensure handler params are named after callback params.
c650d9d345 refactor: Pass `this` pointer as first param to s11n callbacks.
e7fb91ddb8 refactor: Allow NULL pointers for byte arrays in events.
5e2c8cabc1 cleanup: make some improvements to group moderation test
259de4867e cleanup: Remove `bin_pack_{new,free}`.
21a8ff5895 cleanup: skip a do_gc iteration before removing peers marked for deletion
16809dc36e feat: Add dht_get_nodes_response event to the events system.
git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: b03b5712720de9a9901ea12fd741f177327a7021
167 lines
6.4 KiB
Makefile
167 lines
6.4 KiB
Makefile
# See the following PDF for descriptions of each of the rules:
|
|
# http://my.ldrasoftware.co.uk/repository/miscellaneous/Misra-c_2012_compliance.pdf
|
|
|
|
# There should be no unused parameters in functions.
|
|
#
|
|
# Reason: callbacks often have unused parameters. Marking them explicitly isn't
|
|
# very helpful. A better diagnostic should be able to identify functions never
|
|
# used as callbacks and warn about unused parameters in those.
|
|
SUPPRESSIONS = 2.7
|
|
# The character sequences /* and // shall not be used within a comment.
|
|
#
|
|
# Reason: "//" appears in code examples and "http://" inside comments.
|
|
SUPPRESSIONS += 3.1
|
|
# Identifiers declared in the same scope and name space shall be distinct.
|
|
# Identifier not unique within 31 characters.
|
|
#
|
|
# Reason: Compilers we use allow longer identifier names.
|
|
SUPPRESSIONS += 5.2
|
|
# Macro identifiers shall be distinct.
|
|
# Identifier matches macro name in 31 chars.
|
|
#
|
|
# Reason: Compilers we use allow longer identifier names.
|
|
SUPPRESSIONS += 5.4
|
|
# The lowercase character 'l' shall not be used in a literal suffix.
|
|
#
|
|
# Reason: False positive. We don't use 'l', but this flags 'ulOutBufLen'.
|
|
SUPPRESSIONS += 7.3
|
|
# Operands shall not be of an inappropriate essential type.
|
|
#
|
|
# Reason: This diagnoses (1 << n) and wants us to use (1u << n). That's fair,
|
|
# but this diagnostic is impossible to fix for ((1u << n) >> m).
|
|
SUPPRESSIONS += 10.1
|
|
# Both operands of an operator in which the usual arithmetic conversions are performed shall have the same essential type category.
|
|
#
|
|
# Reason: This warns about ((unsigned)n == 0) and other constant comparisons.
|
|
SUPPRESSIONS += 10.4
|
|
# The value of a composite expression shall not be cast to a different essential type category or a wider essential type.
|
|
#
|
|
# TODO(iphydf): investigate.
|
|
SUPPRESSIONS += 10.8
|
|
# A conversion should not be performed from pointer to void into pointer to object.
|
|
#
|
|
# Reason: this is needed for generic callbacks to make any sense.
|
|
SUPPRESSIONS += 11.5
|
|
# The precedence of operators within expressions should be made explicit.
|
|
#
|
|
# Reason: this asks us to add a lot of extra parentheses that don't really help
|
|
# readability. We expect people to know basic precedence. GCC has a better
|
|
# diagnostic requiring parentheses around less common operators.
|
|
SUPPRESSIONS += 12.1
|
|
# The comma operator should not be used.
|
|
#
|
|
# Reason: We don't use the comma operator (cimple doesn't even parse it). This is
|
|
# all false positives.
|
|
SUPPRESSIONS += 12.3
|
|
# Evaluation of constant expressions should not lead to unsigned integer wrap-around.
|
|
#
|
|
# Reason: False positives on UINT64_MAX.
|
|
SUPPRESSIONS += 12.4
|
|
# A full expression containing an increment (++) or decrement (--) operator should have no other potential side effects other than that caused by the increment or decrement operator.
|
|
#
|
|
# TODO(iphydf): maybe fix?
|
|
SUPPRESSIONS += 13.3
|
|
# The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type.
|
|
#
|
|
# Reason: We actually follow this rule, but cppcheck's implementation is flawed and has false positives.
|
|
SUPPRESSIONS += 14.4
|
|
# The goto statement should not be used.
|
|
#
|
|
# TODO(iphydf): Get rid of goto.
|
|
SUPPRESSIONS += 15.1
|
|
# A function should have a single point of exit at the end.
|
|
#
|
|
# Reason: This doesn't make code much clearer. Sometimes this is useful for
|
|
# putting all the cleanup code in one spot, but often an early return improves
|
|
# readability.
|
|
SUPPRESSIONS += 15.5
|
|
# All if . . else if constructs shall be terminated with an else statement.
|
|
#
|
|
# TODO(iphydf): Why is this a good idea?
|
|
SUPPRESSIONS += 15.7
|
|
# An unconditional break statement shall terminate every switch-clause.
|
|
#
|
|
# Reason: This conflicts with "break unused after abort()". MISRA doesn't allow
|
|
# abort(), but we use it, so this rule must be disabled, too.
|
|
SUPPRESSIONS += 16.3
|
|
# Every switch statement shall have a default label.
|
|
#
|
|
# Reason: C compilers have better diagnostics for this (-Wswitch variants).
|
|
SUPPRESSIONS += 16.4
|
|
# The features of <stdarg.h> shall not be used.
|
|
#
|
|
# Reason: We use it for logging.
|
|
SUPPRESSIONS += 17.1
|
|
# Functions shall not call themselves, either directly or indirectly.
|
|
#
|
|
# Reason: Cimple is better at this diagnostic, recognising indirect recursion
|
|
# through callbacks.
|
|
SUPPRESSIONS += 17.2
|
|
# The value returned by a function having non-void return type shall be used.
|
|
#
|
|
# TODO(iphydf): Investigate.
|
|
SUPPRESSIONS += 17.7
|
|
# A function parameter should not be modified.
|
|
#
|
|
# TODO(iphydf): maybe fix?
|
|
SUPPRESSIONS += 17.8
|
|
# The +, -, += and -= operators should not be applied to an expression of pointer type.
|
|
# Use of pointer arithmetic.
|
|
#
|
|
# TODO(iphydf): Someday we won't be using pointer arithmetic.
|
|
SUPPRESSIONS += 18.4
|
|
# Flexible array members shall not be declared.
|
|
#
|
|
# TODO(iphydf): Fix.
|
|
SUPPRESSIONS += 18.7
|
|
# Variable-length array types shall not be used.
|
|
#
|
|
# TODO(iphydf): Fix.
|
|
SUPPRESSIONS += 18.8
|
|
# The union keyword should not be used.
|
|
#
|
|
# TODO(iphydf): Maybe we need a good linter to check that unions are used safely.
|
|
SUPPRESSIONS += 19.2
|
|
# #undef should not be used.
|
|
#
|
|
# Reason: We believe it should be used when #define is used in block scope.
|
|
SUPPRESSIONS += 20.5
|
|
# #define and #undef shall not be used on a reserved identifier or reserved macro name.
|
|
#
|
|
# Reason: Needed for feature test macros like _DEFAULT_SOURCE.
|
|
SUPPRESSIONS += 21.1
|
|
# The memory allocation and deallocation functions of <stdlib.h> shall not be used.
|
|
#
|
|
# Reason: We use malloc/free. Making our own allocators doesn't make the code
|
|
# safer.
|
|
SUPPRESSIONS += 21.3
|
|
# The Standard Library input/output routines shall not be used.
|
|
#
|
|
# Reason: Used in logging.
|
|
SUPPRESSIONS += 21.6
|
|
# The Standard Library termination functions of <stdlib.h> shall not be used.
|
|
# Use of abort, exit, etc.
|
|
#
|
|
# Reason: Used in LOGGER_FATAL.
|
|
SUPPRESSIONS += 21.8
|
|
# The Standard Library functions bsearch and qsort of <stdlib.h> shall not be used.
|
|
#
|
|
# TODO(iphydf): Why not use qsort?
|
|
SUPPRESSIONS += 21.9
|
|
# The Standard Library time and date routines shall not be used.
|
|
#
|
|
# TODO(iphydf): Probably stop using time().
|
|
SUPPRESSIONS += 21.10
|
|
|
|
CPPFLAGS := -DCMP_NO_FLOAT=1 -DMIN_LOGGER_LEVEL=LOGGER_LEVEL_TRACE
|
|
|
|
FIND_FLAGS := -name "*.c" \
|
|
-and -not -wholename "*/auto_tests/*" \
|
|
-and -not -wholename "*/other/*" \
|
|
-and -not -wholename "*/super_donators/*" \
|
|
-and -not -wholename "*/third_party/*"
|
|
SOURCES := $(shell find /src/workspace/c-toxcore $(FIND_FLAGS))
|
|
|
|
analyse: $(DUMPS:.dump=.diag)
|
|
cppcheck --error-exitcode=1 -j8 --addon=misra --suppress=doubleFree $(patsubst %,--suppress=misra-c2012-%,$(SUPPRESSIONS)) $(CPPFLAGS) $(SOURCES)
|