Tha_14/toxic
1
0
Fork 0
mirror of https://github.com/Tha14/toxic.git synced 2024-11-14 23:13:01 +01:00
Code Issues Projects Releases Wiki Activity

These strlen() calls are unncessary

Browse Source
This commit is contained in:
Jfreegman 2016-09-18 11:34:13 -04:00
parent 5e20e6b279
commit 1f8c11a33a
No known key found for this signature in database
GPG Key ID: 3627F3144076AE63
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/bootstrap.c
View File

@ -89,8 +89,7 @@ int load_DHT_nodelist(void)
/* Extract IPv4 address */ /* Extract IPv4 address */
const char *ip_start = strstr(line_start, IPV4_JSON_VALUE); const char *ip_start = strstr(line_start, IPV4_JSON_VALUE);
// TODO: These strlen() calls are very inefficient. Should probably keep track of length manually. if (ip_start == NULL) {
if (ip_start == NULL || strlen(ip_start) < IPV4_JSON_VALUE_LEN) {
continue; continue;
} }
@ -108,7 +107,7 @@ int load_DHT_nodelist(void)
/* Extract port */ /* Extract port */
const char *port_start = strstr(ip_start, PORT_JSON_VALUE); const char *port_start = strstr(ip_start, PORT_JSON_VALUE);
if (!port_start || strlen(port_start) < PORT_JSON_VALUE_LEN) { if (!port_start) {
continue; continue;
} }
@ -131,7 +130,7 @@ int load_DHT_nodelist(void)
/* Extract key */ /* Extract key */
const char *key_start = strstr(port_start, KEY_JSON_VALUE); const char *key_start = strstr(port_start, KEY_JSON_VALUE);
if (!key_start || strlen(key_start) < KEY_JSON_VALUE_LEN) { if (!key_start) {
continue; continue;
} }