Squashed 'external/toxcore/c-toxcore/' changes from c9cdae001..9ed2fa80d

9ed2fa80d fix(toxav): remove extra copy of video frame on encode
de30cf3ad docs: Add new file kinds, that should be useful to all clients.
d5b5e879d fix(DHT): Correct node skipping logic timed out nodes.
30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch.
8fdbb0b50 style: Format parameter lists in event handlers.
d00dee12b refactor: Add warning logs when losing chat invites.
b144e8db1 feat: Add a way to look up a file number by ID.
849281ea0 feat: Add a way to fetch groups by chat ID.
a2c177396 refactor: Harden event system and improve type safety.
8f5caa656 refactor: Add MessagePack string support to bin_pack.
34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner.
f7b068010 refactor: Add nullability annotations to event headers.
788abe651 refactor(toxav): Use system allocator for mutexes.
2e4b423eb refactor: Use specific typedefs for public API arrays.
2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354
2f87ac67b feat: Add Event Loop abstraction (Ev).
f8dfc38d8 test: Fix data race in ToxScenario virtual_clock.
38313921e test(TCP): Add regression test for TCP priority queue integrity.
f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex.
ad054511e refactor: Internalize DHT structs and add debug helpers.
8b467cc96 fix: Prevent potential integer overflow in group chat handshake.
4962bdbb8 test: Improve TCP simulation and add tests
5f0227093 refactor: Allow nullable data in group chat handlers.
e97b18ea9 chore: Improve Windows Docker support.
b14943bbd refactor: Move Logger out of Messenger into Tox.
dd3136250 cleanup: Apply nullability qualifiers to C++ codebase.
1849f70fc refactor: Extract low-level networking code to net and os_network.
8fec75421 refactor: Delete tox_random, align on rng and os_random.
a03ae8051 refactor: Delete tox_memory, align on mem and os_memory.
4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code.
72452f2ae test: Add some more tests for onion and shared key cache.
d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it.
b6f5b9fc5 test: Add some benchmarks for various high level things.
8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier
d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around
REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode

git-subtree-dir: external/toxcore/c-toxcore
git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8

toxav/ring_buffer_test.cc

@@ -4,8 +4,11 @@
 
 #include <algorithm>
 #include <cassert>
+#include <cstdint>
 #include <vector>
 
+#include "../toxcore/attributes.h"
+
 namespace {
 
 template <typename T>
@@ -23,37 +26,39 @@ public:
 
     bool full() const { return rb_full(rb_); }
     bool empty() const { return rb_empty(rb_); }
-    T *write(T *p) { return static_cast<T *>(rb_write(rb_, p)); }
-    bool read(T **p)
+    T *_Nullable write(T *_Nullable p) { return static_cast<T *>(rb_write(rb_, p)); }
+    bool read(T *_Nullable *_Nonnull p)
     {
-        void *vp;
+        void *_Nullable vp;
         bool res = rb_read(rb_, &vp);
         *p = static_cast<T *>(vp);
         return res;
     }
 
-    uint16_t size() const { return rb_size(rb_); }
-    uint16_t data(T **dest) const
+    std::uint16_t size() const { return rb_size(rb_); }
+    std::uint16_t data(T *_Nullable *_Nonnull dest, std::uint16_t dest_size) const
     {
-        std::vector<void *> vdest(size());
-        uint16_t res = rb_data(rb_, vdest.data());
-        for (uint16_t i = 0; i < size(); i++) {
+        const std::uint16_t current_size = std::min(size(), dest_size);
+        std::vector<void *_Nullable> vdest(current_size);
+        const std::uint16_t res = rb_data(rb_, vdest.data(), current_size);
+        for (std::uint16_t i = 0; i < res; i++) {
             dest[i] = static_cast<T *>(vdest.at(i));
         }
         return res;
     }
 
-    bool contains(T *p) const
+    bool contains(T *_Nullable p) const
     {
-        std::vector<T *> elts(size());
-        data(elts.data());
+        const std::uint16_t current_size = size();
+        std::vector<T *_Nullable> elts(current_size);
+        data(elts.data(), current_size);
         return std::find(elts.begin(), elts.end(), p) != elts.end();
     }
 
     bool ok() const { return rb_ != nullptr; }
 
 private:
-    RingBuffer *rb_;
+    RingBuffer *_Nullable rb_;
 };
 
 TEST(RingBuffer, EmptyBufferReportsEmpty)
@@ -211,4 +216,27 @@ TEST(RingBuffer, SizeIsLimitedByMaxSize)
     EXPECT_EQ(rb.size(), 4);
 }
 
+TEST(RingBuffer, NewWithInvalidSizeReturnsNull)
+{
+    EXPECT_EQ(nullptr, rb_new(-1));
+    EXPECT_EQ(nullptr, rb_new(65535));
+}
+
+TEST(RingBuffer, DataWithSmallerDestSizeIsTruncated)
+{
+    TypedRingBuffer<int *> rb(4);
+    ASSERT_TRUE(rb.ok());
+    int values[] = {1, 2, 3, 4};
+    rb.write(&values[0]);
+    rb.write(&values[1]);
+    rb.write(&values[2]);
+    rb.write(&values[3]);
+
+    int *dest[2];
+    std::uint16_t res = rb.data(dest, 2);
+    EXPECT_EQ(res, 2);
+    EXPECT_EQ(dest[0], &values[0]);
+    EXPECT_EQ(dest[1], &values[1]);
+}
+
 }  // namespace