9ed2fa80d fix(toxav): remove extra copy of video frame on encode de30cf3ad docs: Add new file kinds, that should be useful to all clients. d5b5e879d fix(DHT): Correct node skipping logic timed out nodes. 30e71fe97 refactor: Generate event dispatch functions and add tox_events_dispatch. 8fdbb0b50 style: Format parameter lists in event handlers. d00dee12b refactor: Add warning logs when losing chat invites. b144e8db1 feat: Add a way to look up a file number by ID. 849281ea0 feat: Add a way to fetch groups by chat ID. a2c177396 refactor: Harden event system and improve type safety. 8f5caa656 refactor: Add MessagePack string support to bin_pack. 34e8d5ad5 chore: Add GitHub CodeQL workflow and local Docker runner. f7b068010 refactor: Add nullability annotations to event headers. 788abe651 refactor(toxav): Use system allocator for mutexes. 2e4b423eb refactor: Use specific typedefs for public API arrays. 2baf34775 docs(toxav): update idle iteration interval see 679444751876fa3882a717772918ebdc8f083354 2f87ac67b feat: Add Event Loop abstraction (Ev). f8dfc38d8 test: Fix data race in ToxScenario virtual_clock. 38313921e test(TCP): Add regression test for TCP priority queue integrity. f94a50d9a refactor(toxav): Replace mutable_mutex with dynamically allocated mutex. ad054511e refactor: Internalize DHT structs and add debug helpers. 8b467cc96 fix: Prevent potential integer overflow in group chat handshake. 4962bdbb8 test: Improve TCP simulation and add tests 5f0227093 refactor: Allow nullable data in group chat handlers. e97b18ea9 chore: Improve Windows Docker support. b14943bbd refactor: Move Logger out of Messenger into Tox. dd3136250 cleanup: Apply nullability qualifiers to C++ codebase. 1849f70fc refactor: Extract low-level networking code to net and os_network. 8fec75421 refactor: Delete tox_random, align on rng and os_random. a03ae8051 refactor: Delete tox_memory, align on mem and os_memory. 4c88fed2c refactor: Use `std::` prefixes more consistently in C++ code. 72452f2ae test: Add some more tests for onion and shared key cache. d5a51b09a cleanup: Use tox_attributes.h in tox_private.h and install it. b6f5b9fc5 test: Add some benchmarks for various high level things. 8a8d02785 test(support): Introduce threaded Tox runner and simulation barrier d68d1d095 perf(toxav): optimize audio and video intermediate buffers by keeping them around REVERT: c9cdae001 fix(toxav): remove extra copy of video frame on encode git-subtree-dir: external/toxcore/c-toxcore git-subtree-split: 9ed2fa80d582c714d6bdde6a7648220a92cddff8
185 lines
5.9 KiB
C++
185 lines
5.9 KiB
C++
// clang-format off
|
|
#include "../testing/support/public/simulated_environment.hh"
|
|
#include "ping_array.h"
|
|
// clang-format on
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "attributes.h"
|
|
#include "crypto_core_test_util.hh"
|
|
#include "mono_time.h"
|
|
|
|
namespace {
|
|
|
|
using tox::test::SimulatedEnvironment;
|
|
|
|
struct Ping_Array_Deleter {
|
|
void operator()(Ping_Array *_Nullable arr) { ping_array_kill(arr); }
|
|
};
|
|
|
|
using Ping_Array_Ptr = std::unique_ptr<Ping_Array, Ping_Array_Deleter>;
|
|
|
|
struct Mono_Time_Deleter {
|
|
Mono_Time_Deleter(Memory mem)
|
|
: mem_(mem)
|
|
{
|
|
}
|
|
void operator()(Mono_Time *_Nullable arr) { mono_time_free(&mem_, arr); }
|
|
|
|
private:
|
|
Memory mem_;
|
|
};
|
|
|
|
using Mono_Time_Ptr = std::unique_ptr<Mono_Time, Mono_Time_Deleter>;
|
|
|
|
TEST(PingArray, MinimumTimeoutIsOne)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
EXPECT_EQ(ping_array_new(&c_mem, 1, 0), nullptr);
|
|
EXPECT_NE(Ping_Array_Ptr(ping_array_new(&c_mem, 1, 1)), nullptr);
|
|
}
|
|
|
|
TEST(PingArray, MinimumArraySizeIsOne)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
EXPECT_EQ(ping_array_new(&c_mem, 0, 1), nullptr);
|
|
EXPECT_NE(Ping_Array_Ptr(ping_array_new(&c_mem, 1, 1)), nullptr);
|
|
}
|
|
|
|
TEST(PingArray, ArraySizeMustBePowerOfTwo)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
|
|
Ping_Array_Ptr arr;
|
|
arr.reset(ping_array_new(&c_mem, 2, 1));
|
|
EXPECT_NE(arr, nullptr);
|
|
arr.reset(ping_array_new(&c_mem, 4, 1));
|
|
EXPECT_NE(arr, nullptr);
|
|
arr.reset(ping_array_new(&c_mem, 1024, 1));
|
|
EXPECT_NE(arr, nullptr);
|
|
|
|
EXPECT_EQ(ping_array_new(&c_mem, 1023, 1), nullptr);
|
|
EXPECT_EQ(ping_array_new(&c_mem, 1234, 1), nullptr);
|
|
}
|
|
|
|
TEST(PingArray, StoredDataCanBeRetrieved)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
auto c_rng = env.fake_random().c_random();
|
|
|
|
Ping_Array_Ptr const arr(ping_array_new(&c_mem, 2, 1));
|
|
Mono_Time_Ptr const mono_time(mono_time_new(&c_mem, nullptr, nullptr), c_mem);
|
|
ASSERT_NE(mono_time, nullptr);
|
|
|
|
std::uint64_t const ping_id = ping_array_add(
|
|
arr.get(), mono_time.get(), &c_rng, std::vector<std::uint8_t>{1, 2, 3, 4}.data(), 4);
|
|
EXPECT_NE(ping_id, 0);
|
|
|
|
std::vector<std::uint8_t> data(4);
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), data.data(), data.size(), ping_id), 4);
|
|
EXPECT_EQ(data, std::vector<std::uint8_t>({1, 2, 3, 4}));
|
|
}
|
|
|
|
TEST(PingArray, RetrievingDataWithTooSmallOutputBufferHasNoEffect)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
auto c_rng = env.fake_random().c_random();
|
|
|
|
Ping_Array_Ptr const arr(ping_array_new(&c_mem, 2, 1));
|
|
Mono_Time_Ptr const mono_time(mono_time_new(&c_mem, nullptr, nullptr), c_mem);
|
|
ASSERT_NE(mono_time, nullptr);
|
|
|
|
std::uint64_t const ping_id = ping_array_add(
|
|
arr.get(), mono_time.get(), &c_rng, (std::vector<std::uint8_t>{1, 2, 3, 4}).data(), 4);
|
|
EXPECT_NE(ping_id, 0);
|
|
|
|
std::vector<std::uint8_t> data(4);
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), data.data(), 3, ping_id), -1);
|
|
// It doesn't write anything to the data array.
|
|
EXPECT_EQ(data, std::vector<std::uint8_t>({0, 0, 0, 0}));
|
|
// Afterwards, we can still read it.
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), data.data(), 4, ping_id), 4);
|
|
EXPECT_EQ(data, std::vector<std::uint8_t>({1, 2, 3, 4}));
|
|
}
|
|
|
|
TEST(PingArray, ZeroLengthDataCanBeAdded)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
auto c_rng = env.fake_random().c_random();
|
|
|
|
Ping_Array_Ptr const arr(ping_array_new(&c_mem, 2, 1));
|
|
Mono_Time_Ptr const mono_time(mono_time_new(&c_mem, nullptr, nullptr), c_mem);
|
|
ASSERT_NE(mono_time, nullptr);
|
|
|
|
std::uint8_t c = 0;
|
|
std::uint64_t const ping_id = ping_array_add(arr.get(), mono_time.get(), &c_rng, &c, sizeof(c));
|
|
EXPECT_NE(ping_id, 0);
|
|
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), &c, sizeof(c), ping_id), 1);
|
|
}
|
|
|
|
TEST(PingArray, PingId0IsInvalid)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
|
|
Ping_Array_Ptr const arr(ping_array_new(&c_mem, 2, 1));
|
|
Mono_Time_Ptr const mono_time(mono_time_new(&c_mem, nullptr, nullptr), c_mem);
|
|
ASSERT_NE(mono_time, nullptr);
|
|
|
|
std::uint8_t c = 0;
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), &c, sizeof(c), 0), -1);
|
|
}
|
|
|
|
// Protection against replay attacks.
|
|
TEST(PingArray, DataCanOnlyBeRetrievedOnce)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
auto c_rng = env.fake_random().c_random();
|
|
|
|
Ping_Array_Ptr const arr(ping_array_new(&c_mem, 2, 1));
|
|
Mono_Time_Ptr const mono_time(mono_time_new(&c_mem, nullptr, nullptr), c_mem);
|
|
ASSERT_NE(mono_time, nullptr);
|
|
|
|
std::uint8_t c = 0;
|
|
std::uint64_t const ping_id = ping_array_add(arr.get(), mono_time.get(), &c_rng, &c, sizeof(c));
|
|
EXPECT_NE(ping_id, 0);
|
|
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), &c, sizeof(c), ping_id), 1);
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), &c, sizeof(c), ping_id), -1);
|
|
}
|
|
|
|
TEST(PingArray, PingIdMustMatchOnCheck)
|
|
{
|
|
SimulatedEnvironment env;
|
|
auto c_mem = env.fake_memory().c_memory();
|
|
auto c_rng = env.fake_random().c_random();
|
|
|
|
Ping_Array_Ptr const arr(ping_array_new(&c_mem, 1, 1));
|
|
Mono_Time_Ptr const mono_time(mono_time_new(&c_mem, nullptr, nullptr), c_mem);
|
|
ASSERT_NE(mono_time, nullptr);
|
|
|
|
std::uint8_t c = 0;
|
|
std::uint64_t const ping_id = ping_array_add(arr.get(), mono_time.get(), &c_rng, &c, sizeof(c));
|
|
EXPECT_NE(ping_id, 0);
|
|
|
|
std::uint64_t const bad_ping_id = ping_id == 1 ? 2 : 1;
|
|
|
|
// bad_ping_id will also be pointing at the same element, but won't match the
|
|
// actual ping_id.
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), &c, sizeof(c), bad_ping_id), -1);
|
|
EXPECT_EQ(ping_array_check(arr.get(), mono_time.get(), &c, sizeof(c), ping_id), 1);
|
|
}
|
|
|
|
} // namespace
|